From: "Simon Arlott" <simon@fire.lp0.eu>
To: "Rob Herring" <robh+dt@kernel.org>,
"Philipp Zabel" <p.zabel@pengutronix.de>
Cc: "Kevin Cernekee" <cernekee@gmail.com>,
"Florian Fainelli" <f.fainelli@gmail.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
linux-kernel@vger.kernel.org,
"MIPS Mailing List" <linux-mips@linux-mips.org>,
"Pawel Moll" <pawel.moll@arm.com>,
"Mark Rutland" <mark.rutland@arm.com>,
"Ian Campbell" <ijc+devicetree@hellion.org.uk>,
"Sergei Shtylyov" <sergei.shtylyov@cogentembedded.com>
Subject: Re: [PATCH (v2) 1/2] reset: Add brcm,bcm6345-reset device tree binding
Date: Fri, 4 Dec 2015 21:12:10 -0000 [thread overview]
Message-ID: <6a3790afc811ac4ed732371f2eb33a7c194b996d@8b5064a13e22126c1b9329f0dc35b8915774b7c3.invalid> (raw)
In-Reply-To: <1449131943.3339.8.camel@pengutronix.de>
On Thu, December 3, 2015 08:39, Philipp Zabel wrote:
> Am Mittwoch, den 02.12.2015, 21:03 +0000 schrieb Simon Arlott:
>> +periph_soft_rst: reset-controller {
>> + compatible = "brcm,bcm63168-reset", "brcm,bcm6345-reset";
>> + regmap = <&periph_cntl>;
>> + offset = <0x10>;
>> +
>> + #reset-cells = <1>;
>> +};
>
> I would have written it something like this:
>
> periph_cntl: ... {
> compatible = "syscon", "simple-mfd";
> #address-cells = <1>;
> #size-cells = <1>;
>
> periph_soft_rst: reset-controller {
> compatible = "brcm,bcm6345-reset";
> reg = <0x10 0x4>;
> #reset-cells = <1>;
> };
> };
>
> for a device that is only controlled through a syscon.
Rob, do you want me to change this or is my version ok?
> The driver itself looks good to me.
>
> best regards
> Philipp
>
>
--
Simon Arlott
next prev parent reply other threads:[~2015-12-04 21:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-02 21:03 [PATCH (v2) 1/2] reset: Add brcm,bcm6345-reset device tree binding Simon Arlott
2015-12-02 21:04 ` [PATCH (v2) 2/2] reset: bcm6345: Add support for the BCM6345 soft-reset controller Simon Arlott
2015-12-03 8:39 ` [PATCH (v2) 1/2] reset: Add brcm,bcm6345-reset device tree binding Philipp Zabel
2015-12-04 21:12 ` Simon Arlott [this message]
2015-12-04 14:59 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a3790afc811ac4ed732371f2eb33a7c194b996d@8b5064a13e22126c1b9329f0dc35b8915774b7c3.invalid \
--to=simon@fire.lp0.eu \
--cc=cernekee@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=mark.rutland@arm.com \
--cc=p.zabel@pengutronix.de \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).