From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-17.3 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI,NICE_REPLY_A, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E6E39C193FE for ; Tue, 8 Dec 2020 04:48:01 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C0CDA23A58 for ; Tue, 8 Dec 2020 04:48:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727391AbgLHEsB (ORCPT ); Mon, 7 Dec 2020 23:48:01 -0500 Received: from fllv0016.ext.ti.com ([198.47.19.142]:35170 "EHLO fllv0016.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727258AbgLHEsA (ORCPT ); Mon, 7 Dec 2020 23:48:00 -0500 Received: from fllv0035.itg.ti.com ([10.64.41.0]) by fllv0016.ext.ti.com (8.15.2/8.15.2) with ESMTP id 0B84kqxV039474; Mon, 7 Dec 2020 22:46:52 -0600 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1607402812; bh=ab8TR71D8wvDMjyDs6nWrexGzGp6Fis30WChrKD0GJI=; h=Subject:To:CC:References:From:Date:In-Reply-To; b=I1KcsdWfGGYKukU1vhdrJMy3dUirqKSS8jiSFV+azOygxU/WmetaeoFr4QPN7fk2O UxFK+NyVzyVyTqtyzzKkTiA5UZ3MYqpYSyGYUd55RbkWH+14VndD7BbKV2RBM8eASt vb+sJt5xjkxsIKdGHs+vPyuQAw00hfK8AW8HWujc= Received: from DLEE106.ent.ti.com (dlee106.ent.ti.com [157.170.170.36]) by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 0B84kqEQ098505 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Mon, 7 Dec 2020 22:46:52 -0600 Received: from DLEE102.ent.ti.com (157.170.170.32) by DLEE106.ent.ti.com (157.170.170.36) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3; Mon, 7 Dec 2020 22:46:52 -0600 Received: from lelv0326.itg.ti.com (10.180.67.84) by DLEE102.ent.ti.com (157.170.170.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1979.3 via Frontend Transport; Mon, 7 Dec 2020 22:46:52 -0600 Received: from [10.250.235.36] (ileax41-snat.itg.ti.com [10.172.224.153]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 0B84kkoW053051; Mon, 7 Dec 2020 22:46:47 -0600 Subject: Re: [PATCH v8 16/18] NTB: tool: Enable the NTB/PCIe link on the local or remote side of bridge To: "Jiang, Dave" , Bjorn Helgaas , Jonathan Corbet , Lorenzo Pieralisi , Arnd Bergmann , Jon Mason , Allen Hubbe , Tom Joseph , Rob Herring CC: Greg Kroah-Hartman , "linux-pci@vger.kernel.org" , "linux-doc@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linux-ntb@googlegroups.com" References: <20201111153559.19050-1-kishon@ti.com> <20201111153559.19050-17-kishon@ti.com> From: Kishon Vijay Abraham I Message-ID: <6a493055-eef0-5722-e24b-449a11cf8a36@ti.com> Date: Tue, 8 Dec 2020 10:16:46 +0530 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Dave, On 07/12/20 9:25 pm, Jiang, Dave wrote: > > >> -----Original Message----- >> From: Kishon Vijay Abraham I >> Sent: Wednesday, November 11, 2020 8:36 AM >> To: Bjorn Helgaas ; Jonathan Corbet >> ; Kishon Vijay Abraham I ; Lorenzo >> Pieralisi ; Arnd Bergmann ; >> Jon Mason ; Jiang, Dave ; >> Allen Hubbe ; Tom Joseph ; >> Rob Herring >> Cc: Greg Kroah-Hartman ; linux- >> pci@vger.kernel.org; linux-doc@vger.kernel.org; linux- >> kernel@vger.kernel.org; linux-ntb@googlegroups.com >> Subject: [PATCH v8 16/18] NTB: tool: Enable the NTB/PCIe link on the local or >> remote side of bridge >> >> Invoke ntb_link_enable() to enable the NTB/PCIe link on the local or remote >> side of the bridge. >> >> Signed-off-by: Kishon Vijay Abraham I >> --- >> drivers/ntb/test/ntb_tool.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/ntb/test/ntb_tool.c b/drivers/ntb/test/ntb_tool.c index >> b7bf3f863d79..8230ced503e3 100644 >> --- a/drivers/ntb/test/ntb_tool.c >> +++ b/drivers/ntb/test/ntb_tool.c >> @@ -1638,6 +1638,7 @@ static int tool_probe(struct ntb_client *self, struct >> ntb_dev *ntb) >> >> tool_setup_dbgfs(tc); >> >> + ntb_link_enable(ntb, NTB_SPEED_AUTO, NTB_WIDTH_AUTO); > > The tool expects the user to enable the link via debugfs according to documentation. Is this necessary? right, it can be enabled using debugfs. Will drop this patch. Thank You, Kishon