From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: Thierry Reding <thierry.reding@gmail.com>,
David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Mark Brown <broonie@kernel.org>,
Tomi Valkeinen <tomi.valkeinen@ti.com>,
Andrzej Hajda <andrzej.hajda@intel.com>,
Maxime Ripard <mripard@kernel.org>,
Marek Belisko <marek@goldelico.com>,
"H. Nikolaus Schaller" <hns@goldelico.com>,
Pratyush Yadav <p.yadav@ti.com>,
dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-spi@vger.kernel.org,
Jonathan Cameron <jic23@kernel.org>,
Rob Herring <robh@kernel.org>
Subject: Re: [PATCH v2 1/1] spi/panel: dt-bindings: drop CPHA and CPOL from common properties
Date: Sat, 23 Jul 2022 20:10:04 +0200 [thread overview]
Message-ID: <6a4c74fe-5558-5455-1f79-0289e10294b2@linaro.org> (raw)
In-Reply-To: <Ytr+Q6kXr+f6dCfi@ravnborg.org>
On 22/07/2022 21:45, Sam Ravnborg wrote:
> Hi Krzysztof
>
> On Fri, Jul 22, 2022 at 09:15:39PM +0200, Krzysztof Kozlowski wrote:
>> The spi-cpha and spi-cpol properties are device specific and should be
>> accepted only if device really needs them. Drop them from common
>> spi-peripheral-props.yaml schema, mention in few panel drivers which use
>> themi
>
> "and include instead in the SPI controller bindings."
>
> I cannot see you do this in the touched bindings.
Yep, because you always have two schemas being in play. One is SPI
controller and other is the device (SPI slave).
> So I cannot see how for example samsung,ld9040.yaml picks up
> spi-controller.yaml and thus it no longer knows the spi-cpha and spi-cpol
> properties.
ld9040 is not spi-controller, but a SPI slave device, AFAIU. It will be
therefore a child of some SPI controller, thus the SPI controller
schema, which includes spi-controller.yaml, will validate the type of
spi-cpha/cpol properties.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-07-23 18:10 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-22 19:15 [PATCH v2 0/1] dt-bindings: spi/display/panel: drop SPI CPHA and CPOL Krzysztof Kozlowski
2022-07-22 19:15 ` [PATCH v2 1/1] spi/panel: dt-bindings: drop CPHA and CPOL from common properties Krzysztof Kozlowski
2022-07-22 19:45 ` Sam Ravnborg
2022-07-23 18:10 ` Krzysztof Kozlowski [this message]
2022-07-25 23:14 ` Rob Herring
2022-07-31 10:59 ` Jonathan Cameron
2022-07-26 12:20 ` [PATCH v2 0/1] dt-bindings: spi/display/panel: drop SPI CPHA and CPOL Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a4c74fe-5558-5455-1f79-0289e10294b2@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=airlied@linux.ie \
--cc=andrzej.hajda@intel.com \
--cc=broonie@kernel.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=hns@goldelico.com \
--cc=jic23@kernel.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=marek@goldelico.com \
--cc=mripard@kernel.org \
--cc=p.yadav@ti.com \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
--cc=sam@ravnborg.org \
--cc=thierry.reding@gmail.com \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).