From: Randy Dunlap <rdunlap@infradead.org>
To: "Vaittinen, Matti" <Matti.Vaittinen@fi.rohmeurope.com>,
LKML <linux-kernel@vger.kernel.org>,
Mark Brown <broonie@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>
Subject: Re: [PATCH] regulator: bd71837: add <linux/of.h> to fix build errors
Date: Wed, 7 Nov 2018 08:38:50 -0800 [thread overview]
Message-ID: <6a52ae58-b5d6-d86b-3597-5b8a1fe30e97@infradead.org> (raw)
In-Reply-To: <042F8805D2046347BB8420BEAE397A4066F1CF4C@WILL-MAIL001.REu.RohmEu.com>
On 10/25/18 11:02 PM, Vaittinen, Matti wrote:
> Hello,
>
> From: Randy Dunlap <rdunlap@infradead.org>
>
>> Fix build error due to missing header file:
>>
>> drivers/regulator/bd71837-regulator.c:242:3: error: implicit declaration of function 'of_match_ptr' [-Werror=implicit-function-declaration]
>>
>> Fixes: ba08799e90b5 ("regulator: bd71837: BD71837 PMIC regulator driver")
>
> //snip
>
>> --- lnx-419.orig/drivers/regulator/bd71837-regulator.c
>> +++ lnx-419/drivers/regulator/bd71837-regulator.c
>> @@ -9,6 +9,7 @@
>> #include <linux/kernel.h>
>> #include <linux/mfd/rohm-bd718x7.h>
>> #include <linux/module.h>
>> +#include <linux/of.h>
>> #include <linux/platform_device.h>
>> #include <linux/regulator/driver.h>
>> #include <linux/regulator/machine.h>
>
> Not sure if this is relevant but if I am not mistaken this should already be fixed by:
> df43519eb706edfe951284a825642ce2e1d38d09
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=df43519eb706edfe951284a825642ce2e1d38d09
>
>
> Br,
> Matti Vaittinen
>
Hi,
It seems that this same patch is now needed in
drivers/regulator/bd718x7-regulator.c:
From linux-next-2018-11-07:
file: drivers/regulator/bd718x7-regulator.c: errors: 109, warnings: 0
This is a small sample of the errors:
CC [M] drivers/regulator/bd718x7-regulator.o
../drivers/regulator/bd718x7-regulator.c:355:4: error: implicit declaration of function ‘of_match_ptr’ [-Werror=implicit-function-declaration]
.of_match = of_match_ptr("BUCK1"),
^
../drivers/regulator/bd718x7-regulator.c:355:4: error: initializer element is not constant
../drivers/regulator/bd718x7-regulator.c:355:4: error: (near initialization for ‘bd71847_regulators[0].desc.of_match’)
../drivers/regulator/bd718x7-regulator.c:356:4: error: initializer element is not constant
.regulators_node = of_match_ptr("regulators"),
^
../drivers/regulator/bd718x7-regulator.c:356:4: error: (near initialization for ‘bd71847_regulators[0].desc.regulators_node’)
../drivers/regulator/bd718x7-regulator.c:379:4: error: initializer element is not constant
.of_match = of_match_ptr("BUCK2"),
^
thanks,
--
~Randy
next prev parent reply other threads:[~2018-11-07 16:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-25 22:48 [PATCH] regulator: bd71837: add <linux/of.h> to fix build errors Randy Dunlap
2018-10-26 6:02 ` Vaittinen, Matti
2018-11-07 16:38 ` Randy Dunlap [this message]
2018-11-08 6:50 ` Matti Vaittinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6a52ae58-b5d6-d86b-3597-5b8a1fe30e97@infradead.org \
--to=rdunlap@infradead.org \
--cc=Matti.Vaittinen@fi.rohmeurope.com \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).