From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 148AAC433FE for ; Sun, 15 May 2022 09:52:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236168AbiEOJwi (ORCPT ); Sun, 15 May 2022 05:52:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57792 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234276AbiEOJwf (ORCPT ); Sun, 15 May 2022 05:52:35 -0400 Received: from mail-lf1-x12d.google.com (mail-lf1-x12d.google.com [IPv6:2a00:1450:4864:20::12d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B432831237 for ; Sun, 15 May 2022 02:52:33 -0700 (PDT) Received: by mail-lf1-x12d.google.com with SMTP id h29so21321051lfj.2 for ; Sun, 15 May 2022 02:52:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=message-id:date:mime-version:user-agent:subject:content-language:to :references:from:in-reply-to:content-transfer-encoding; bh=rt8GD04SlHYb1Rr/ubbOdUfsFsvikQRWfi701Og0DSE=; b=O3y+znDeMkhRNhXdPi4VX0F2FuixGdSGNENwopvN8V7frsw0NHH44oubVz49zYX+El oDd8OW+tOVVrDwE3UClekozQ/fxvXDwz+AXE2ssqqb2U87I6LPLXs2AH+ZQlaLjA5wES IPY/7nw3LR5Byn72zH4DzqKyndq2NKQjcRT09gd/BtX16SCF8dXPQBPHegztztihQ+nH tE8n2HGqkputrTqdFF2X6D4W4BFcqphk8wHGCAksEEOFHF6zPttG1HwzCnyNxZsZnjPO NMeq5+KQqXocD6UthBG1H5sXuVUUUa4SMjbLg/0DJQNaj9Iayd9zI2+kVUJkSkZh1KqT pNmQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:references:from:in-reply-to :content-transfer-encoding; bh=rt8GD04SlHYb1Rr/ubbOdUfsFsvikQRWfi701Og0DSE=; b=KGScbI4EGPRifHiu65CZjjV0C0412CYKxFUHVA/lXeyFUZv3rfsWtn5Vk3wQNw3I55 5K9PwtlicbGemlyR07/h7tGJNzzUWV32xjYl9nJTczq6IYHnOJd8usBFmfyOqDjejJug sxVmoRTtmi4xCqjXu9F9Z9/IrGM/9KjaR6kQ7YCspTMwtgMKYr1aq2g4VxUIFw2eN64I wW9V3jcymmaualkTykuhhWSdh7LPPKP7dFSdmfRh4NjLcQDE8ROq5IN5V9mTx2q0h0fd ZxETngPoe6c8JQR5ZSuRey/sIXw8RGGFqeXHMvbJLnyisMP3Q1pPbmqPQheB3k6nK2rV SZaA== X-Gm-Message-State: AOAM530Z9dPKwCp30XcFLgN6lsN8hKzDgBaToI9hH+jDHXq7atJBIh9I em7LNJTMOyix9kO1IGQOjpL9/g== X-Google-Smtp-Source: ABdhPJyQJFLoQyoq67lC0iakWsWO0cEp3S1ihY/piIgS3mZir/EsLOvk7+Cw3J/JROYpmdI8MMI82g== X-Received: by 2002:a19:7015:0:b0:473:d75a:7a3d with SMTP id h21-20020a197015000000b00473d75a7a3dmr9001190lfc.525.1652608352120; Sun, 15 May 2022 02:52:32 -0700 (PDT) Received: from [192.168.0.17] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id d13-20020a056512368d00b0047255d21136sm967619lfs.101.2022.05.15.02.52.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 15 May 2022 02:52:31 -0700 (PDT) Message-ID: <6a6ed76a-50fa-2b05-896e-8936d3c3f597@linaro.org> Date: Sun, 15 May 2022 11:52:30 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCHv2 1/6] thermal: exynos: Enable core tmu hardware clk flag on exynos platform Content-Language: en-US To: Anand Moon , Bartlomiej Zolnierkiewicz , "Rafael J. Wysocki" , Daniel Lezcano , Amit Kucheria , Zhang Rui , Alim Akhtar , linux-pm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org References: <20220515064126.1424-1-linux.amoon@gmail.com> <20220515064126.1424-2-linux.amoon@gmail.com> From: Krzysztof Kozlowski In-Reply-To: <20220515064126.1424-2-linux.amoon@gmail.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15/05/2022 08:41, Anand Moon wrote: > Use clk_prepare_enable api to enable tmu internal hardware clock > flag on, use clk_disable_unprepare to disable the clock. > > Cc: Bartlomiej Zolnierkiewicz > Signed-off-by: Anand Moon Here as well you ignored my first comment: https://lore.kernel.org/lkml/CANAwSgS=08fVsqn95WHzSF71WTTyD2-=K2C6-BEz0tY0t6A1-g@mail.gmail.com/T/#mbfc57b40a7ed043dd4d4890bedb6bad8240058cd "This is not valid reason to do a change. What is clk_summary does not really matter. Your change has negative impact on power consumption as the clock stays enabled all the time. This is not what we want... so please explain it more - why you need the clock to be enabled all the time? What is broken (clk_summary is not broken in this case)?" This was not addressed, you just resent same code... Best regards, Krzysztof