From: Daniel Lezcano <daniel.lezcano@linaro.org>
To: Di Shen <cindygm567@gmail.com>
Cc: Lukasz Luba <lukasz.luba@arm.com>, Di Shen <di.shen@unisoc.com>,
linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org,
xuewen.yan@unisoc.com, jeson.gao@unisoc.com, zhanglyra@gmail.com,
orsonzhai@gmail.com, rui.zhang@intel.com, amitk@kernel.org,
rafael@kernel.org
Subject: Re: [PATCH V3] thermal/core/power_allocator: avoid thermal cdev can not be reset
Date: Fri, 14 Apr 2023 13:12:21 +0200 [thread overview]
Message-ID: <6aad180f-410c-5b11-b30b-c7bc02cbe054@linaro.org> (raw)
In-Reply-To: <CAHYJL4qJwKHFsCPUvLzmUEAJtEfHDAO23D5=0zAXOYSCABJ8_g@mail.gmail.com>
On 13/04/2023 10:40, Di Shen wrote:
> We have discussed this question in patch-v1:
> https://lore.kernel.org/all/f6aaa5f1-495d-a158-14d8-ddb2bffbd9c2@arm.com/
>
> Simply put, we use the trip_temp in the Android System; set different
> trip_temp for thermal control of different scenarios.
The changes are dealing with the trip points and trying to detect the
threshold. That part should be handled in the thermal core or thermal
trip side, not in the governor.
AFAICT, if a trip point is changed, then the power allocator should be
reset, including the cdev state.
It would be more convenient to add an ops to the governor ops structure
to reset the governor and then call it when a trip point is changed in
thermal_zone_set_trip()
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
next prev parent reply other threads:[~2023-04-14 11:12 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-20 9:56 [PATCH V3] thermal/core/power_allocator: avoid thermal cdev can not be reset Di Shen
2023-03-20 12:24 ` Lukasz Luba
2023-04-10 2:09 ` Di Shen
2023-04-10 19:51 ` Daniel Lezcano
2023-04-11 7:17 ` Lukasz Luba
2023-04-13 4:51 ` Di Shen
2023-04-13 7:37 ` Daniel Lezcano
2023-04-13 8:40 ` Di Shen
2023-04-14 11:12 ` Daniel Lezcano [this message]
2023-04-14 14:18 ` Lukasz Luba
2023-04-14 15:06 ` Daniel Lezcano
2023-04-14 15:21 ` Lukasz Luba
2023-05-25 6:39 ` Di Shen
2023-06-19 6:35 ` [PATCH V4] thermal/core/power_allocator: reset thermal governor when trip point is changed Di Shen
2023-06-20 9:46 ` Rafael J. Wysocki
2023-06-20 10:07 ` Rafael J. Wysocki
2023-06-20 10:20 ` Lukasz Luba
2023-06-20 10:39 ` Rafael J. Wysocki
2023-06-20 11:56 ` Lukasz Luba
2023-06-22 18:27 ` Rafael J. Wysocki
2023-06-23 7:43 ` Lukasz Luba
2023-06-23 16:55 ` Rafael J. Wysocki
2023-06-23 17:34 ` Lukasz Luba
2023-06-25 8:40 ` Di Shen
2023-06-25 8:39 ` Di Shen
2023-06-26 7:45 ` Lukasz Luba
2023-06-20 10:38 ` Lukasz Luba
2023-06-21 4:51 ` Di Shen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6aad180f-410c-5b11-b30b-c7bc02cbe054@linaro.org \
--to=daniel.lezcano@linaro.org \
--cc=amitk@kernel.org \
--cc=cindygm567@gmail.com \
--cc=di.shen@unisoc.com \
--cc=jeson.gao@unisoc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lukasz.luba@arm.com \
--cc=orsonzhai@gmail.com \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
--cc=xuewen.yan@unisoc.com \
--cc=zhanglyra@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).