From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932645AbcFJMKU (ORCPT ); Fri, 10 Jun 2016 08:10:20 -0400 Received: from mx08-00178001.pphosted.com ([91.207.212.93]:60002 "EHLO mx07-00178001.pphosted.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752020AbcFJMKQ (ORCPT ); Fri, 10 Jun 2016 08:10:16 -0400 Subject: Re: [PATCH v3 1/1] net: ethernet: Add TSE PCS support to dwmac-socfpga To: Tien Hock Loh References: <1465268516-31480-1-git-send-email-thloh@altera.com> <1465451310.4467.21.camel@ubuntu> <1465539145.4467.42.camel@ubuntu> CC: , , , , , , , , , Chee Nouk Phoon From: Giuseppe CAVALLARO Message-ID: <6ab2c663-5559-5818-5357-6801ff452dfb@st.com> Date: Fri, 10 Jun 2016 14:09:54 +0200 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.1.0 MIME-Version: 1.0 In-Reply-To: <1465539145.4467.42.camel@ubuntu> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [10.52.139.54] X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-06-10_08:,, signatures=0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello Tien Hock On 6/10/2016 8:12 AM, Tien Hock Loh wrote: >>> Yeah the PCS support for TSE is Altera. To avoid confusion, let's rename >>> > > them, would altr_tse_pcs.[hc] be good? I don't think creating a >>> > > sub-directory with only 2 files is necessary though. >> > >> > ok for two files w/o sub-dir. >> > >>> > > >>> > > I see that stmmac.txt is generic, and other vendor's PCS support >>> > > documents their specific uses in their own *-dwmac.txt (eg. >>> > > rockchip-dwmac.txt). Is this not the case? >> > >> > yes you can use this name convention. I let you decide. > What I meant was we've documented the bindings in socfpga-dwmac.txt for > platform specific bindings, and I won't be updating stmmac.txt because > that is the generic driver binding. Agree? ok if you documented all in socfpga-dwmac.txt peppe