From: Shazad Hussain <quic_shazhuss@quicinc.com>
To: Brian Masney <bmasney@redhat.com>,
Konrad Dybcio <konrad.dybcio@linaro.org>
Cc: <andersson@kernel.org>, <krzysztof.kozlowski+dt@linaro.org>,
<robh+dt@kernel.org>, <johan+linaro@kernel.org>,
<linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <ahalaney@redhat.com>,
<echanude@redhat.com>
Subject: Re: [PATCH 3/4] arm64: dts: qcom: sa8540p-ride: add qup1_i2c15 and qup2_i2c18 nodes
Date: Wed, 14 Dec 2022 21:06:48 +0530 [thread overview]
Message-ID: <6ab9171e-127b-12f3-cfe6-0fbf2b37080c@quicinc.com> (raw)
In-Reply-To: <Y5nB1epKN4nbk3ma@x1>
On 12/14/2022 6:00 PM, Brian Masney wrote:
> On Tue, Dec 13, 2022 at 03:48:27PM +0100, Konrad Dybcio wrote:
>>> + qup1_i2c15_default: qup1-i2c15-state {
>>> + mux-pins {
>>> + pins = "gpio36", "gpio37";
>>> + function = "qup15";
>>> + };
>>> +
>>> + config-pins {
>>> + pins = "gpio36", "gpio37";
>>> + drive-strength = <0x02>;
>>> + bias-pull-up;
>>> + };
>>> + };
>>
>> You can drop mux/config-pins and have the pin properties live directly
>> under the qup1-i2cN-state node.
>
> Hi Konrad (and Shazad below),
>
> I need to enable 5 i2c buses (0, 1, 12, 15, 18) on this board. I tried
> the following combinations with the pin mapping configuration and the
> only one that seems to work reliably for me is what I originally had.
>
> With the following, only 2 out of the 5 buses are detected. There's no
> i2c mesages in dmesg.
>
> i2c0_default: i2c0-default-state {
> pins = "gpio135", "gpio136";
> function = "qup15";
> };
>
> Next, I added a drive-strength and bias-pull-up. All 5 buses are
> detected. One bus throws read errors when I probe it with i2cdetect, two
> others 'i2cdetect -a -y $BUSNUM' takes ~5 seconds to run, and the
This I have also observed on downstream as well, where scanning all
addresses takes some amount of time near to 5-6 seconds.
> remaining two are fast.
>
> i2c0_default: i2c0-default-state {
> pins = "gpio135", "gpio136";
> function = "qup15";
> drive-strength = <2>;
> bias-pull-up;
> };
>
This is the default config we should use.
> This is the style where i2cdetect seems to be happy for all 5 buses and
> is fast:
>
> i2c0_default: i2c0-default-state {
> mux-pins {
> pins = "gpio135", "gpio136";
> function = "qup0";
> };
>
> config-pins {
> pins = "gpio135", "gpio136";
> drive-strength = <2>;
> bias-pull-up;
> };
> };
>
>
> Shazad: 'i2cdetect -a -y $BUSNUM) shows that all 5 buses have the same
> addresses listening. Is that expected? That seems a bit odd to me.
>
Brian, even I haven't checked with all enabled, let me check this on
other projects and with downstream as well and get back to you.
-Shazad
> [root@localhost ~]# i2cdetect -a -y 0
> Warning: Can't use SMBus Quick Write command, will skip some addresses
> 0 1 2 3 4 5 6 7 8 9 a b c d e f
> 00:
> 10:
> 20:
> 30: -- -- -- -- -- -- -- --
> 40:
> 50: -- -- -- -- -- -- -- -- -- -- -- -- -- -- -- --
> 60:
> 70:
>
> I triple checked that I have the QUP pins defined correctly for the 5
> buses. I checked them against what's in the downstream kernel and I also
> checked them against what's in upstream's
> drivers/pinctrl/qcom/pinctrl-sc8280xp.c. This is the pin mapping that I
> have:
>
> i2c0: gpio135, gpio136
> i2c1: gpio158, gpio159
> i2c12: gpio0, gpio1
> i2c15: gpio36, gpio37
> i2c18: gpio66, gpio67
>
> Brian
>
next prev parent reply other threads:[~2022-12-14 15:37 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-12 18:23 [PATCH 0/4] arm64: dts: qcom: sc8280xp: add i2c and spi nodes Brian Masney
2022-12-12 18:23 ` [PATCH 1/4] arm64: dts: qcom: sc8280xp: rename i2c5 to i2c21 Brian Masney
2022-12-12 18:48 ` Konrad Dybcio
2022-12-13 14:54 ` Johan Hovold
2022-12-13 15:04 ` Shazad Hussain
2022-12-13 15:19 ` Johan Hovold
2022-12-13 15:05 ` Brian Masney
2022-12-13 15:12 ` Brian Masney
2022-12-13 15:28 ` Johan Hovold
2022-12-13 15:34 ` Shazad Hussain
2022-12-13 15:39 ` Johan Hovold
2022-12-13 15:42 ` Johan Hovold
2022-12-13 15:44 ` Konrad Dybcio
2022-12-13 16:15 ` Johan Hovold
2022-12-13 15:45 ` Shazad Hussain
2022-12-13 15:17 ` Johan Hovold
2022-12-13 15:29 ` Konrad Dybcio
2022-12-13 15:32 ` Johan Hovold
2022-12-13 15:59 ` Brian Masney
2022-12-13 16:22 ` Johan Hovold
2022-12-12 18:23 ` [PATCH 2/4] arm64: dts: qcom: sc8280xp: add missing i2c nodes Brian Masney
2022-12-12 18:23 ` [PATCH 3/4] arm64: dts: qcom: sa8540p-ride: add qup1_i2c15 and qup2_i2c18 nodes Brian Masney
2022-12-13 7:18 ` Shazad Hussain
2022-12-13 14:48 ` Konrad Dybcio
2022-12-14 12:30 ` Brian Masney
2022-12-14 12:52 ` Krzysztof Kozlowski
2022-12-14 14:19 ` Brian Masney
2022-12-14 12:53 ` Konrad Dybcio
2022-12-14 15:36 ` Shazad Hussain [this message]
2022-12-14 16:24 ` Brian Masney
2022-12-13 14:59 ` Johan Hovold
2022-12-14 12:51 ` Krzysztof Kozlowski
2022-12-12 18:23 ` [PATCH 4/4] arm64: dts: qcom: sc8280xp: add missing spi nodes Brian Masney
2022-12-13 7:16 ` Shazad Hussain
2022-12-13 12:27 ` Brian Masney
2022-12-13 12:47 ` Mark Brown
2022-12-13 13:02 ` Krzysztof Kozlowski
2022-12-13 13:08 ` Javier Martinez Canillas
2022-12-13 14:36 ` Brian Masney
2022-12-13 14:45 ` Shazad Hussain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ab9171e-127b-12f3-cfe6-0fbf2b37080c@quicinc.com \
--to=quic_shazhuss@quicinc.com \
--cc=ahalaney@redhat.com \
--cc=andersson@kernel.org \
--cc=bmasney@redhat.com \
--cc=devicetree@vger.kernel.org \
--cc=echanude@redhat.com \
--cc=johan+linaro@kernel.org \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).