From: "Tony Huang 黃懷厚" <tony.huang@sunplus.com>
To: Randy Dunlap <rdunlap@infradead.org>,
Tony Huang <tonyhuang.sunplus@gmail.com>,
"ulf.hansson@linaro.org" <ulf.hansson@linaro.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"p.zabel@pengutronix.de" <p.zabel@pengutronix.de>
Cc: "Wells Lu 呂芳騰" <wells.lu@sunplus.com>
Subject: RE: [PATCH 2/2] mmc: Add mmc driver for Sunplus SP7021
Date: Mon, 8 Nov 2021 08:02:52 +0000 [thread overview]
Message-ID: <6ac06fbd9280493ea2f34c6b6f7714ef@sphcmbx02.sunplus.com.tw> (raw)
In-Reply-To: <3da7cacf-d5ab-9f08-6d15-a75cf952d43d@infradead.org>
Dear Randy:
> [resending, had some kind of email error on the first try]
>
> On 11/6/21 7:23 AM, Tony Huang wrote:
> > diff --git a/drivers/mmc/host/Kconfig b/drivers/mmc/host/Kconfig index
> > ccc148c..2a78cbc 100644
> > --- a/drivers/mmc/host/Kconfig
> > +++ b/drivers/mmc/host/Kconfig
> > @@ -14,6 +14,15 @@ config MMC_DEBUG
> > added host drivers please don't invent their private macro for
> > debugging.
> >
> > +config MMC_SUNPLUS
> > + tristate "Sunplus SP7021 MMC Controller"
> > + depends on ARCH_SUNPLUS || SOC_I143 || SOC_Q645
> > + default y
>
> Is this needed to be able to boot? That's about the only reason that "default
> y" could be justified.
Yes, it needs to be able to be boot.
>
> > + help
> > + If you say yes here, you will get support for eMMC host interface
> > + on sunplus Socs.
>
> Sunplus SoCs.
I will modify.
>
> > + If unsure, say N.
> > + Sunplus eMMC Host Controller v4.51 support"
>
> What is that last line for?
I will remove last line.
>
> And all lines of the help text should be indented with one tab + 2 spaces per
> coding-style.rst.
Ok, I understand
>
> thanks.
> --
> ~Randy
prev parent reply other threads:[~2021-11-08 8:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-06 14:23 [PATCH 0/2] Add mmc driver for Sunplus SP7021 SOC Tony Huang
2021-11-06 14:23 ` [PATCH 1/2] dt-binding: mmc: Add mmc yaml file for Sunplus SP7021 Tony Huang
2021-11-07 19:20 ` Rob Herring
2021-11-08 17:16 ` Rob Herring
2021-11-08 22:50 ` Tony Huang 黃懷厚
2021-11-06 14:23 ` [PATCH 2/2] mmc: Add mmc driver " Tony Huang
2021-11-06 15:16 ` Randy Dunlap
2021-11-08 8:02 ` Tony Huang 黃懷厚 [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ac06fbd9280493ea2f34c6b6f7714ef@sphcmbx02.sunplus.com.tw \
--to=tony.huang@sunplus.com \
--cc=devicetree@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=rdunlap@infradead.org \
--cc=robh+dt@kernel.org \
--cc=tonyhuang.sunplus@gmail.com \
--cc=ulf.hansson@linaro.org \
--cc=wells.lu@sunplus.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).