From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, UNPARSEABLE_RELAY,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F070C433E1 for ; Sat, 11 Jul 2020 05:37:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7B7DC206F4 for ; Sat, 11 Jul 2020 05:37:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728009AbgGKFhB (ORCPT ); Sat, 11 Jul 2020 01:37:01 -0400 Received: from smtp.al2klimov.de ([78.46.175.9]:56974 "EHLO smtp.al2klimov.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726963AbgGKFhA (ORCPT ); Sat, 11 Jul 2020 01:37:00 -0400 Received: from authenticated-user (PRIMARY_HOSTNAME [PUBLIC_IP]) by smtp.al2klimov.de (Postfix) with ESMTPA id BE241BC07E; Sat, 11 Jul 2020 05:36:55 +0000 (UTC) Subject: Re: [PATCH] CREDITS: replace HTTP links with HTTPS ones and add myself To: Jonathan Corbet Cc: torvalds@linux-foundation.org, davej@codemonkey.org.uk, kvalo@codeaurora.org, luis.f.correia@gmail.com, cyphar@cyphar.com, paulburton@kernel.org, ribalda@kernel.org, martink@posteo.de, geert+renesas@glider.be, mchehab+samsung@kernel.org, linux-kernel@vger.kernel.org References: <20200710194342.33107-1-grandmaster@al2klimov.de> <20200710154630.31521104@lwn.net> From: "Alexander A. Klimov" Message-ID: <6ac84dff-e190-2664-c30e-9f6fc4dbc592@al2klimov.de> Date: Sat, 11 Jul 2020 07:36:54 +0200 MIME-Version: 1.0 In-Reply-To: <20200710154630.31521104@lwn.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Authentication-Results: smtp.al2klimov.de; auth=pass smtp.auth=aklimov@al2klimov.de smtp.mailfrom=grandmaster@al2klimov.de X-Spamd-Bar: / Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 10.07.20 um 23:46 schrieb Jonathan Corbet: > On Fri, 10 Jul 2020 21:43:42 +0200 > "Alexander A. Klimov" wrote: > >> Regarding the links: >> >> Rationale: >> Reduces attack surface on kernel devs opening the links for MITM >> as HTTPS traffic is much harder to manipulate. >> >> Deterministic algorithm: >> For each file: >> If not .svg: >> For each line: >> If doesn't contain `\bxmlns\b`: >> For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`: >> If both the HTTP and HTTPS versions >> return 200 OK and serve the same content: >> Replace HTTP with HTTPS. >> >> Regarding the addition of myself: > > A couple of things here... > >> Rationale: >> * 93431e0607e5 > > This is ... not particularly self-explanatory. Is that meant to be a > commit reference? If so, you would want to use the normal format. > >> * the replaced links in this patch > > If you are going to do something like make an addition to the file, you > need to do that separately from a cleanup patch. > > But somebody has to say this: I don't think we have any sort of laid-down > policy for what it takes to be mentioned in CREDITS, but I don't think that I have absolutely no problem with that. But IMAO you *should* have a such policy. At least for people who'd *have* a problem with that. > your work thus far clears whatever bar we might set. We don't immortalize > every person who submits some cleanup patches, or this file would be a long > one indeed. If you would like to be remembered for your kernel work, I > would respectfully suggest that you move beyond mechanical cleanups into > higher-level work. > > One other little thing that jumped out at me: > >> N: Alan Cox >> -W: http://www.linux.org.uk/diary/ >> +W: https://www.linux.org.uk/diary/ >> D: Linux Networking (0.99.10->2.0.29) >> D: Original Appletalk, AX.25, and IPX code >> D: 3c501 hacker > > That link just redirects to linux.com, which is probably not what Alan had > in mind. Replacing the link with one into the wayback machine (or perhaps > just removing it entirely) would seem like a more useful change than adding > HTTPS to a link that clearly does not reach the intended destination. > > Thanks, > > jon >