* [PATCH] drm/crtc-helper: drm_connector_get_single_encoder prototype is missing
@ 2019-11-19 12:58 Benjamin Gaignard
2019-11-19 18:53 ` Souza, Jose
0 siblings, 1 reply; 4+ messages in thread
From: Benjamin Gaignard @ 2019-11-19 12:58 UTC (permalink / raw)
To: maarten.lankhorst, mripard, sean, airlied, daniel
Cc: dri-devel, linux-kernel, Benjamin Gaignard, José Roberto de Souza
Include drm_crtc_helper_internal.h to provide drm_connector_get_single_encoder
prototype.
Fixes: a92462d6bf493 ("drm/connector: Share with non-atomic drivers the function to get the single encoder")
Cc: José Roberto de Souza <jose.souza@intel.com>
Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com>
---
drivers/gpu/drm/drm_crtc_helper.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/drm_crtc_helper.c b/drivers/gpu/drm/drm_crtc_helper.c
index 499b05aaccfc..93a4eec429e8 100644
--- a/drivers/gpu/drm/drm_crtc_helper.c
+++ b/drivers/gpu/drm/drm_crtc_helper.c
@@ -48,6 +48,8 @@
#include <drm/drm_print.h>
#include <drm/drm_vblank.h>
+#include "drm_crtc_helper_internal.h"
+
/**
* DOC: overview
*
--
2.15.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/crtc-helper: drm_connector_get_single_encoder prototype is missing
2019-11-19 12:58 [PATCH] drm/crtc-helper: drm_connector_get_single_encoder prototype is missing Benjamin Gaignard
@ 2019-11-19 18:53 ` Souza, Jose
2019-11-19 19:59 ` Benjamin GAIGNARD
0 siblings, 1 reply; 4+ messages in thread
From: Souza, Jose @ 2019-11-19 18:53 UTC (permalink / raw)
To: benjamin.gaignard, daniel, maarten.lankhorst, mripard, airlied, sean
Cc: dri-devel, linux-kernel
On Tue, 2019-11-19 at 13:58 +0100, Benjamin Gaignard wrote:
> Include drm_crtc_helper_internal.h to provide
> drm_connector_get_single_encoder
> prototype.
>
> Fixes: a92462d6bf493 ("drm/connector: Share with non-atomic drivers
> the function to get the single encoder")
drm_connector_get_single_encoder() is implemented before the use in
this file so it is not broken, no need of a fixes tag.
Reviewed-by: José Roberto de Souza <jose.souza@intel.com>
>
> Cc: José Roberto de Souza <jose.souza@intel.com>
>
> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com>
> ---
> drivers/gpu/drm/drm_crtc_helper.c | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/drm_crtc_helper.c
> b/drivers/gpu/drm/drm_crtc_helper.c
> index 499b05aaccfc..93a4eec429e8 100644
> --- a/drivers/gpu/drm/drm_crtc_helper.c
> +++ b/drivers/gpu/drm/drm_crtc_helper.c
> @@ -48,6 +48,8 @@
> #include <drm/drm_print.h>
> #include <drm/drm_vblank.h>
>
> +#include "drm_crtc_helper_internal.h"
> +
> /**
> * DOC: overview
> *
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/crtc-helper: drm_connector_get_single_encoder prototype is missing
2019-11-19 18:53 ` Souza, Jose
@ 2019-11-19 19:59 ` Benjamin GAIGNARD
2019-12-03 16:47 ` Benjamin Gaignard
0 siblings, 1 reply; 4+ messages in thread
From: Benjamin GAIGNARD @ 2019-11-19 19:59 UTC (permalink / raw)
To: Souza, Jose, daniel, maarten.lankhorst, mripard, airlied, sean
Cc: dri-devel, linux-kernel
On 11/19/19 7:53 PM, Souza, Jose wrote:
> On Tue, 2019-11-19 at 13:58 +0100, Benjamin Gaignard wrote:
>> Include drm_crtc_helper_internal.h to provide
>> drm_connector_get_single_encoder
>> prototype.
>>
>> Fixes: a92462d6bf493 ("drm/connector: Share with non-atomic drivers
>> the function to get the single encoder")
> drm_connector_get_single_encoder() is implemented before the use in
> this file so it is not broken, no need of a fixes tag.
>
> Reviewed-by: José Roberto de Souza <jose.souza@intel.com>
I will remove fixe tag before push it.
Thanks,
Benjamin
>
>> Cc: José Roberto de Souza <jose.souza@intel.com>
>>
>> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com>
>> ---
>> drivers/gpu/drm/drm_crtc_helper.c | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/gpu/drm/drm_crtc_helper.c
>> b/drivers/gpu/drm/drm_crtc_helper.c
>> index 499b05aaccfc..93a4eec429e8 100644
>> --- a/drivers/gpu/drm/drm_crtc_helper.c
>> +++ b/drivers/gpu/drm/drm_crtc_helper.c
>> @@ -48,6 +48,8 @@
>> #include <drm/drm_print.h>
>> #include <drm/drm_vblank.h>
>>
>> +#include "drm_crtc_helper_internal.h"
>> +
>> /**
>> * DOC: overview
>> *
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/crtc-helper: drm_connector_get_single_encoder prototype is missing
2019-11-19 19:59 ` Benjamin GAIGNARD
@ 2019-12-03 16:47 ` Benjamin Gaignard
0 siblings, 0 replies; 4+ messages in thread
From: Benjamin Gaignard @ 2019-12-03 16:47 UTC (permalink / raw)
To: Benjamin GAIGNARD
Cc: Souza, Jose, daniel, maarten.lankhorst, mripard, airlied, sean,
linux-kernel, dri-devel
Le mer. 20 nov. 2019 à 00:28, Benjamin GAIGNARD
<benjamin.gaignard@st.com> a écrit :
>
>
> On 11/19/19 7:53 PM, Souza, Jose wrote:
> > On Tue, 2019-11-19 at 13:58 +0100, Benjamin Gaignard wrote:
> >> Include drm_crtc_helper_internal.h to provide
> >> drm_connector_get_single_encoder
> >> prototype.
> >>
> >> Fixes: a92462d6bf493 ("drm/connector: Share with non-atomic drivers
> >> the function to get the single encoder")
> > drm_connector_get_single_encoder() is implemented before the use in
> > this file so it is not broken, no need of a fixes tag.
> >
> > Reviewed-by: José Roberto de Souza <jose.souza@intel.com>
>
> I will remove fixe tag before push it.
>
> Thanks,
>
> Benjamin
Applied on drm-misc-next with out Fixes tag.
Thanks for the review.
Benjamin
>
> >
> >> Cc: José Roberto de Souza <jose.souza@intel.com>
> >>
> >> Signed-off-by: Benjamin Gaignard <benjamin.gaignard@st.com>
> >> ---
> >> drivers/gpu/drm/drm_crtc_helper.c | 2 ++
> >> 1 file changed, 2 insertions(+)
> >>
> >> diff --git a/drivers/gpu/drm/drm_crtc_helper.c
> >> b/drivers/gpu/drm/drm_crtc_helper.c
> >> index 499b05aaccfc..93a4eec429e8 100644
> >> --- a/drivers/gpu/drm/drm_crtc_helper.c
> >> +++ b/drivers/gpu/drm/drm_crtc_helper.c
> >> @@ -48,6 +48,8 @@
> >> #include <drm/drm_print.h>
> >> #include <drm/drm_vblank.h>
> >>
> >> +#include "drm_crtc_helper_internal.h"
> >> +
> >> /**
> >> * DOC: overview
> >> *
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-12-03 16:47 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-11-19 12:58 [PATCH] drm/crtc-helper: drm_connector_get_single_encoder prototype is missing Benjamin Gaignard
2019-11-19 18:53 ` Souza, Jose
2019-11-19 19:59 ` Benjamin GAIGNARD
2019-12-03 16:47 ` Benjamin Gaignard
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).