From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A953C4332F for ; Sun, 27 Mar 2022 07:09:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235579AbiC0HLL (ORCPT ); Sun, 27 Mar 2022 03:11:11 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55918 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234024AbiC0HLE (ORCPT ); Sun, 27 Mar 2022 03:11:04 -0400 Received: from pegase2.c-s.fr (pegase2.c-s.fr [93.17.235.10]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9AEE11D0F3 for ; Sun, 27 Mar 2022 00:09:25 -0700 (PDT) Received: from localhost (mailhub3.si.c-s.fr [172.26.127.67]) by localhost (Postfix) with ESMTP id 4KR6QD0M1Gz9sSV; Sun, 27 Mar 2022 09:09:24 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from pegase2.c-s.fr ([172.26.127.65]) by localhost (pegase2.c-s.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id jAtWlDOuK_I6; Sun, 27 Mar 2022 09:09:23 +0200 (CEST) Received: from messagerie.si.c-s.fr (messagerie.si.c-s.fr [192.168.25.192]) by pegase2.c-s.fr (Postfix) with ESMTP id 4KR6QC6f3jz9sSS; Sun, 27 Mar 2022 09:09:23 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by messagerie.si.c-s.fr (Postfix) with ESMTP id D26048B768; Sun, 27 Mar 2022 09:09:23 +0200 (CEST) X-Virus-Scanned: amavisd-new at c-s.fr Received: from messagerie.si.c-s.fr ([127.0.0.1]) by localhost (messagerie.si.c-s.fr [127.0.0.1]) (amavisd-new, port 10023) with ESMTP id yI8LRLGcX_Nj; Sun, 27 Mar 2022 09:09:23 +0200 (CEST) Received: from [192.168.204.35] (unknown [192.168.204.35]) by messagerie.si.c-s.fr (Postfix) with ESMTP id 586548B763; Sun, 27 Mar 2022 09:09:23 +0200 (CEST) Message-ID: <6adcc6f5-cd72-e455-16a9-0d9a454127d2@csgroup.eu> Date: Sun, 27 Mar 2022 09:09:22 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.7.0 Subject: Re: [PATCH 2/5] powerpc/83xx: fix possible object reference leak Content-Language: fr-FR To: Wen Yang , linux-kernel@vger.kernel.org Cc: wang.yi59@zte.com.cn, Scott Wood , Paul Mackerras , linuxppc-dev@lists.ozlabs.org References: <1553223955-7350-1-git-send-email-wen.yang99@zte.com.cn> <1553223955-7350-2-git-send-email-wen.yang99@zte.com.cn> From: Christophe Leroy In-Reply-To: <1553223955-7350-2-git-send-email-wen.yang99@zte.com.cn> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 22/03/2019 à 04:05, Wen Yang a écrit : > The call to of_find_node_by_name returns a node pointer with refcount > incremented thus it must be explicitly decremented after the last > usage. > > Detected by coccinelle with the following warnings: > ./arch/powerpc/platforms/83xx/km83xx.c:68:2-8: ERROR: missing of_node_put; acquired a node pointer with refcount incremented on line 59, but without a corresponding object release within this function. This was fixed by https://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git/commit/?id=88654d5b4476 > > Signed-off-by: Wen Yang > Cc: Scott Wood > Cc: Kumar Gala > Cc: Benjamin Herrenschmidt > Cc: Paul Mackerras > Cc: Michael Ellerman > Cc: linuxppc-dev@lists.ozlabs.org > Cc: linux-kernel@vger.kernel.org > --- > arch/powerpc/platforms/83xx/km83xx.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/powerpc/platforms/83xx/km83xx.c b/arch/powerpc/platforms/83xx/km83xx.c > index d8642a4..11eea7c 100644 > --- a/arch/powerpc/platforms/83xx/km83xx.c > +++ b/arch/powerpc/platforms/83xx/km83xx.c > @@ -65,6 +65,7 @@ static void quirk_mpc8360e_qe_enet10(void) > ret = of_address_to_resource(np_par, 0, &res); > if (ret) { > pr_warn("%s couldn;t map par_io registers\n", __func__); > + of_node_put(np_par); > return; > } >