From: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
To: Chunfeng Yun <chunfeng.yun@mediatek.com>, Vinod Koul <vkoul@kernel.org>
Cc: Kishon Vijay Abraham I <kishon@ti.com>,
Matthias Brugger <matthias.bgg@gmail.com>,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org,
linux-phy@lists.infradead.org, linux-kernel@vger.kernel.org,
Eddie Hung <eddie.hung@mediatek.com>,
Tianping Fang <tianping.fang@mediatek.com>
Subject: Re: [PATCH 2/2] phy: mediatek: tphy: add debugfs files
Date: Wed, 28 Sep 2022 15:35:41 +0200 [thread overview]
Message-ID: <6ae64f49-5ab9-0b37-ae2c-5519c21a5d73@collabora.com> (raw)
In-Reply-To: <20220928093041.31481-2-chunfeng.yun@mediatek.com>
Il 28/09/22 11:30, Chunfeng Yun ha scritto:
> These debugfs files are mainly used to make eye diagram test easier,
> especially helpful to do HQA test for a new IC without efuse enabled.
>
> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
Even though this won't be interesting for the vast majority of the people
out there (the users!), it's still nice to have it for IC testing performed
directly on upstream, as that opens new possibilities for you and ODMs/OEMs,
so I agree on getting that code upstreamed.
For that reason, I think that the best approach for this one would be to
enclose it in a configuration option like CONFIG_PHY_MTK_TPHY_DEBUGFS or
CONFIG_PHY_MTK_TPHY_DEBUG, so that this very low level debugging code
doesn't end up in end-user builds, as that may, in some cases, be even
dangerous.
Regards,
Angelo
next prev parent reply other threads:[~2022-09-28 13:35 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-28 9:30 [PATCH 1/2] phy: core: add debugfs root Chunfeng Yun
2022-09-28 9:30 ` [PATCH 2/2] phy: mediatek: tphy: add debugfs files Chunfeng Yun
2022-09-28 13:35 ` AngeloGioacchino Del Regno [this message]
2022-09-29 6:12 ` Chunfeng Yun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6ae64f49-5ab9-0b37-ae2c-5519c21a5d73@collabora.com \
--to=angelogioacchino.delregno@collabora.com \
--cc=chunfeng.yun@mediatek.com \
--cc=eddie.hung@mediatek.com \
--cc=kishon@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-phy@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=tianping.fang@mediatek.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).