From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E322AC4332F for ; Wed, 20 Oct 2021 14:07:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id C3B24600D3 for ; Wed, 20 Oct 2021 14:07:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230321AbhJTOJi (ORCPT ); Wed, 20 Oct 2021 10:09:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46432 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230076AbhJTOJg (ORCPT ); Wed, 20 Oct 2021 10:09:36 -0400 Received: from mail-qk1-x730.google.com (mail-qk1-x730.google.com [IPv6:2607:f8b0:4864:20::730]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 84338C061753 for ; Wed, 20 Oct 2021 07:07:22 -0700 (PDT) Received: by mail-qk1-x730.google.com with SMTP id p4so3201522qki.3 for ; Wed, 20 Oct 2021 07:07:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=jgtlFeXdT3Hd6RC5M2SWvFMAen1H/83nOl5HVUgBtrI=; b=sc9i/fjetuLqOZM4ClryvZVwCtDOz6iEdlZj9diZQqB857ABVBaeLMBJBaf7uCp7il /xxNXijVWNSXUGG+x6hRHx/tAUvvWQXn2NJAWx4WYKAm5CRG+13RxBg343Wj9wbGGc+Y EZ5/E25rViC54giVVgDwTx9RILI1trr9/Ax+H+VLq+5siNhUc9JyYFeaqvzzrHghV/Uz Oq0L1Zc9hiKPqIPyqz44QEGFEGJo68Po1nm4I6bRYObW6QR8AjYw6WPBpzCdNQQCdV8I 6Q2NsfIFph8frUQX8P/QDFy/aIaqctgcsF2Zb1YMoTpHE5P0y9IvzZ3KSLHbZpwhfp/9 U2nQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=jgtlFeXdT3Hd6RC5M2SWvFMAen1H/83nOl5HVUgBtrI=; b=dHy1AUIU5zJsPVB+IEyBQGhWYqF7lgYro4TFIppRmXfC3iOh1SrEwn0u/rf61xOtFE RPsbuLqaX8+aKZgoIi2X/dVh+j0CCaplsG1Sje/LMivoB/kDxHsnps+aCUbIbd+vz+xc 5UUi2eocTkSM7lBMFq3PROUzsocm0wLmGusStPFZLlKzuVUckHyiGRpNu8xmCzrjAhXO DdolWBfzzi1+ZO7rziljMYA+lySkN9fVQ7bd2jXstX1huoaOFXBtwnt7Q2u4T9SxN8li 0JFAfoguaXCbd9LkkfgH5MWjBHfolbWIwNhC/c8IFsCRVM4kX4rDibP7CHwd7LOFQPTG z3wg== X-Gm-Message-State: AOAM531c8dR4gZ9lt5l698+cLOHyf3q771lWP8v80OP/Eij23bw3lAX1 6xliD7nFO5rebvimSiIq3tDVcg== X-Google-Smtp-Source: ABdhPJyD1JzrgLozhl3rrIg7tRZDzkqL8hV4xjFIPqgoQogHBmFHJBrQ0i0KIJH9YuYozvlacl1IYg== X-Received: by 2002:a37:aac8:: with SMTP id t191mr244715qke.52.1634738841624; Wed, 20 Oct 2021 07:07:21 -0700 (PDT) Received: from [192.168.1.93] (pool-71-163-245-5.washdc.fios.verizon.net. [71.163.245.5]) by smtp.gmail.com with ESMTPSA id bq41sm1053610qkb.26.2021.10.20.07.07.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 20 Oct 2021 07:07:21 -0700 (PDT) Subject: Re: [PATCH v4 15/20] crypto: qce: Add new compatibles for qce crypto driver To: Bhupesh Sharma , linux-arm-msm@vger.kernel.org, linux-crypto@vger.kernel.org Cc: bhupesh.linux@gmail.com, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, robh+dt@kernel.org, agross@kernel.org, herbert@gondor.apana.org.au, davem@davemloft.net, Bjorn Andersson References: <20211013105541.68045-1-bhupesh.sharma@linaro.org> <20211013105541.68045-16-bhupesh.sharma@linaro.org> From: Thara Gopinath Message-ID: <6aecc0aa-6219-d440-0075-39935aec0c7e@linaro.org> Date: Wed, 20 Oct 2021 10:07:20 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20211013105541.68045-16-bhupesh.sharma@linaro.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10/13/21 6:55 AM, Bhupesh Sharma wrote: > Since we decided to use soc specific compatibles for describing > the qce crypto IP nodes in the device-trees, adapt the driver > now to handle the same. > > Cc: Thara Gopinath > Cc: Bjorn Andersson > Cc: Rob Herring > Signed-off-by: Bhupesh Sharma > --- > drivers/crypto/qce/core.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/crypto/qce/core.c b/drivers/crypto/qce/core.c > index 033c7278aa5d..2ab0b97d718c 100644 > --- a/drivers/crypto/qce/core.c > +++ b/drivers/crypto/qce/core.c > @@ -298,8 +298,8 @@ static int qce_crypto_remove(struct platform_device *pdev) > } > > static const struct of_device_id qce_crypto_of_match[] = { > - { .compatible = "qcom,crypto-v5.1", }, Hi Bhupesh, I think we should keep the qcom,crypto-v5.1 here for backward compatibility. Since v5.4 was added only recently it might be okay to remove it. -- Warm Regards Thara (She/Her/Hers) > - { .compatible = "qcom,crypto-v5.4", }, > + { .compatible = "qcom,ipq6018-qce", }, > + { .compatible = "qcom,sdm845-qce", }, > {} > }; > MODULE_DEVICE_TABLE(of, qce_crypto_of_match); >