From: Daniel Thompson <daniel.thompson@linaro.org>
To: Brian Masney <masneyb@onstation.org>,
lee.jones@linaro.org, jingoohan1@gmail.com, robh+dt@kernel.org
Cc: jacek.anaszewski@gmail.com, pavel@ucw.cz, mark.rutland@arm.com,
b.zolnierkie@samsung.com, dri-devel@lists.freedesktop.org,
linux-leds@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-fbdev@vger.kernel.org,
dmurphy@ti.com, jonathan@marek.ca, Rob Herring <robh@kernel.org>,
Daniel Thompson <daniel@redfelineninja.org.uk>
Subject: Re: [PATCH v6 2/3] dt-bindings: backlight: add lm3630a bindings
Date: Thu, 2 May 2019 11:09:35 +0100 [thread overview]
Message-ID: <6af80a58-b3e2-bf67-cbfc-284df7ec52c1@linaro.org> (raw)
In-Reply-To: <20190424092505.6578-3-masneyb@onstation.org>
On 24/04/2019 10:25, Brian Masney wrote:
> Add new backlight bindings for the TI LM3630A dual-string white LED.
>
> Signed-off-by: Brian Masney <masneyb@onstation.org>
> Reviewed-by: Rob Herring <robh@kernel.org>
> Acked-by: Pavel Machek <pavel@ucw.cz>
Acked-by: Daniel Thompson <daniel.thompson@linaro.org>
> ---
> Changes since v5:
> - Change 'lm3630a_bl@38' in examples to 'led-controller@38'
>
> Changes since v4:
> - Drop $ref from led-sources
> - Drop description from reg of i2c address
> - Expand description of reg for the control bank
> - Drop status from examples
>
> Changes since v3:
> - Add label. I didn't add a description for it since that'll come from
> the common properties once its converted.
>
> Changes since v2:
> - Update description of max-brightness
> - Add description for reg
> - Correct typo: s/tranisiton/transition
> - add reg to control banks
> - add additionalProperties
>
> .../leds/backlight/lm3630a-backlight.yaml | 129 ++++++++++++++++++
> 1 file changed, 129 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml
>
> diff --git a/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml b/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml
> new file mode 100644
> index 000000000000..4d61fe0a98a4
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/leds/backlight/lm3630a-backlight.yaml
> @@ -0,0 +1,129 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/leds/backlight/lm3630a-backlight.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: TI LM3630A High-Efficiency Dual-String White LED
> +
> +maintainers:
> + - Lee Jones <lee.jones@linaro.org>
> + - Daniel Thompson <daniel.thompson@linaro.org>
> + - Jingoo Han <jingoohan1@gmail.com>
> +
> +description: |
> + The LM3630A is a current-mode boost converter which supplies the power and
> + controls the current in up to two strings of 10 LEDs per string.
> + https://www.ti.com/product/LM3630A
> +
> +properties:
> + compatible:
> + const: ti,lm3630a
> +
> + reg:
> + maxItems: 1
> +
> + ti,linear-mapping-mode:
> + description: |
> + Enable linear mapping mode. If disabled, then it will use exponential
> + mapping mode in which the ramp up/down appears to have a more uniform
> + transition to the human eye.
> + type: boolean
> +
> +required:
> + - compatible
> + - reg
> +
> +patternProperties:
> + "^led@[01]$":
> + type: object
> + description: |
> + Properties for a string of connected LEDs.
> +
> + properties:
> + reg:
> + description: |
> + The control bank that is used to program the two current sinks. The
> + LM3630A has two control banks (A and B) and are represented as 0 or 1
> + in this property. The two current sinks can be controlled
> + independently with both banks, or bank A can be configured to control
> + both sinks with the led-sources property.
> + maxItems: 1
> + minimum: 0
> + maximum: 1
> +
> + label:
> + maxItems: 1
> +
> + led-sources:
> + allOf:
> + - minItems: 1
> + maxItems: 2
> + items:
> + minimum: 0
> + maximum: 1
> +
> + default-brightness:
> + description: Default brightness level on boot.
> + minimum: 0
> + maximum: 255
> +
> + max-brightness:
> + description: Maximum brightness that is allowed during runtime.
> + minimum: 0
> + maximum: 255
> +
> + required:
> + - reg
> +
> + additionalProperties: false
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + led-controller@38 {
> + compatible = "ti,lm3630a";
> + reg = <0x38>;
> +
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + led@0 {
> + reg = <0>;
> + led-sources = <0 1>;
> + label = "lcd-backlight";
> + default-brightness = <200>;
> + max-brightness = <255>;
> + };
> + };
> + };
> + - |
> + i2c {
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + led-controller@38 {
> + compatible = "ti,lm3630a";
> + reg = <0x38>;
> +
> + #address-cells = <1>;
> + #size-cells = <0>;
> +
> + led@0 {
> + reg = <0>;
> + default-brightness = <150>;
> + ti,linear-mapping-mode;
> + };
> +
> + led@1 {
> + reg = <1>;
> + default-brightness = <225>;
> + ti,linear-mapping-mode;
> + };
> + };
> + };
>
next prev parent reply other threads:[~2019-05-02 10:09 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-24 9:25 [PATCH v6 0/3] backlight: lm3630a: bug fix and fwnode support Brian Masney
2019-04-24 9:25 ` [PATCH v6 1/3] backlight: lm3630a: return 0 on success in update_status functions Brian Masney
2019-05-02 10:07 ` Daniel Thompson
2019-05-02 10:42 ` Brian Masney
2019-05-02 10:46 ` Daniel Thompson
2019-05-07 9:53 ` Lee Jones
2019-04-24 9:25 ` [PATCH v6 2/3] dt-bindings: backlight: add lm3630a bindings Brian Masney
2019-04-24 14:20 ` Pavel Machek
2019-04-24 15:57 ` Rob Herring
2019-04-24 18:55 ` Pavel Machek
2019-05-02 10:09 ` Daniel Thompson [this message]
2019-05-17 21:11 ` Rob Herring
2019-05-17 23:12 ` Brian Masney
2019-04-24 9:25 ` [PATCH v6 3/3] backlight: lm3630a: add firmware node support Brian Masney
2019-04-24 14:24 ` Pavel Machek
2019-05-02 10:19 ` Daniel Thompson
2019-05-02 10:46 ` Brian Masney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6af80a58-b3e2-bf67-cbfc-284df7ec52c1@linaro.org \
--to=daniel.thompson@linaro.org \
--cc=b.zolnierkie@samsung.com \
--cc=daniel@redfelineninja.org.uk \
--cc=devicetree@vger.kernel.org \
--cc=dmurphy@ti.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jacek.anaszewski@gmail.com \
--cc=jingoohan1@gmail.com \
--cc=jonathan@marek.ca \
--cc=lee.jones@linaro.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=masneyb@onstation.org \
--cc=pavel@ucw.cz \
--cc=robh+dt@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).