From: Alex Elder <elder@linaro.org>
To: Florian Fainelli <f.fainelli@gmail.com>,
Alex Elder <elder@ieee.org>,
davem@davemloft.net, kuba@kernel.org
Cc: bjorn.andersson@linaro.org, evgreen@chromium.org,
cpratapa@codeaurora.org, subashab@codeaurora.org,
elder@kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next 2/4] net: ipa: introduce dma_addr_high32()
Date: Thu, 18 Mar 2021 08:33:35 -0500 [thread overview]
Message-ID: <6afe045d-7157-2b7f-1dcc-0eddcf77d8a1@linaro.org> (raw)
In-Reply-To: <f0215cf7-3a62-421c-28bf-17aa4e197b9b@gmail.com>
On 3/17/21 6:00 PM, Florian Fainelli wrote:
>
>
> On 3/17/2021 3:49 PM, Alex Elder wrote:
>> On 3/17/21 5:47 PM, Florian Fainelli wrote:
>>>> +/* Encapsulate extracting high-order 32 bits of DMA address */
>>>> +static u32 dma_addr_high32(dma_addr_t addr)
>>>> +{
>>>> +#ifdef CONFIG_ARCH_DMA_ADDR_T_64BIT
>>>> + return (u32)(addr >> 32);
>>> You can probably use upper_32bits() here...
>>
>> Where is that defined? I'd be glad to use it. -Alex
>
> include/linux/kernel.h, and it is upper_32_bits() and lower_32_bits()
> sorry about the missing space.
That's nice. I'll still use a separate commit (and will
credit you with the suggestion) but it will be much smaller.
Thanks. I'll post v2 shortly.
-Alex
next prev parent reply other threads:[~2021-03-18 13:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-17 22:29 [PATCH net-next 0/4] net: ipa: support 32-bit targets Alex Elder
2021-03-17 22:29 ` [PATCH net-next 1/4] net: ipa: fix assumptions about DMA address size Alex Elder
2021-03-17 22:29 ` [PATCH net-next 2/4] net: ipa: introduce dma_addr_high32() Alex Elder
2021-03-17 22:47 ` Florian Fainelli
2021-03-17 22:49 ` Alex Elder
2021-03-17 23:00 ` Florian Fainelli
2021-03-18 13:33 ` Alex Elder [this message]
2021-03-17 22:29 ` [PATCH net-next 3/4] net: ipa: fix table alignment requirement Alex Elder
2021-03-17 22:29 ` [PATCH net-next 4/4] net: ipa: relax 64-bit build requirement Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6afe045d-7157-2b7f-1dcc-0eddcf77d8a1@linaro.org \
--to=elder@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=cpratapa@codeaurora.org \
--cc=davem@davemloft.net \
--cc=elder@ieee.org \
--cc=elder@kernel.org \
--cc=evgreen@chromium.org \
--cc=f.fainelli@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=subashab@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).