From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8774BC43381 for ; Mon, 4 Mar 2019 18:38:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5583C2070B for ; Mon, 4 Mar 2019 18:38:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="XJyW+KIb" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727462AbfCDSi2 (ORCPT ); Mon, 4 Mar 2019 13:38:28 -0500 Received: from mail-pg1-f196.google.com ([209.85.215.196]:43728 "EHLO mail-pg1-f196.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726073AbfCDSi1 (ORCPT ); Mon, 4 Mar 2019 13:38:27 -0500 Received: by mail-pg1-f196.google.com with SMTP id l11so3678057pgq.10 for ; Mon, 04 Mar 2019 10:38:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=xj8BgPrnfVZvKnhnS1GuA2yiFsYMoZDIJcW3TElT7k4=; b=XJyW+KIbJhwK1oK4eVmC0jvAtQncdJXBvmC705eNjpwQLB0i5jx3IAuo3WQUTt4KtU ct8kCwXGwA35cYzVuGX1vUbxFXYEGv5wX8vhWoOBvW1oGf3QhGk394coOWl1PNTPV8uE Hx/G26JAEWBZJp4spmNLo0MxtpjImPFBZXUylZsILI5NbH7JFlvtncNYkgiA4OeVdrVK Zizl0glNpgqTEcV8UKRJ2B3nF4KwazEgf7n3O+C26quZHupRPfNzVmP6qLlanzLp7W5y n6nrRxTtgjNUogaxyC1cDR7JvtRFJpqKZfmrbVxhSAxBjArCCb7nfbpxQG4R2+Zpr9A7 3FGQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=xj8BgPrnfVZvKnhnS1GuA2yiFsYMoZDIJcW3TElT7k4=; b=Y41SO7dl/OXjbxRWtvURUFl5QpA9bOmBzl3Q9RwYFdYvQTn0GD69e+3qmgjCtnJdoU WbnrFaz0REaEksM3nmA757I8PzdSmXk9OkwprprUE8QKD/s4oziFC61gmXA8sYparY1I drPo2uONBbZ8ZE81IaGF3Pm3E+2HTTBCwfY2zQ4hguZWdzYYe17j7q+poRD/z6hofzMo 9v/ZdRNzAR6VhK7bTQLR6AFzQUdu5rtd8M4Kjtyu759qFGuGE38qy43ZtBKUxNwdYN1Y COA+0EpF6RN20fVm/aFRa2y0NnRgqnEMD84gyoTiXXoDvV8FkMqD6RGs8vLcF2L3ox1b bJ9w== X-Gm-Message-State: APjAAAVHCKIKkn0ejHqsINZtqLR10Dfw49XfQ+v7VUOSVfOrUOf2OTsu rl47r46Xicg4GwJGhnVTUow= X-Google-Smtp-Source: APXvYqzv7t8p8shqXHtlwNykxQB+pHIdlm2pEmQQXk6b/icIDsfm6Qk35gabGFkhu8i1zJQfW7CVRA== X-Received: by 2002:a63:d810:: with SMTP id b16mr19437381pgh.220.1551724706340; Mon, 04 Mar 2019 10:38:26 -0800 (PST) Received: from [10.69.37.149] ([192.19.223.250]) by smtp.gmail.com with ESMTPSA id h184sm22550438pfc.78.2019.03.04.10.38.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 04 Mar 2019 10:38:25 -0800 (PST) Subject: Re: [LKP] [workqueue] 4d43d395fe: WARNING:at_kernel/workqueue.c:#__flush_work To: Sagi Grimberg , Tetsuo Handa , Jens Axboe , Keith Busch , Johannes Thumshirn , Chaitanya Kulkarni Cc: kernel test robot , Tejun Heo , LKML , Stephen Rothwell , lkp@01.org References: <20190304134116.GF25100@shao2-debian> From: James Smart Message-ID: <6b0a949b-4696-bb38-6c86-a8f5ff2e1513@gmail.com> Date: Mon, 4 Mar 2019 10:38:26 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/4/2019 10:21 AM, Sagi Grimberg wrote: > >> Forwarding to NMVE people: >> >> kernel test robot found that >> flush_work(&ctrl->async_event_work) is called from nvmet_ctrl_free() >> without INIT_WORK(&ctrl->async_event_work, nvmet_async_event_work) >> after ctrl was allocated (probably initialized with 0). >> Will you make sure that INIT_WORK() is always called? > > I cannot reproduce this issue. When following the code I don't > immediately see how this can happen.. Was there something special > in this specific test run? Is it 100% reproduce-able? I agree. INIT_WORK is setup as almost one of the first items for a new controller. Smells more like a double-free or a corrupt ctrl struct from the transport. -- james