From: Joe Perches <joe@perches.com>
To: Colin King <colin.king@canonical.com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>,
dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] video: fbdev: vesafb: fix indentation issue
Date: Fri, 15 Feb 2019 02:00:27 -0800 [thread overview]
Message-ID: <6b0d55253ce61f1b7a068689ae9db597aaf5d30a.camel@perches.com> (raw)
In-Reply-To: <20190212132905.7307-1-colin.king@canonical.com>
On Tue, 2019-02-12 at 13:29 +0000, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> There are a couple of statements that are indented too deeply, fix
> this by removing tabs. Also add a space after a comma to clean up
> a cppcheck warning.
>
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/video/fbdev/vesafb.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/video/fbdev/vesafb.c b/drivers/video/fbdev/vesafb.c
> index 528fe917dd49..b7388e25aa2a 100644
> --- a/drivers/video/fbdev/vesafb.c
> +++ b/drivers/video/fbdev/vesafb.c
> @@ -336,8 +336,8 @@ static int vesafb_probe(struct platform_device *dev)
> printk(KERN_INFO "vesafb: pmi: set display start = %p, set palette = %p\n",pmi_start,pmi_pal);
> if (pmi_base[3]) {
> printk(KERN_INFO "vesafb: pmi: ports = ");
> - for (i = pmi_base[3]/2; pmi_base[i] != 0xffff; i++)
> - printk("%x ",pmi_base[i]);
> + for (i = pmi_base[3]/2; pmi_base[i] != 0xffff; i++)
> + printk("%x ", pmi_base[i]);
> printk("\n");
> if (pmi_base[i] != 0xffff) {
> /*
Perhaps you could also use pr_cont too because otherwise this
emits each printk on separate lines.
next prev parent reply other threads:[~2019-02-15 10:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20190212132918epcas1p4211cd6eb2d090c8ccd2996ee0d13ca78@epcas1p4.samsung.com>
2019-02-12 13:29 ` [PATCH] video: fbdev: vesafb: fix indentation issue Colin King
2019-02-15 10:00 ` Joe Perches [this message]
2019-04-01 11:48 ` Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6b0d55253ce61f1b7a068689ae9db597aaf5d30a.camel@perches.com \
--to=joe@perches.com \
--cc=b.zolnierkie@samsung.com \
--cc=colin.king@canonical.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).