From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A97D0C433E9 for ; Wed, 17 Mar 2021 22:19:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 68BF764DE7 for ; Wed, 17 Mar 2021 22:19:52 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230221AbhCQWTU (ORCPT ); Wed, 17 Mar 2021 18:19:20 -0400 Received: from www62.your-server.de ([213.133.104.62]:54944 "EHLO www62.your-server.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230041AbhCQWSv (ORCPT ); Wed, 17 Mar 2021 18:18:51 -0400 Received: from sslproxy06.your-server.de ([78.46.172.3]) by www62.your-server.de with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92.3) (envelope-from ) id 1lMeV7-0004K4-8v; Wed, 17 Mar 2021 23:18:49 +0100 Received: from [85.7.101.30] (helo=pc-9.home) by sslproxy06.your-server.de with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lMeV7-000Rtu-2k; Wed, 17 Mar 2021 23:18:49 +0100 Subject: Re: [PATCH] MIPS/bpf: Enable bpf_probe_read{, str}() on MIPS again To: Tiezhu Yang , Thomas Bogendoerfer Cc: linux-mips@vger.kernel.org, bpf@vger.kernel.org, linux-kernel@vger.kernel.org, Xuefeng Li References: <1615965307-6926-1-git-send-email-yangtiezhu@loongson.cn> From: Daniel Borkmann Message-ID: <6b239565-8fbb-d183-6a4d-13fc90af3e27@iogearbox.net> Date: Wed, 17 Mar 2021 23:18:48 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: <1615965307-6926-1-git-send-email-yangtiezhu@loongson.cn> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Authenticated-Sender: daniel@iogearbox.net X-Virus-Scanned: Clear (ClamAV 0.102.4/26111/Wed Mar 17 12:08:39 2021) Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/17/21 8:15 AM, Tiezhu Yang wrote: > After commit 0ebeea8ca8a4 ("bpf: Restrict bpf_probe_read{, str}() only to > archs where they work"), bpf_probe_read{, str}() functions were not longer > available on MIPS, so there exists some errors when running bpf program: > > root@linux:/home/loongson/bcc# python examples/tracing/task_switch.py > bpf: Failed to load program: Invalid argument > [...] > 11: (85) call bpf_probe_read#4 > unknown func bpf_probe_read#4 > [...] > Exception: Failed to load BPF program count_sched: Invalid argument > > So select ARCH_HAS_NON_OVERLAPPING_ADDRESS_SPACE in arch/mips/Kconfig, > otherwise the bpf old helper bpf_probe_read() will not be available. > > This is similar with the commit d195b1d1d1196 ("powerpc/bpf: Enable > bpf_probe_read{, str}() on powerpc again"). > > Fixes: 0ebeea8ca8a4 ("bpf: Restrict bpf_probe_read{, str}() only to archs where they work") > Signed-off-by: Tiezhu Yang Thomas, I presume you pick this up via mips tree (with typos fixed)? Or do you want us to route the fix via bpf with your ACK? (I'm fine either way.) Thanks, Daniel