From: Bastien Nocera <hadess@hadess.net>
To: "Filipe Laíns" <lains@archlinux.org>,
"Jiri Kosina" <jikos@kernel.org>,
"Benjamin Tissoires" <benjamin.tissoires@redhat.com>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] HID: logitech-hidpp: add support for Unified Battery (1004) feature
Date: Wed, 06 Jan 2021 20:17:26 +0100 [thread overview]
Message-ID: <6b33f956dfffc8edcff72f66a29ccf5d86682a53.camel@hadess.net> (raw)
In-Reply-To: <bc65667903652a67f17b6b51a37a03f73309fe39.camel@archlinux.org>
On Wed, 2021-01-06 at 18:48 +0000, Filipe Laíns wrote:
> On Wed, 2021-01-06 at 10:34 +0100, Bastien Nocera wrote:
> > On Mon, 2021-01-04 at 18:29 +0000, lains@archlinux.org wrote:
> > > From: Filipe Laíns <lains@archlinux.org>
> > >
> > > This new feature present in new devices replaces the old Battery
> > > Level
> > > Status (0x1000) feature. It keeps essentially the same
> > > information
> > > for
> > > levels (reporting critical, low, good and full) but makes these
> > > levels
> > > optional, the device exports a capability setting which describes
> > > which
> > > levels it supports. In addition to this, there is an optional
> > > state_of_charge paramenter that exports the battery percentage.
> > >
> > > This patch adds support for this new feature. There were some
> > > implementation choices, as described below and in the code.
> > >
> > > If the device supports the state_of_charge parameter, we will
> > > just
> > > export the battery percentage and not the levels, which the
> > > device
> > > might
> > > still support.
> >
> > I'm guessing that means no changes needed on the upower side?
> >
> > Cheers
> >
>
> Yes :)
> I tested upower and all works as expected.
>
> There will still be devices that only support battery voltage, so I
> might
> implement the battery voltage to charge percentage in a future patch.
I sent a WIP patch at the end of November for that, it wasn't even
compile-tested, but might be a good base to start from.
I don't think that I have any hardware that supports that feature in
any case.
Cheers
next prev parent reply other threads:[~2021-01-06 19:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-04 18:29 [PATCH] HID: logitech-hidpp: add support for Unified Battery (1004) feature lains
2021-01-06 9:34 ` Bastien Nocera
2021-01-06 18:48 ` Filipe Laíns
2021-01-06 19:17 ` Bastien Nocera [this message]
2021-01-08 13:44 ` Jiri Kosina
2021-01-08 14:53 ` Filipe Laíns
2021-01-08 14:55 ` Jiri Kosina
2021-01-08 15:01 ` Filipe Laíns
2021-01-18 10:02 ` Jiri Kosina
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6b33f956dfffc8edcff72f66a29ccf5d86682a53.camel@hadess.net \
--to=hadess@hadess.net \
--cc=benjamin.tissoires@redhat.com \
--cc=jikos@kernel.org \
--cc=lains@archlinux.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).