From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Arnd Bergmann <arnd@arndb.de>, Liam Girdwood <lgirdwood@gmail.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
Mark Brown <broonie@kernel.org>,
Daniel Baluta <daniel.baluta@nxp.com>,
Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
Kai Vehmanen <kai.vehmanen@linux.intel.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
NXP Linux Team <linux-imx@nxp.com>,
YueHaibing <yuehaibing@huawei.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
sound-open-firmware@alsa-project.org,
alsa-devel@alsa-project.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: SOF: sort out Kconfig, again
Date: Tue, 28 Apr 2020 16:43:04 -0500 [thread overview]
Message-ID: <6b39fbba-c65d-2c02-14bf-11c2d00547af@linux.intel.com> (raw)
In-Reply-To: <20200428212752.2901778-1-arnd@arndb.de>
On 4/28/20 4:27 PM, Arnd Bergmann wrote:
> The imx8 config keeps causing issues:
>
> WARNING: unmet direct dependencies detected for SND_SOC_SOF_IMX8M
> Depends on [n]: SOUND [=y] && !UML && SND [=y] && SND_SOC [=m] && SND_SOC_SOF_TOPLEVEL [=y] && SND_SOC_SOF_IMX_TOPLEVEL [=y] && IMX_DSP [=n]
> Selected by [m]:
> - SND_SOC_SOF_IMX_OF [=m] && SOUND [=y] && !UML && SND [=y] && SND_SOC [=m] && SND_SOC_SOF_TOPLEVEL [=y] && SND_SOC_SOF_IMX_TOPLEVEL [=y] && SND_SOC_SOF_IMX8M_SUPPORT [=y]
>
> This is complicated by two drivers having dependencies on both
> platform specific drivers and the SND_SOC_SOF_OF framework code,
> and using an somewhat obscure method to build them the same way
> as the SOC_SOF_OF symbol (built-in or modular).
>
> My solution now ensures that the two drivers can only be enabled
> when the dependencies are met:
>
> - When the platform specific drivers are built-in, everything is
> fine, as SOC_SOF_OF is either =y or =m
>
> - When both are loadable modules, it also works, both for Kconfig
> and at runtime
>
> - When the hardware drivers are loadable modules or disabled, and
> SOC_SOF_OF=y, prevent the IMX_SOF_OF drivers from being turned on,
> as this would be broken.
>
> It seems that this is just an elaborate way to describe two tristate
> symbols that have straight dependencies, but maybe I'm missing some
> subtle point. It seems to always build for me now.
Thanks Arnd, do you mind sharing your config? We noticed last week that
there's a depend/select confusion might be simpler to fix, see
https://github.com/thesofproject/linux/pull/2047/commits
If I look at the first line I see a IMX_DSP=n which looks exactly like
what we wanted to fix.
>
> Fixes: fe57a92c8858 ("ASoC: SOF: Add missing dependency on IMX_SCU")
> Fixes: afb93d716533 ("ASoC: SOF: imx: Add i.MX8M HW support")
> Fixes: cb0312f61c3e ("ASoC: SOF: imx: fix undefined reference issue")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> sound/soc/sof/imx/Kconfig | 7 +++----
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/sound/soc/sof/imx/Kconfig b/sound/soc/sof/imx/Kconfig
> index f76660e91382..66684d7590f4 100644
> --- a/sound/soc/sof/imx/Kconfig
> +++ b/sound/soc/sof/imx/Kconfig
> @@ -21,7 +21,8 @@ config SND_SOC_SOF_IMX_OF
>
> config SND_SOC_SOF_IMX8_SUPPORT
> bool "SOF support for i.MX8"
> - depends on IMX_SCU
> + depends on IMX_SCU=y || IMX_SCU=SND_SOC_SOF_IMX_OF
> + depends on IMX_DSP=y || IMX_DSP=SND_SOC_SOF_IMX_OF
> help
> This adds support for Sound Open Firmware for NXP i.MX8 platforms
> Say Y if you have such a device.
> @@ -29,14 +30,13 @@ config SND_SOC_SOF_IMX8_SUPPORT
>
> config SND_SOC_SOF_IMX8
> tristate
> - depends on IMX_SCU
> - select IMX_DSP
> help
> This option is not user-selectable but automagically handled by
> 'select' statements at a higher level
>
> config SND_SOC_SOF_IMX8M_SUPPORT
> bool "SOF support for i.MX8M"
> + depends on IMX_DSP=y || IMX_DSP=SND_SOC_SOF_OF
> help
> This adds support for Sound Open Firmware for NXP i.MX8M platforms
> Say Y if you have such a device.
> @@ -44,7 +44,6 @@ config SND_SOC_SOF_IMX8M_SUPPORT
>
> config SND_SOC_SOF_IMX8M
> tristate
> - depends on IMX_DSP
> help
> This option is not user-selectable but automagically handled by
> 'select' statements at a higher level
>
next prev parent reply other threads:[~2020-04-28 21:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-28 21:27 [PATCH] ASoC: SOF: sort out Kconfig, again Arnd Bergmann
2020-04-28 21:43 ` Pierre-Louis Bossart [this message]
2020-04-28 22:01 ` Arnd Bergmann
2020-04-28 22:15 ` Pierre-Louis Bossart
2020-04-28 23:00 ` Pierre-Louis Bossart
2020-04-29 8:21 ` Daniel Baluta
2020-04-29 8:24 ` Arnd Bergmann
2020-04-29 12:58 ` Mark Brown
2020-04-30 13:40 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6b39fbba-c65d-2c02-14bf-11c2d00547af@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=daniel.baluta@nxp.com \
--cc=festevam@gmail.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=kernel@pengutronix.de \
--cc=krzk@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=ranjani.sridharan@linux.intel.com \
--cc=s.hauer@pengutronix.de \
--cc=sfr@canb.auug.org.au \
--cc=shawnguo@kernel.org \
--cc=sound-open-firmware@alsa-project.org \
--cc=tiwai@suse.com \
--cc=yuehaibing@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).