From: Dan Murphy <dmurphy@ti.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: <andrew@lunn.ch>, <f.fainelli@gmail.com>, <hkallweit1@gmail.com>,
<bunk@kernel.org>, <netdev@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<grygorii.strashko@ti.com>
Subject: Re: [PATCH net-master 1/1] net: phy: dp83867: Add speed optimization feature
Date: Fri, 31 Jan 2020 11:14:05 -0600 [thread overview]
Message-ID: <6b4bb017-de97-0688-47c5-723ec4c3a339@ti.com> (raw)
In-Reply-To: <20200131091004.18d54183@cakuba.hsd1.ca.comcast.net>
Jakub
On 1/31/20 11:10 AM, Jakub Kicinski wrote:
> On Fri, 31 Jan 2020 09:11:10 -0600, Dan Murphy wrote:
>> Set the speed optimization bit on the DP83867 PHY.
>> This feature can also be strapped on the 64 pin PHY devices
>> but the 48 pin devices do not have the strap pin available to enable
>> this feature in the hardware. PHY team suggests to have this bit set.
>>
>> With this bit set the PHY will auto negotiate and report the link
>> parameters in the PHYSTS register and not in the BMCR. So we need to
>> over ride the genphy_read_status with a DP83867 specific read status.
>>
>> Signed-off-by: Dan Murphy <dmurphy@ti.com>
> While we wait for the PHY folk to take a look, could you please
> provide a Fixes tag?
Hmm. This is not a bug fix though this is a new feature being added.
Not sure what it would be fixing.
Dan
next prev parent reply other threads:[~2020-01-31 17:17 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-31 15:11 [PATCH net-master 0/1] DP83867 Speed " Dan Murphy
2020-01-31 15:11 ` [PATCH net-master 1/1] net: phy: dp83867: Add speed " Dan Murphy
2020-01-31 17:10 ` Jakub Kicinski
2020-01-31 17:14 ` Dan Murphy [this message]
2020-01-31 18:11 ` Jakub Kicinski
2020-01-31 18:36 ` Dan Murphy
2020-01-31 17:49 ` Florian Fainelli
2020-01-31 18:29 ` Dan Murphy
2020-01-31 18:42 ` Florian Fainelli
2020-01-31 19:14 ` Dan Murphy
2020-01-31 19:29 ` Florian Fainelli
2020-01-31 19:54 ` Dan Murphy
2020-01-31 20:02 ` Florian Fainelli
2020-01-31 20:10 ` Dan Murphy
2020-01-31 20:56 ` Heiner Kallweit
2020-02-01 1:30 ` Dan Murphy
2020-02-01 4:57 ` Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6b4bb017-de97-0688-47c5-723ec4c3a339@ti.com \
--to=dmurphy@ti.com \
--cc=andrew@lunn.ch \
--cc=bunk@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=grygorii.strashko@ti.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--subject='Re: [PATCH net-master 1/1] net: phy: dp83867: Add speed optimization feature' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).