From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D944DC48BDF for ; Sat, 19 Jun 2021 00:13:45 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id A23BE61284 for ; Sat, 19 Jun 2021 00:13:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232841AbhFSAPy (ORCPT ); Fri, 18 Jun 2021 20:15:54 -0400 Received: from mga01.intel.com ([192.55.52.88]:48584 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229730AbhFSAPw (ORCPT ); Fri, 18 Jun 2021 20:15:52 -0400 IronPort-SDR: tL28V7wWVIRtVZ5yBE6eh2af8718vDWr3V1/fxIoPEl2Jm8eeeBK9OBHqj+j/D/Wni/h0IB2sS MbLkKnLrBuJw== X-IronPort-AV: E=McAfee;i="6200,9189,10019"; a="228173432" X-IronPort-AV: E=Sophos;i="5.83,284,1616482800"; d="scan'208";a="228173432" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga101.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jun 2021 17:13:42 -0700 IronPort-SDR: FRm3gdpP3kLwArLQu2OTBW5eEj++BC0TuRb4tB13omjeiSASd1x9bQ4NExU74uImEcBtQLeGNZ AEaFokRRfs4A== X-IronPort-AV: E=Sophos;i="5.83,284,1616482800"; d="scan'208";a="451569001" Received: from msayeed-mobl.amr.corp.intel.com (HELO skuppusw-mobl5.amr.corp.intel.com) ([10.213.172.5]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 18 Jun 2021 17:13:41 -0700 Subject: Re: [PATCH v3 03/11] x86/cpufeatures: Add TDX Guest CPU feature To: Borislav Petkov Cc: Thomas Gleixner , Ingo Molnar , Peter Zijlstra , Andy Lutomirski , Peter H Anvin , Dave Hansen , Tony Luck , Dan Williams , Andi Kleen , Kirill Shutemov , Sean Christopherson , Kuppuswamy Sathyanarayanan , x86@kernel.org, linux-kernel@vger.kernel.org References: <20210618225755.662725-1-sathyanarayanan.kuppuswamy@linux.intel.com> <20210618225755.662725-4-sathyanarayanan.kuppuswamy@linux.intel.com> From: "Kuppuswamy, Sathyanarayanan" Message-ID: <6b68dc50-4d4c-f724-8ab8-0a12a07d42aa@linux.intel.com> Date: Fri, 18 Jun 2021 17:13:39 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 6/18/21 4:39 PM, Borislav Petkov wrote: > From Documentation/process/submitting-patches.rst: > > "Both Tested-by and Reviewed-by tags, once received on mailing list from tester > or reviewer, should be added by author to the applicable patches when sending > next versions. However if the patch has changed substantially in following > version, these tags might not be applicable anymore and thus should be removed. > Usually removal of someone's Tested-by or Reviewed-by tags should be mentioned > in the patch changelog (after the '---' separator)." > > IOW, for the next revisions of your patchsets, you should drop > Reviewed-by: tags on patches when they've changed more than trivially > because otherwise those tags have no meaning at all. > > Also, please take the time to peruse the above document on the kernel > process while waiting. I will make sure to remove the Reviewed-by/Tested-by tags for the changed patches in the next submission. But, IMO, changes made in this patch is minimal. Nothing changed functionally. So, do we still need to remove the tags for this patch? -- Sathyanarayanan Kuppuswamy Linux Kernel Developer