From: Boris Ostrovsky <boris.ostrovsky@oracle.com>
To: Roger Pau Monne <roger.pau@citrix.com>, linux-kernel@vger.kernel.org
Cc: Juergen Gross <jgross@suse.com>,
Stefano Stabellini <sstabellini@kernel.org>,
Jan Beulich <jbeulich@suse.com>,
xen-devel@lists.xenproject.org
Subject: Re: [PATCH v2 0/2] xen/x86: alternative fix for XSA-369
Date: Wed, 24 Mar 2021 19:09:51 -0400 [thread overview]
Message-ID: <6b70700e-667b-03a7-8f5e-937d5c45c79d@oracle.com> (raw)
In-Reply-To: <20210324122424.58685-1-roger.pau@citrix.com>
On 3/24/21 8:24 AM, Roger Pau Monne wrote:
> Hello,
>
> This is a proposal for an alternative fix for XSA-369 that instead of
> special casing XEN_UNPOPULATED_ALLOC to size the p2m relies on making
> XEN_BALLOON_MEMORY_HOTPLUG_LIMIT depend on the generic MEMORY_HOTPLUG
> option rather than XEN_BALLOON_MEMORY_HOTPLUG.
>
> I think this is safer, as we don't want to be special casing any option
> that pulls in generic MEMORY_HOTPLUG without XEN_BALLOON_MEMORY_HOTPLUG.
> Without this we would also need to at least special case ZONE_DEVICE
> which also relies on MEMORY_HOTPLUG, and is what pulls the generic
> MEMORY_HOTPLUG option even when XEN_BALLOON_MEMORY_HOTPLUG is disabled
> with XEN_UNPOPULATED_ALLOC.
>
> Thanks, Roger.
>
> Roger Pau Monne (2):
> xen/x86: make XEN_BALLOON_MEMORY_HOTPLUG_LIMIT depend on
> MEMORY_HOTPLUG
> Revert "xen: fix p2m size in dom0 for disabled memory hotplug case"
>
> arch/x86/include/asm/xen/page.h | 12 ------------
> arch/x86/xen/p2m.c | 7 ++-----
> arch/x86/xen/setup.c | 16 ++++++++++++++--
> drivers/xen/Kconfig | 4 ++--
> 4 files changed, 18 insertions(+), 21 deletions(-)
Reviewed-by: Boris Ostrovsky <boris.ostrovsky@oracle.com>
next prev parent reply other threads:[~2021-03-24 23:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-24 12:24 [PATCH v2 0/2] xen/x86: alternative fix for XSA-369 Roger Pau Monne
2021-03-24 12:24 ` [PATCH v2 1/2] xen/x86: make XEN_BALLOON_MEMORY_HOTPLUG_LIMIT depend on MEMORY_HOTPLUG Roger Pau Monne
2021-03-24 12:24 ` [PATCH v2 2/2] Revert "xen: fix p2m size in dom0 for disabled memory hotplug case" Roger Pau Monne
2021-03-24 23:09 ` Boris Ostrovsky [this message]
2021-03-25 22:56 ` [PATCH v2 0/2] xen/x86: alternative fix for XSA-369 Boris Ostrovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6b70700e-667b-03a7-8f5e-937d5c45c79d@oracle.com \
--to=boris.ostrovsky@oracle.com \
--cc=jbeulich@suse.com \
--cc=jgross@suse.com \
--cc=linux-kernel@vger.kernel.org \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).