From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Zheng Li <lizheng043@gmail.com>,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
davem@davemloft.net, kuznet@ms2.inr.ac.ru, jmorris@namei.org,
yoshfuji@linux-ipv6.org, kaber@trash.net
Cc: james.z.li@ericsson.com
Subject: Re: [PATCH] ipv4: Should use consistent conditional judgement for ip fragment in __ip_append_data and ip_finish_output
Date: Fri, 9 Dec 2016 15:03:47 +0300 [thread overview]
Message-ID: <6b85952d-a16d-2920-ebde-c69cec7e1494@cogentembedded.com> (raw)
In-Reply-To: <1481252918-3514-1-git-send-email-lizheng043@gmail.com>
Hello!
On 12/9/2016 6:08 AM, Zheng Li wrote:
> From: zheng li <james.z.li@ericsson.com>
>
> There is an inconsitent conditional judgement in __ip_append_data and
Inconsistent.
> ip_finish_output functions, the variable length in __ip_append_data just
> include the length of applicatoin's payload and udp header, don't include
Application.
> the length of ip header, but in ip_finish_output use
> (skb->len > ip_skb_dst_mtu(skb)) as judgement, and skb->len include the
> length of ip header.
>
> That cuase some particular applicatoin's udp payload whose length is
Causes, application.
> between (MTU - IP Header) and MTU were framented by ip_fragment even
Fragmented.
> though the rst->dev support UFO feature.
>
> Add the length of ip header to length in __ip_append_data to keep
> consistent conditional judgement as ip_finish_output for ip fragment.
>
> Signed-off-by: Zheng Li <james.z.li@ericsson.com>
[...]
MBR, Sergei
prev parent reply other threads:[~2016-12-09 12:03 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-09 3:08 [PATCH] ipv4: Should use consistent conditional judgement for ip fragment in __ip_append_data and ip_finish_output Zheng Li
2016-12-09 12:03 ` Sergei Shtylyov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6b85952d-a16d-2920-ebde-c69cec7e1494@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=davem@davemloft.net \
--cc=james.z.li@ericsson.com \
--cc=jmorris@namei.org \
--cc=kaber@trash.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=lizheng043@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).