From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7F34BC19F2A for ; Thu, 11 Aug 2022 22:10:16 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230239AbiHKWKO (ORCPT ); Thu, 11 Aug 2022 18:10:14 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47928 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230006AbiHKWKL (ORCPT ); Thu, 11 Aug 2022 18:10:11 -0400 Received: from sender4-op-o14.zoho.com (sender4-op-o14.zoho.com [136.143.188.14]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1D5A1A026A; Thu, 11 Aug 2022 15:10:10 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1660255755; cv=none; d=zohomail.com; s=zohoarc; b=hMvs2oJMne1yVImneST7KbWUNwdgKhxFA0mi+4AnyeoGhsn/nOb9uhVt1/zecAFWqp+xsi+L3YC+nNI/DjkxKSDXx5D/4uCL+WKT7fdcKpAk78vQ1CbazQqP+Bt14EZQ6OUUoCWP064QtdztGgJgFA1F9tWjjC8wugyTCRrscQA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1660255755; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=aFFMtaVBliTagdTvSpSN15r9jSDZm4o7vU7Pd75SHu4=; b=Dog8CgAmfWALpRjNmir8xU7iv2zgTd6vZv5sJKrmnX+tPO0vglPU1s0upoE7SIjtB9YZSrBIO+7O3QgFpWn4mPiaOzE98OFejWiqVZ4I68V7dQdHexcwKVz43sTebVC8rkmDKj94wOnaiU1J0QSKPcPWLy11n+nYwWq3l9sHFLU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=arinc9.com; spf=pass smtp.mailfrom=arinc.unal@arinc9.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1660255755; s=zmail; d=arinc9.com; i=arinc.unal@arinc9.com; h=Message-ID:Date:Date:MIME-Version:Subject:Subject:To:To:Cc:Cc:References:From:From:In-Reply-To:Content-Type:Content-Transfer-Encoding:Message-Id:Reply-To; bh=aFFMtaVBliTagdTvSpSN15r9jSDZm4o7vU7Pd75SHu4=; b=YfLL99dDY71yrA88XdSECdHu5Hole25hcBOCy4oBu/T+TpXclhA4cFXYmj31jY6g 1jTBD3o/9Ti0LGWOcpGHgmSsy13kwADqmTAre4V+PgaHc7gf5a4wHr1C+8XhXzH7zdK MgYsLjfrnq8H1ByvAmCXV+b7W9esSvQoxOCErFjQ= Received: from [10.10.10.3] (37.120.152.236 [37.120.152.236]) by mx.zohomail.com with SMTPS id 1660255752376179.3283196687969; Thu, 11 Aug 2022 15:09:12 -0700 (PDT) Message-ID: <6bbb23e5-d073-33fc-e16b-e8de8091eb44@arinc9.com> Date: Fri, 12 Aug 2022 01:09:04 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0 Subject: Re: [PATCH 1/4] dt-bindings: net: dsa: mediatek,mt7530: make trivial changes Content-Language: en-US To: Krzysztof Kozlowski , Andrew Lunn , Vivien Didelot , Florian Fainelli , Vladimir Oltean , "David S . Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Rob Herring , Krzysztof Kozlowski , Matthias Brugger , Sean Wang , Landen Chao , DENG Qingfang , Frank Wunderlich , Luiz Angelo Daros de Luca , Sander Vanheule , =?UTF-8?Q?Ren=c3=a9_van_Dorst?= , Daniel Golle , erkin.bozoglu@xeront.com, Sergio Paracuellos Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org References: <20220730142627.29028-1-arinc.unal@arinc9.com> <20220730142627.29028-2-arinc.unal@arinc9.com> From: =?UTF-8?B?QXLEsW7DpyDDnE5BTA==?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-ZohoMailClient: External Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2.08.2022 11:41, Krzysztof Kozlowski wrote: > On 30/07/2022 16:26, Arınç ÜNAL wrote: >> Make trivial changes on the binding. >> >> - Update title to include MT7531 switch. >> - Add me as a maintainer. List maintainers in alphabetical order by first >> name. >> - Add description to compatible strings. >> - Fix MCM description. mediatek,mcm is not used on MT7623NI. >> - Add description for reset-gpios. >> - Remove quotes from $ref: "dsa.yaml#". >> >> Signed-off-by: Arınç ÜNAL >> --- >> .../bindings/net/dsa/mediatek,mt7530.yaml | 27 ++++++++++++++----- >> 1 file changed, 20 insertions(+), 7 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml >> index 17ab6c69ecc7..541984a7d2d4 100644 >> --- a/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml >> +++ b/Documentation/devicetree/bindings/net/dsa/mediatek,mt7530.yaml >> @@ -4,12 +4,13 @@ >> $id: http://devicetree.org/schemas/net/dsa/mediatek,mt7530.yaml# >> $schema: http://devicetree.org/meta-schemas/core.yaml# >> >> -title: Mediatek MT7530 Ethernet switch >> +title: Mediatek MT7530 and MT7531 Ethernet Switches >> >> maintainers: >> - - Sean Wang >> + - Arınç ÜNAL >> - Landen Chao >> - DENG Qingfang >> + - Sean Wang >> >> description: | >> Port 5 of mt7530 and mt7621 switch is muxed between: >> @@ -66,6 +67,14 @@ properties: >> - mediatek,mt7531 >> - mediatek,mt7621 >> >> + description: | >> + mediatek,mt7530: >> + For standalone MT7530 and multi-chip module MT7530 in MT7623AI SoC. >> + mediatek,mt7531: >> + For standalone MT7531. >> + mediatek,mt7621: >> + For multi-chip module MT7530 in MT7621AT, MT7621DAT and MT7621ST SoCs. > > If compatible: is changed to oneOf, you can use description for each > item. Look at board compatibles (arm/fsl.yaml) Will do, thanks for the example. > >> + >> reg: >> maxItems: 1 >> >> @@ -79,7 +88,7 @@ properties: >> gpio-controller: >> type: boolean >> description: >> - if defined, MT7530's LED controller will run on GPIO mode. >> + If defined, MT7530's LED controller will run on GPIO mode. >> >> "#interrupt-cells": >> const: 1 >> @@ -98,11 +107,15 @@ properties: >> mediatek,mcm: >> type: boolean >> description: >> - if defined, indicates that either MT7530 is the part on multi-chip >> - module belong to MT7623A has or the remotely standalone chip as the >> - function MT7623N reference board provided for. >> + Used for MT7621AT, MT7621DAT, MT7621ST and MT7623AI SoCs which the MT7530 >> + switch is a part of the multi-chip module. > > Does this mean it is valid only on these variants? If yes, this should > have a "mediatek,mcm:false" in allOf:if:then as separate patch (with > this change in description). Only valid for those, yes. I'll make it false in allOf:if:then for mediatek,mt7531. It either can or can't be used for mediatek,mt7530 so nothing to do there. > >> >> reset-gpios: >> + description: >> + GPIO to reset the switch. Use this if mediatek,mcm is not used. > > The same. Example: > https://elixir.bootlin.com/linux/v5.17-rc2/source/Documentation/devicetree/bindings/mfd/samsung,s5m8767.yaml#L155 Thanks, I'll make it false in allOf:if:then for mediatek,mcm. Arınç