From: "Jürgen Groß" <jgross@suse.com>
To: Peter Zijlstra <peterz@infradead.org>,
"Paul E. McKenney" <paulmck@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org,
mhocko@suse.com, Jonathan Corbet <corbet@lwn.net>
Subject: Re: [PATCH 3/3] kernel/smp: add more data to CSD lock debugging
Date: Mon, 1 Mar 2021 16:53:27 +0100 [thread overview]
Message-ID: <6bc3d90d-f369-e91d-01f7-b83a48e9721d@suse.com> (raw)
In-Reply-To: <YD0MI1Cye+YbOov3@hirez.programming.kicks-ass.net>
[-- Attachment #1.1.1: Type: text/plain, Size: 1311 bytes --]
On 01.03.21 16:45, Peter Zijlstra wrote:
> On Sun, Feb 28, 2021 at 04:07:04PM -0800, Paul E. McKenney wrote:
>> On Fri, Feb 26, 2021 at 10:05:51PM +0100, Peter Zijlstra wrote:
>>> On Fri, Feb 26, 2021 at 10:12:05AM -0800, Paul E. McKenney wrote:
>>>> On Fri, Feb 26, 2021 at 05:38:44PM +0100, Peter Zijlstra wrote:
>>>>>
>>>>> I hate all of this, but if this will finally catch the actual problem,
>>>>> we can then revert all this, so sure.
>>>>
>>>> OK, I will bite... What exactly do you hate about it?
>>>
>>> It's ugly and messy. We're basically commiting a debug session. Normally
>>> gunk like this is done in private trees, then we find the problem and
>>> fix that and crap like this never sees the light of day.
>>
>> Is your hatred due to the presence of debug code at all, or a belief that
>> this code is unlikely to be useful in any subsequent IPI-related bug hunt?
>
> The clutter, mostly I think. There's a lot of debug sprinkled about.
I agree.
In case we are able to identify the root cause of the problem I think
it would be no problem to revert this patch and put a comment into smp.c
naming the commit-id of this patch and what it was good for. This will
enable future bug hunters to make use of the patch without spoiling the
code for others.
Juergen
[-- Attachment #1.1.2: OpenPGP_0xB0DE9DD628BF132F.asc --]
[-- Type: application/pgp-keys, Size: 3135 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]
next prev parent reply other threads:[~2021-03-01 15:54 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-02-26 11:25 [PATCH 0/3] kernel/smp.c: add more CSD lock debugging Juergen Gross
2021-02-26 11:25 ` [PATCH 1/3] kernel/smp: add boot parameter for controlling " Juergen Gross
2021-02-26 11:25 ` [PATCH 2/3] kernel/smp: prepare more " Juergen Gross
2021-02-26 11:25 ` [PATCH 3/3] kernel/smp: add more data to " Juergen Gross
2021-02-26 16:38 ` Peter Zijlstra
2021-02-26 18:12 ` Paul E. McKenney
2021-02-26 21:05 ` Peter Zijlstra
2021-03-01 0:07 ` Paul E. McKenney
2021-03-01 15:45 ` Peter Zijlstra
2021-03-01 15:53 ` Jürgen Groß [this message]
2021-03-01 16:45 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6bc3d90d-f369-e91d-01f7-b83a48e9721d@suse.com \
--to=jgross@suse.com \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhocko@suse.com \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).