From: Matthias Brugger <matthias.bgg@gmail.com>
To: Fabien Parent <fparent@baylibre.com>, lee.jones@linaro.org
Cc: linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/2] mfd: mt6397: use DEFINE_RES_* helpers to define RTC resources
Date: Tue, 18 Jun 2019 23:18:44 +0200 [thread overview]
Message-ID: <6bf2d5a0-a768-b178-80c7-4f28f7db212c@gmail.com> (raw)
In-Reply-To: <20190618154347.16991-2-fparent@baylibre.com>
On 18/06/2019 17:43, Fabien Parent wrote:
> Use the DEFINE_RES_{MEM,IRQ} to define the RTC reosurce for the MT6397
> PMIC.
>
> Signed-off-by: Fabien Parent <fparent@baylibre.com>
Reviewed-by: Matthias Brugger <matthias.bgg@gmail.com>
> ---
> drivers/mfd/mt6397-core.c | 12 ++----------
> 1 file changed, 2 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/mfd/mt6397-core.c b/drivers/mfd/mt6397-core.c
> index 190ed86ad93e..1e315712870b 100644
> --- a/drivers/mfd/mt6397-core.c
> +++ b/drivers/mfd/mt6397-core.c
> @@ -23,16 +23,8 @@
> #define MT6397_CID_CODE 0x97
>
> static const struct resource mt6397_rtc_resources[] = {
> - {
> - .start = MT6397_RTC_BASE,
> - .end = MT6397_RTC_BASE + MT6397_RTC_SIZE,
> - .flags = IORESOURCE_MEM,
> - },
> - {
> - .start = MT6397_IRQ_RTC,
> - .end = MT6397_IRQ_RTC,
> - .flags = IORESOURCE_IRQ,
> - },
> + DEFINE_RES_MEM(MT6397_RTC_BASE, MT6397_RTC_SIZE),
> + DEFINE_RES_IRQ(MT6397_IRQ_RTC),
> };
>
> static const struct resource mt6323_keys_resources[] = {
>
next prev parent reply other threads:[~2019-06-18 21:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-18 15:43 [PATCH 1/2] mfd: mt6397: Use PLATFORM_DEVID_NONE macro instead of -1 Fabien Parent
2019-06-18 15:43 ` [PATCH 2/2] mfd: mt6397: use DEFINE_RES_* helpers to define RTC resources Fabien Parent
2019-06-18 21:18 ` Matthias Brugger [this message]
2019-06-18 21:16 ` [PATCH 1/2] mfd: mt6397: Use PLATFORM_DEVID_NONE macro instead of -1 Matthias Brugger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6bf2d5a0-a768-b178-80c7-4f28f7db212c@gmail.com \
--to=matthias.bgg@gmail.com \
--cc=fparent@baylibre.com \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).