From: Ahmad Fatoum <a.fatoum@pengutronix.de>
To: Vladimir Oltean <vladimir.oltean@nxp.com>,
Kurt Kanzenbach <kurt.kanzenbach@linutronix.de>,
Holger Assmann <h.assmann@pengutronix.de>
Cc: Yannick Vignon <yannick.vignon@nxp.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
Xiaoliang Yang <xiaoliang.yang_1@nxp.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
"linux-stm32@st-md-mailman.stormreply.com"
<linux-stm32@st-md-mailman.stormreply.com>,
Jose Abreu <joabreu@synopsys.com>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
Jakub Kicinski <kuba@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
Pengutronix Kernel Team <kernel@pengutronix.de>
Subject: Re: [Linux-stm32] [PATCH net] net: stmmac: allow a tc-taprio base-time of zero
Date: Tue, 9 Nov 2021 15:19:28 +0100 [thread overview]
Message-ID: <6bf6db8b-4717-71fe-b6de-9f6e12202dad@pengutronix.de> (raw)
In-Reply-To: <20211109103504.ahl2djymnevsbhoj@skbuf>
Hello Vladimir, Kurt,
On 09.11.21 11:35, Vladimir Oltean wrote:
> On Tue, Nov 09, 2021 at 09:20:53AM +0100, Kurt Kanzenbach wrote:
>> Hi Vladimir,
>>
>> On Mon Nov 08 2021, Vladimir Oltean wrote:
>>> Commit fe28c53ed71d ("net: stmmac: fix taprio configuration when
>>> base_time is in the past") allowed some base time values in the past,
>>> but apparently not all, the base-time value of 0 (Jan 1st 1970) is still
>>> explicitly denied by the driver.
>>>
>>> Remove the bogus check.
>>>
>>> Fixes: b60189e0392f ("net: stmmac: Integrate EST with TAPRIO scheduler API")
>>> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
>>
>> I've experienced the same problem and wanted to send a patch for
>> it. Thanks!
>>
>> Reviewed-by: Kurt Kanzenbach <kurt@linutronix.de>
>
> Cool. So you had that patch queued up? What other stmmac patches do you
> have queued up? :) Do you have a fix for the driver setting the PTP time
> every time when SIOCSHWTSTAMP is called? This breaks the UTC-to-TAI
> offset established by phc2sys and it takes a few seconds to readjust,
> which is very annoying.
Sounds like the same issue in:
https://lore.kernel.org/netdev/20201216113239.2980816-1-h.assmann@pengutronix.de/
Cheers,
Ahmad
> _______________________________________________
> Linux-stm32 mailing list
> Linux-stm32@st-md-mailman.stormreply.com
> https://st-md-mailman.stormreply.com/mailman/listinfo/linux-stm32
>
--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2021-11-09 14:19 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-08 20:28 [PATCH net] net: stmmac: allow a tc-taprio base-time of zero Vladimir Oltean
2021-11-09 8:20 ` Kurt Kanzenbach
2021-11-09 10:35 ` Vladimir Oltean
2021-11-09 14:19 ` Ahmad Fatoum [this message]
2021-11-09 14:22 ` [Linux-stm32] " Vladimir Oltean
2021-11-10 12:38 ` Vladimir Oltean
2021-11-11 10:48 ` Holger Assmann
2021-11-09 14:47 ` Kurt Kanzenbach
2021-11-09 15:08 ` Yannick Vignon
2021-11-16 12:18 ` Kurt Kanzenbach
2021-11-10 14:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6bf6db8b-4717-71fe-b6de-9f6e12202dad@pengutronix.de \
--to=a.fatoum@pengutronix.de \
--cc=alexandre.torgue@foss.st.com \
--cc=davem@davemloft.net \
--cc=h.assmann@pengutronix.de \
--cc=joabreu@synopsys.com \
--cc=kernel@pengutronix.de \
--cc=kuba@kernel.org \
--cc=kurt.kanzenbach@linutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mcoquelin.stm32@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=peppe.cavallaro@st.com \
--cc=vladimir.oltean@nxp.com \
--cc=xiaoliang.yang_1@nxp.com \
--cc=yannick.vignon@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).