From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.5 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05354C433DF for ; Fri, 14 Aug 2020 07:20:00 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DD2D52074D for ; Fri, 14 Aug 2020 07:19:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726647AbgHNHT6 (ORCPT ); Fri, 14 Aug 2020 03:19:58 -0400 Received: from out30-132.freemail.mail.aliyun.com ([115.124.30.132]:51904 "EHLO out30-132.freemail.mail.aliyun.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726213AbgHNHT4 (ORCPT ); Fri, 14 Aug 2020 03:19:56 -0400 X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R101e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04407;MF=alex.shi@linux.alibaba.com;NM=1;PH=DS;RN=19;SR=0;TI=SMTPD_---0U5iicOY_1597389589; Received: from IT-FVFX43SYHV2H.local(mailfrom:alex.shi@linux.alibaba.com fp:SMTPD_---0U5iicOY_1597389589) by smtp.aliyun-inc.com(127.0.0.1); Fri, 14 Aug 2020 15:19:51 +0800 Subject: Re: [RFC PATCH 2/3] mm: Drop use of test_and_set_skip in favor of just setting skip To: Alexander Duyck Cc: yang.shi@linux.alibaba.com, lkp@intel.com, rong.a.chen@intel.com, khlebnikov@yandex-team.ru, kirill@shutemov.name, hughd@google.com, linux-kernel@vger.kernel.org, daniel.m.jordan@oracle.com, linux-mm@kvack.org, shakeelb@google.com, willy@infradead.org, hannes@cmpxchg.org, tj@kernel.org, cgroups@vger.kernel.org, akpm@linux-foundation.org, richard.weiyang@gmail.com, mgorman@techsingularity.net, iamjoonsoo.kim@lge.com References: <20200813035100.13054.25671.stgit@localhost.localdomain> <20200813040232.13054.82417.stgit@localhost.localdomain> From: Alex Shi Message-ID: <6c072332-ff16-757d-99dd-b8fbae131a0c@linux.alibaba.com> Date: Fri, 14 Aug 2020 15:19:09 +0800 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200813040232.13054.82417.stgit@localhost.localdomain> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 在 2020/8/13 下午12:02, Alexander Duyck 写道: > > Since we have dropped the late abort case we can drop the code that was > clearing the LRU flag and calling page_put since the abort case will now > not be holding a reference to a page. > > Signed-off-by: Alexander Duyck seems the case-lru-file-mmap-read case drop about 3% on this patch in a rough testing. on my 80 core machine. Thanks Alex