From: zhangfei <zhangfei.gao@linaro.org>
To: Dave Jiang <dave.jiang@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: Arnd Bergmann <arnd@arndb.de>,
Herbert Xu <herbert@gondor.apana.org.au>,
jonathan.cameron@huawei.com, grant.likely@arm.com,
jean-philippe <jean-philippe@linaro.org>,
Jerome Glisse <jglisse@redhat.com>,
ilias.apalodimas@linaro.org, francois.ozog@linaro.org,
kenneth-lee-2012@foxmail.com, Wangzhou <wangzhou1@hisilicon.com>,
"haojian . zhuang" <haojian.zhuang@linaro.org>,
guodong.xu@linaro.org, linux-accelerators@lists.ozlabs.org,
linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org,
iommu@lists.linux-foundation.org,
Kenneth Lee <liguozhu@hisilicon.com>,
Zaibo Xu <xuzaibo@huawei.com>
Subject: Re: [PATCH v11 2/4] uacce: add uacce driver
Date: Thu, 16 Jan 2020 10:11:20 +0800 [thread overview]
Message-ID: <6c08d1ad-53a5-0238-3767-c40d7b10df3c@linaro.org> (raw)
In-Reply-To: <9454d674-85db-32ba-4f28-eb732777d59d@intel.com>
Hi, Dave
On 2020/1/16 上午12:43, Dave Jiang wrote:
>
>
> On 1/15/20 4:18 AM, zhangfei wrote:
>> Hi, Greg
>>
>> On 2020/1/14 下午10:59, Greg Kroah-Hartman wrote:
>>> On Mon, Jan 13, 2020 at 11:34:55AM +0800, zhangfei wrote:
>>>> Hi, Greg
>>>>
>>>> Thanks for the review.
>>>>
>>>> On 2020/1/12 上午3:40, Greg Kroah-Hartman wrote:
>>>>> On Sat, Jan 11, 2020 at 10:48:37AM +0800, Zhangfei Gao wrote:
>>>>>> +static int uacce_fops_open(struct inode *inode, struct file *filep)
>>>>>> +{
>>>>>> + struct uacce_mm *uacce_mm = NULL;
>>>>>> + struct uacce_device *uacce;
>>>>>> + struct uacce_queue *q;
>>>>>> + int ret = 0;
>>>>>> +
>>>>>> + uacce = xa_load(&uacce_xa, iminor(inode));
>>>>>> + if (!uacce)
>>>>>> + return -ENODEV;
>>>>>> +
>>>>>> + if (!try_module_get(uacce->parent->driver->owner))
>>>>>> + return -ENODEV;
>>>>> Why are you trying to grab the module reference of the parent device?
>>>>> Why is that needed and what is that going to help with here?
>>>>>
>>>>> This shouldn't be needed as the module reference of the owner of the
>>>>> fileops for this module is incremented, and the "parent" module
>>>>> depends
>>>>> on this module, so how could it be unloaded without this code being
>>>>> unloaded?
>>>>>
>>>>> Yes, if you build this code into the kernel and the "parent"
>>>>> driver is a
>>>>> module, then you will not have a reference, but when you remove that
>>>>> parent driver the device will be removed as it has to be unregistered
>>>>> before that parent driver can be removed from the system, right?
>>>>>
>>>>> Or what am I missing here?
>>>> The refcount here is preventing rmmod "parent" module after fd is
>>>> opened,
>>>> since user driver has mmap kernel memory to user space, like mmio,
>>>> which may
>>>> still in-use.
>>>>
>>>> With the refcount protection, rmmod "parent" module will fail until
>>>> application free the fd.
>>>> log like: rmmod: ERROR: Module hisi_zip is in use
>>> But if the "parent" module is to be unloaded, it has to unregister the
>>> "child" device and that will call the destructor in here and then you
>>> will tear everything down and all should be good.
>>>
>>> There's no need to "forbid" a module from being unloaded, even if it is
>>> being used. Look at all networking drivers, they work that way, right?
>> Thanks Greg for the kind suggestion.
>>
>> I still have one uncertainty.
>> Does uacce has to block process continue accessing the mmapped area
>> when remove "parent" module?
>> Uacce can block device access the physical memory when parent module
>> call uacce_remove.
>> But application is still running, and suppose it is not the kernel
>> driver's responsibility to call unmap.
>>
>> I am looking for some examples in kernel,
>> looks vfio does not block process continue accessing when
>> vfio_unregister_iommu_driver either.
>>
>> In my test, application will keep waiting after rmmod parent, until
>> ctrl+c, when unmap is called.
>> During the process, kernel does not report any error.
>>
>> Do you have any advice?
>
> Would it work to call unmap_mapping_range() on the char dev
> inode->i_mappings? I think you need to set the vma->fault function ptr
> for the vm_operations_struct in the original mmap(). After the
> mappings are unmapped, you can set a state variable to trigger the
> return of VM_FAULT_SIGBUS in the ->fault function when the user app
> accesses the mmap region again and triggers a page fault. The user app
> needs to be programmed to catch exceptions to deal with that.
Thanks Dave for the advice.
Will look into it, may need some time to investigate.
I would like to make an additional patch for this issue, since it does
not impact the main function.
Thanks
next prev parent reply other threads:[~2020-01-16 2:12 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-11 2:48 [PATCH v11 0/4] Add uacce module for Accelerator Zhangfei Gao
2020-01-11 2:48 ` [PATCH v11 1/4] uacce: Add documents for uacce Zhangfei Gao
2020-01-11 2:48 ` [PATCH v11 2/4] uacce: add uacce driver Zhangfei Gao
2020-01-11 19:40 ` Greg Kroah-Hartman
2020-01-13 3:34 ` zhangfei
2020-01-14 14:59 ` Greg Kroah-Hartman
2020-01-15 11:18 ` zhangfei
2020-01-15 12:02 ` Greg Kroah-Hartman
2020-01-15 14:11 ` zhangfei
2020-01-15 16:43 ` Dave Jiang
2020-01-16 2:11 ` zhangfei [this message]
2020-01-11 2:48 ` [PATCH v11 3/4] crypto: hisilicon - Remove module_param uacce_mode Zhangfei Gao
2020-01-11 2:48 ` [PATCH v11 4/4] crypto: hisilicon - register zip engine to uacce Zhangfei Gao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6c08d1ad-53a5-0238-3767-c40d7b10df3c@linaro.org \
--to=zhangfei.gao@linaro.org \
--cc=arnd@arndb.de \
--cc=dave.jiang@intel.com \
--cc=francois.ozog@linaro.org \
--cc=grant.likely@arm.com \
--cc=gregkh@linuxfoundation.org \
--cc=guodong.xu@linaro.org \
--cc=haojian.zhuang@linaro.org \
--cc=herbert@gondor.apana.org.au \
--cc=ilias.apalodimas@linaro.org \
--cc=iommu@lists.linux-foundation.org \
--cc=jean-philippe@linaro.org \
--cc=jglisse@redhat.com \
--cc=jonathan.cameron@huawei.com \
--cc=kenneth-lee-2012@foxmail.com \
--cc=liguozhu@hisilicon.com \
--cc=linux-accelerators@lists.ozlabs.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wangzhou1@hisilicon.com \
--cc=xuzaibo@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).