From: Jakob Unterwurzacher <jakob.unterwurzacher@theobroma-systems.com>
To: Marc Kleine-Budde <mkl@pengutronix.de>
Cc: Martin Elshuber <martin.elshuber@theobroma-systems.com>,
Philipp Tomsich <philipp.tomsich@theobroma-systems.com>,
Wolfgang Grandegger <wg@grandegger.com>,
linux-can@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/1] can: ucan: add driver for Theobroma Systems UCAN devices
Date: Wed, 14 Mar 2018 10:09:52 +0100 [thread overview]
Message-ID: <6c1b7482-2cde-40e3-eff4-e4b94794a63e@theobroma-systems.com> (raw)
In-Reply-To: <b4f644dc-265e-01e0-acaa-88cc8f3f69f5@pengutronix.de>
On 14.03.18 08:51, Marc Kleine-Budde wrote:
>> + memcpy(cf->data, m->msg.can_msg.data, cf->can_dlc);
>> +
>> + /* don't count error frames as real packets */
>> + if (!(canid & CAN_ERR_FLAG)) {
>> + stats->rx_packets++;
>> + stats->rx_bytes += cf->can_dlc;
>> + }
> Please count them, too.
We do count them, as errors!
This is what happens when you transmit a single CAN frame with nothing
connected: "TX errors" shoots up but "RX packets" stays zero.
> root@rk3399-q7:~# ip -details -statistics link show can0
[...]
> RX: bytes packets errors dropped overrun mcast
> 0 0 0 0 0 0
> TX: bytes packets errors dropped carrier collsns
> 0 0 20425 0 0 0
next prev parent reply other threads:[~2018-03-14 9:09 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-13 17:35 [PATCH v2 0/1] can: ucan: add driver for Theobroma Systems UCAN devices Jakob Unterwurzacher
2018-03-13 17:35 ` [PATCH v2 1/1] " Jakob Unterwurzacher
2018-03-13 17:44 ` Marc Kleine-Budde
2018-03-13 17:53 ` Jakob Unterwurzacher
2018-03-13 17:56 ` Marc Kleine-Budde
2018-03-14 7:51 ` Marc Kleine-Budde
2018-03-14 9:09 ` Jakob Unterwurzacher [this message]
2018-03-14 9:36 ` rx_packets/bytes stats for error frames (was: Re: [PATCH v2 1/1] can: ucan: add driver for Theobroma Systems UCAN devices) Marc Kleine-Budde
2018-03-14 9:46 ` rx_packets/bytes stats for error frames Wolfgang Grandegger
2018-03-14 9:57 ` Jakob Unterwurzacher
2018-03-14 9:11 ` [PATCH v2 1/1] can: ucan: add driver for Theobroma Systems UCAN devices Wolfgang Grandegger
2018-03-14 9:14 ` Jakob Unterwurzacher
2018-03-14 9:17 ` Wolfgang Grandegger
2018-03-14 9:21 ` Jakob Unterwurzacher
2018-03-14 9:25 ` Wolfgang Grandegger
2018-03-14 9:48 ` Jakob Unterwurzacher
2018-03-14 10:04 ` Wolfgang Grandegger
2018-03-14 10:19 ` Jakob Unterwurzacher
2018-03-14 19:07 ` Jakob Unterwurzacher
2018-03-15 6:58 ` Wolfgang Grandegger
2018-03-16 7:01 ` kbuild test robot
2018-03-16 12:14 ` kbuild test robot
2018-03-13 17:40 ` [PATCH v2 0/1] Open questions Jakob Unterwurzacher
[not found] ` <06378497-1ACE-4333-810F-4E3E4706CCD5@theobroma-systems.com>
2018-03-13 17:48 ` Jakob Unterwurzacher
2018-03-13 17:48 ` Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6c1b7482-2cde-40e3-eff4-e4b94794a63e@theobroma-systems.com \
--to=jakob.unterwurzacher@theobroma-systems.com \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.elshuber@theobroma-systems.com \
--cc=mkl@pengutronix.de \
--cc=philipp.tomsich@theobroma-systems.com \
--cc=wg@grandegger.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).