From: Ilya Maximets <i.maximets@ovn.org>
To: Andrii Nakryiko <andrii.nakryiko@gmail.com>,
Ilya Maximets <i.maximets@ovn.org>
Cc: Networking <netdev@vger.kernel.org>, bpf <bpf@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
Alexei Starovoitov <ast@kernel.org>,
Daniel Borkmann <daniel@iogearbox.net>,
"David S . Miller" <davem@davemloft.net>,
Jonathan Lemon <jonathan.lemon@gmail.com>
Subject: Re: [PATCH bpf] libbpf: fix passing uninitialized bytes to setsockopt
Date: Wed, 9 Oct 2019 18:39:56 +0200 [thread overview]
Message-ID: <6c1b8c0f-c317-e59e-de02-9b0afc2cb9a0@ovn.org> (raw)
In-Reply-To: <CAEf4BzYtftYQaUa53pKE77cd5tnz3WDY2KDaixhT7XHQ8hyObg@mail.gmail.com>
On 09.10.2019 18:29, Andrii Nakryiko wrote:
> On Wed, Oct 9, 2019 at 8:43 AM Ilya Maximets <i.maximets@ovn.org> wrote:
>>
>> 'struct xdp_umem_reg' has 4 bytes of padding at the end that makes
>> valgrind complain about passing uninitialized stack memory to the
>> syscall:
>>
>> Syscall param socketcall.setsockopt() points to uninitialised byte(s)
>> at 0x4E7AB7E: setsockopt (in /usr/lib64/libc-2.29.so)
>> by 0x4BDE035: xsk_umem__create@@LIBBPF_0.0.4 (xsk.c:172)
>> Uninitialised value was created by a stack allocation
>> at 0x4BDDEBA: xsk_umem__create@@LIBBPF_0.0.4 (xsk.c:140)
>>
>> Padding bytes appeared after introducing of a new 'flags' field.
>>
>> Fixes: 10d30e301732 ("libbpf: add flags to umem config")
>> Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
>> ---
>> tools/lib/bpf/xsk.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/tools/lib/bpf/xsk.c b/tools/lib/bpf/xsk.c
>> index a902838f9fcc..26d9db783560 100644
>> --- a/tools/lib/bpf/xsk.c
>> +++ b/tools/lib/bpf/xsk.c
>> @@ -139,7 +139,7 @@ int xsk_umem__create_v0_0_4(struct xsk_umem **umem_ptr, void *umem_area,
>> const struct xsk_umem_config *usr_config)
>> {
>> struct xdp_mmap_offsets off;
>> - struct xdp_umem_reg mr;
>> + struct xdp_umem_reg mr = {};
>
> well, guess what, even with this explicit initialization, padding is
> not guaranteed to be initialized (and it's sometimes is not in
> practice, I ran into such problems), only since C11 standard it is
> specified that padding is also zero-initialized. You have to do memset
> to 0.
OK. Sure. I'll send v2.
>
>> struct xsk_umem *umem;
>> socklen_t optlen;
>> void *map;
>> --
>> 2.17.1
>>
next prev parent reply other threads:[~2019-10-09 16:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-09 15:42 [PATCH bpf] libbpf: fix passing uninitialized bytes to setsockopt Ilya Maximets
2019-10-09 16:29 ` Andrii Nakryiko
2019-10-09 16:39 ` Ilya Maximets [this message]
[not found] <5da2ad7f.1c69fb81.2ed87.f547SMTPIN_ADDED_BROKEN@mx.google.com>
2019-10-13 4:59 ` Alexei Starovoitov
2019-10-13 10:01 ` Ilya Maximets
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6c1b8c0f-c317-e59e-de02-9b0afc2cb9a0@ovn.org \
--to=i.maximets@ovn.org \
--cc=andrii.nakryiko@gmail.com \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=jonathan.lemon@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).