From: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
To: Martin Schiller <ms@dev.tdt.de>, andrew@lunn.ch, f.fainelli@gmail.com
Cc: davem@davemloft.net, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] net: phy: mdio-gpio: Fix working over slow can_sleep GPIOs
Date: Wed, 14 Nov 2018 14:03:51 +0300 [thread overview]
Message-ID: <6c22e59d-b108-0df0-548b-6590b8775f61@cogentembedded.com> (raw)
In-Reply-To: <20181114101236.10398-1-ms@dev.tdt.de>
On 11/14/2018 01:12 PM, Martin Schiller wrote:
> This commit re-enables support for slow GPIO pins. It was initially
> introduced by commit 2d6c9091ab76 ("net: mdio-gpio: support access that
> may sleep") and got lost by commit 7e5fbd1e0700 ("net: mdio-gpio:
> Convert to use gpiod functions where possible").
>
> Also add a warning about slow GPIO pins like it is done in i2c-gpio.
>
> Signed-off-by: Martin Schiller <ms@dev.tdt.de>
> ---
> v3:
> - modified commit summary
> - fixed commit cites in commit message
> - fixed line continuation
>
> v2:
> - fixed copy/paste bug in warning about slow GPIO pins
> ---
> drivers/net/phy/mdio-gpio.c | 15 ++++++++++-----
> 1 file changed, 10 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/net/phy/mdio-gpio.c b/drivers/net/phy/mdio-gpio.c
> index 33265747bf39..e1c305089172 100644
> --- a/drivers/net/phy/mdio-gpio.c
> +++ b/drivers/net/phy/mdio-gpio.c
[...]
> @@ -162,6 +162,11 @@ static int mdio_gpio_probe(struct platform_device *pdev)
> if (ret)
> return ret;
>
> + if (gpiod_cansleep(bitbang->mdc) || gpiod_cansleep(bitbang->mdio) ||
> + gpiod_cansleep(bitbang->mdo))
> + dev_warn(&pdev->dev, "Slow GPIO pins might wreak havoc into"
> + "MDIO bus timing");
Oops, missed this in the 1st review: you don't need to break the kernel messages
like that, they may violate the 80-column limit (to facilitate searching)...
[...]
MBR, Sergei
next prev parent reply other threads:[~2018-11-14 11:03 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-14 6:17 [PATCH] net: phy: mdio-gpio: fix access that may sleep Martin Schiller
2018-11-14 6:37 ` [PATCH v2] " Martin Schiller
2018-11-14 7:05 ` Andrew Lunn
2018-11-14 7:43 ` Martin Schiller
2018-11-14 20:46 ` Andrew Lunn
2018-11-14 9:20 ` Sergei Shtylyov
2018-11-17 3:52 ` David Miller
2018-11-14 10:12 ` [PATCH v3] net: phy: mdio-gpio: Fix working over slow can_sleep GPIOs Martin Schiller
2018-11-14 11:03 ` Sergei Shtylyov [this message]
2018-11-14 11:54 ` [PATCH v4] " Martin Schiller
2018-11-17 4:25 ` David Miller
2018-11-17 6:28 ` Andrew Lunn
2018-11-15 5:24 ` [PATCH v5] " Martin Schiller
2018-11-15 20:12 ` Andrew Lunn
2018-11-17 7:04 ` David Miller
2018-11-16 7:38 ` [PATCH v6] " Martin Schiller
2018-11-16 7:53 ` Andrew Lunn
2018-11-17 19:52 ` Florian Fainelli
2018-11-18 5:12 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6c22e59d-b108-0df0-548b-6590b8775f61@cogentembedded.com \
--to=sergei.shtylyov@cogentembedded.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=f.fainelli@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ms@dev.tdt.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).