From: Subhash Jadavani <subhashj@codeaurora.org>
To: SF Markus Elfring <elfring@users.sourceforge.net>
Cc: linux-scsi@vger.kernel.org,
"James E. J. Bottomley" <jejb@linux.vnet.ibm.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Vinayak Holikatti <vinholikatti@gmail.com>,
LKML <linux-kernel@vger.kernel.org>,
kernel-janitors@vger.kernel.org,
linux-scsi-owner@vger.kernel.org
Subject: Re: [PATCH 3/3] scsi: ufs: Delete an unnecessary return statement in ufshcd_exception_event_handler()
Date: Wed, 26 Apr 2017 10:59:43 -0700 [thread overview]
Message-ID: <6c360ac6f9b5a9a1591757a35b8d5036@codeaurora.org> (raw)
In-Reply-To: <9fc152fd-0881-85f6-a4d0-3db27dc364f5@users.sourceforge.net>
On 2017-04-25 13:30, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@users.sourceforge.net>
> Date: Tue, 25 Apr 2017 22:00:05 +0200
>
> The script "checkpatch.pl" pointed information out like the following.
>
> WARNING: void function return statements are not generally useful
>
> Thus remove such a statement here.
>
> Signed-off-by: Markus Elfring <elfring@users.sourceforge.net>
> ---
> drivers/scsi/ufs/ufshcd.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/scsi/ufs/ufshcd.c b/drivers/scsi/ufs/ufshcd.c
> index 5216e33e61a3..9018f26a5667 100644
> --- a/drivers/scsi/ufs/ufshcd.c
> +++ b/drivers/scsi/ufs/ufshcd.c
> @@ -4966,7 +4966,6 @@ static void
> ufshcd_exception_event_handler(struct work_struct *work)
>
> out:
> pm_runtime_put_sync(hba->dev);
> - return;
> }
>
> /* Complete requests that have door-bell cleared */
Looks good to me.
Reviewed-by: Subhash Jadavani <subhashj@codeaurora.org>
--
The Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project
prev parent reply other threads:[~2017-04-26 17:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-04-25 20:24 [PATCH 0/3] SCSI-UFSHCD: Fine-tuning for two function implementations SF Markus Elfring
2017-04-25 20:26 ` [PATCH 1/3] scsi: ufs: Use devm_kcalloc() in ufshcd_memory_alloc() SF Markus Elfring
2017-04-26 17:52 ` Subhash Jadavani
2017-04-25 20:28 ` [PATCH 2/3] scsi: ufs: Delete an error message for a failed memory allocation " SF Markus Elfring
2017-04-26 17:57 ` Subhash Jadavani
2017-04-26 18:11 ` SF Markus Elfring
2017-04-26 18:27 ` [PATCH 2/3] " Joe Perches
2017-04-26 18:50 ` Checking error messages for failed memory allocations SF Markus Elfring
2017-04-26 19:05 ` Joe Perches
2017-04-26 19:14 ` SF Markus Elfring
2017-08-26 11:17 ` scsi: ufs: Delete an error message for a failed memory allocation in ufshcd_memory_alloc() SF Markus Elfring
2017-04-25 20:30 ` [PATCH 3/3] scsi: ufs: Delete an unnecessary return statement in ufshcd_exception_event_handler() SF Markus Elfring
2017-04-26 17:59 ` Subhash Jadavani [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6c360ac6f9b5a9a1591757a35b8d5036@codeaurora.org \
--to=subhashj@codeaurora.org \
--cc=elfring@users.sourceforge.net \
--cc=jejb@linux.vnet.ibm.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi-owner@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=vinholikatti@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).