From: David Laight <David.Laight@ACULAB.COM>
To: 'Nicolas Schier' <nicolas@fjasle.eu>,
Nathan Chancellor <nathan@kernel.org>
Cc: Masahiro Yamada <masahiroy@kernel.org>,
"linux-kbuild@vger.kernel.org" <linux-kbuild@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Nick Desaulniers <ndesaulniers@google.com>
Subject: RE: [PATCH] kbuild: ensure Make >= 3.82 is used
Date: Wed, 14 Dec 2022 11:05:10 +0000 [thread overview]
Message-ID: <6c4413040a624b728081e27213fb46a1@AcuMS.aculab.com> (raw)
In-Reply-To: <Y5f4ZgyK7QlqYu31@bergen.fjasle.eu>
From: Nicolas Schier
> Sent: 13 December 2022 03:59
...
> > > diff --git a/Makefile b/Makefile
> > > index 2dda1e9a717a..66dfc5751470 100644
> > > --- a/Makefile
> > > +++ b/Makefile
> > > @@ -11,6 +11,11 @@ NAME = Hurr durr I'ma ninja sloth
> > > # Comments in this file are targeted only to the developer, do not
> > > # expect to learn how to build the kernel reading this file.
> > >
> > > +# Ensure Make >= 3.82
Wouldn't it be better to say either:
# Ensure gmake supports 'undefine' (added in 3.82)
or:
# Building with gmake versions prior to 3.82 fails due to
# bug 'brief description'.
# Check for 'undefine' support as a surrogate for the bug fix.
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
next prev parent reply other threads:[~2022-12-14 11:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-11 3:03 [PATCH] kbuild: ensure Make >= 3.82 is used Masahiro Yamada
2022-12-12 17:21 ` Nathan Chancellor
2022-12-13 3:58 ` Nicolas Schier
2022-12-13 10:05 ` Nicolas Schier
2022-12-13 16:42 ` Nathan Chancellor
2022-12-14 11:05 ` David Laight [this message]
2022-12-16 4:30 ` Nicolas Schier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6c4413040a624b728081e27213fb46a1@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=masahiroy@kernel.org \
--cc=nathan@kernel.org \
--cc=ndesaulniers@google.com \
--cc=nicolas@fjasle.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).