From: Krzysztof Kozlowski <krzk@kernel.org>
To: Dylan Hung <dylan_hung@aspeedtech.com>,
robh+dt@kernel.org, joel@jms.id.au, andrew@aj.id.au,
andrew@lunn.ch, hkallweit1@gmail.com, linux@armlinux.org.uk,
davem@davemloft.net, kuba@kernel.org, pabeni@redhat.com,
p.zabel@pengutronix.de, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Cc: BMC-SW@aspeedtech.com
Subject: Re: [PATCH v3 1/3] dt-bindings: net: add reset property for aspeed, ast2600-mdio binding
Date: Fri, 25 Mar 2022 13:19:28 +0100 [thread overview]
Message-ID: <6c44b745-36c7-4d28-74ea-590011892658@kernel.org> (raw)
In-Reply-To: <20220325041451.894-2-dylan_hung@aspeedtech.com>
On 25/03/2022 05:14, Dylan Hung wrote:
> The AST2600 MDIO bus controller has a reset control bit and must be
> deasserted before manipulating the MDIO controller. By default, the
> hardware asserts the reset so the driver only need to deassert it.
>
> Regarding to the old DT blobs which don't have reset property in them,
> the reset deassertion is usually done by the bootloader so the reset
> property is optional to work with them.
>
> Signed-off-by: Dylan Hung <dylan_hung@aspeedtech.com>
> ---
> .../devicetree/bindings/net/aspeed,ast2600-mdio.yaml | 5 +++++
> 1 file changed, 5 insertions(+)
>
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-03-25 12:19 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-25 4:14 [PATCH v3 0/3] Add reset deassertion for Aspeed MDIO Dylan Hung
2022-03-25 4:14 ` [PATCH v3 1/3] dt-bindings: net: add reset property for aspeed, ast2600-mdio binding Dylan Hung
2022-03-25 12:19 ` Krzysztof Kozlowski [this message]
2022-03-25 4:14 ` [PATCH v3 2/3] net: mdio: add reset control for Aspeed MDIO Dylan Hung
2022-03-31 7:12 ` Russell King (Oracle)
2022-04-07 6:29 ` Dylan Hung
2022-03-25 4:14 ` [PATCH v3 3/3] ARM: dts: aspeed: add reset properties into MDIO nodes Dylan Hung
2022-03-29 4:45 ` [PATCH v3 0/3] Add reset deassertion for Aspeed MDIO Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6c44b745-36c7-4d28-74ea-590011892658@kernel.org \
--to=krzk@kernel.org \
--cc=BMC-SW@aspeedtech.com \
--cc=andrew@aj.id.au \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=dylan_hung@aspeedtech.com \
--cc=hkallweit1@gmail.com \
--cc=joel@jms.id.au \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).