From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030795AbcGKOkx (ORCPT ); Mon, 11 Jul 2016 10:40:53 -0400 Received: from mout.gmx.net ([212.227.15.18]:60165 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030495AbcGKOkv (ORCPT ); Mon, 11 Jul 2016 10:40:51 -0400 To: David Binderman Cc: Joakim Bech , Linus Walleij , Herbert Xu , Linux Kernel From: =?UTF-8?Q?Toralf_F=c3=b6rster?= Subject: Re: crypto: ux500 - memmove the right size Message-ID: <6c579737-b46b-dc6a-102c-5b6931d4224a@gmx.de> Date: Mon, 11 Jul 2016 16:40:34 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:3BRV60Fk/OrBIeYt5Gd7LoL5PPS0glBV4jAtKGMn+nSFgziiQIB 2Rwc9tw42UKRhJE2ki4cYaPudf8+MFmCWkiiillS6J9wMMwXTzM9dZQBYZCB5WN0QRX1ion 4lSV+cLUd08cSd+GWGnYuEKVME4zHkcNElZzKsmBwKMVLwISLY5zIdw/JijokXcmQjA0tD8 HR6IPhLBJl07iT2HUN0YA== X-UI-Out-Filterresults: notjunk:1;V01:K0:D/3++q9zO3M=:EAFJH6dEDTxlCpN0gz0C3A do/X+hlW1yY3cznoU9RMJ9dLtcEVXFTMmB9Q2F/7CU2FdLN7nviARNgwSViNbZ95wzql1NTii AsFBzVsGC8ghhF91JbBDeCn3k3CMhjQ4HD03n66r0vuH2dEvd3G6RPfnDSkmqo/iKurzsMehS NjKbIKWgAX/NjFPpvlp5e0i8sIRibIyki/8bC4kPvAIyie+DgSZDMcnwFTiZBHIvsVSBV7V05 ER+SDI+Qz9mqaiXAXSJ0IwsJ3OVysztcYIizNGJiJYcp23g4c0X0+uMxC7raeV2+5Sm7FjdWl YYqWBnX3muItEQjTFhHvecKWMYe4ixDzc0WHDH3hsQecC+3frK2B7CHS5KRhMvzhMHBuy4dpR Q6ZCN6dGfzgx6axLWvaGk0cUavNxrObAR6f9cLWqVfYKE08NgpyxcWmYbLCI7qx0QdpTFW6cv x+5T4EdsNdoVi682UvoGwlDQd4OhFat+sQEUa2rjeUCgFscIPaG56UjiCJGmqEEFg+8XGoses JOBJw+8+WpCHJ2qgKQU6Cod3pkLHfMGJ+bd8tPKIS/mlB9orYrRc0j4CI+e3BzwLnYPxPPExz tnAIAQk7Bln1W6DFCg5hsaHFxRLbhqlHO4EVNd4KbivVU5BDPIgCP2tEVwzDG9wHIXSzM9zj9 +F1GT43GF7+q4oj/VWaSnRgUZoDQzX5WdoRBcYyJ285Ibe7xOfSN5Rn8aljKV881gQGKMavV/ HvkKdJTwOKWLDq7+LdGhfzzRjLXzhWO6FFTM6qXvSbHkvulj7TF0R0xoCgJZ+PQF2NVBkmSXT Ck6jH61 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org While reading the comment to 19ced623d : " The hash buffer is really HASH_BLOCK_SIZE bytes, someone must have thought that memmove takes n*u32 words by mistake. Tests work as good/bad as before after this patch. " I was just curious why the tests doesn't fail now and since when the bug were in the code. The answer to the later is simple - the bug is there since the beginning of that file. What's do you think about the first question ? -- Toralf PGP: C4EACDDE 0076E94E, OTR: 420E74C8 30246EE7