From: Daniel Wagner <wagi@monom.org>
To: "Luis R. Rodriguez" <mcgrof@kernel.org>,
Daniel Wagner <daniel.wagner@bmw-carit.de>
Cc: linux-kernel@vger.kernel.org, Ming Lei <ming.lei@canonical.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH v3 1/3] firmware_class: encapsulate firmware loading status
Date: Wed, 31 Aug 2016 09:13:45 +0200 [thread overview]
Message-ID: <6c589f0a-6503-6104-c10c-80ebd6884995@monom.org> (raw)
In-Reply-To: <20160830193446.GU3296@wotan.suse.de>
Hi Luis,
On 08/30/2016 09:34 PM, Luis R. Rodriguez wrote:
> On Mon, Aug 29, 2016 at 04:18:33PM +0200, Daniel Wagner wrote:
>> On 08/29/2016 11:50 AM, Daniel Wagner wrote:
>> I forgot to answer your question. So we have the dependency to
>> loading_timeout/firmware_loading_timeout from the firmware caching
>> path. The patch added in the previous email removes that dependency.
>>
>> We still need the 60 second even in the
>> !CONFIG_FW_LOADER_USER_HELPER case. I think it would be a regression
>> if we change that value, no?
>
> Oh that might be the disconnect, see my series of pending patches, I did away
> with the cache stuff using the usermode helper, the cache stuff should not use
> the usermode helper as the cache stuff kills off the pending usermode helper
> requests right before suspend.
The question is how do we proceed from here. I suggest that I don't
touch the fw cache path in my patches. Basically, leave it as it now.
After your series in, we cleanup this bit here, maybe even move the user
helper stuff into its own file.
I think this code is a big interleaved puzzle. Best thing is to split it
up and figure out what interacts with what. Moving this bits here out is
definitely the right direction.
cheers,
daniel
next prev parent reply other threads:[~2016-08-31 7:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-25 9:52 [PATCH v3 0/3] firmware_class: encapsulate firmware loading status Daniel Wagner
2016-08-25 9:52 ` [PATCH v3 1/3] " Daniel Wagner
2016-08-25 17:50 ` Luis R. Rodriguez
2016-08-29 9:50 ` Daniel Wagner
2016-08-29 14:18 ` Daniel Wagner
2016-08-30 19:34 ` Luis R. Rodriguez
2016-08-31 7:13 ` Daniel Wagner [this message]
2016-09-07 0:30 ` Luis R. Rodriguez
2016-08-25 9:52 ` [PATCH v3 2/3] firmware_class: Drop bit ops in favor of simple state machine Daniel Wagner
2016-08-25 9:52 ` [PATCH v3 3/3] firmware_class: Do not use fw_lock for fw_status protection Daniel Wagner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6c589f0a-6503-6104-c10c-80ebd6884995@monom.org \
--to=wagi@monom.org \
--cc=daniel.wagner@bmw-carit.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=ming.lei@canonical.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).