From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.4 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 34743C433E0 for ; Wed, 8 Jul 2020 04:51:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0E49C20853 for ; Wed, 8 Jul 2020 04:51:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="WUXj1hng" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729572AbgGHEvw (ORCPT ); Wed, 8 Jul 2020 00:51:52 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44852 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729539AbgGHEvu (ORCPT ); Wed, 8 Jul 2020 00:51:50 -0400 Received: from mail-wm1-x341.google.com (mail-wm1-x341.google.com [IPv6:2a00:1450:4864:20::341]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D76BDC08C5DC for ; Tue, 7 Jul 2020 21:51:49 -0700 (PDT) Received: by mail-wm1-x341.google.com with SMTP id g10so3093178wmc.1 for ; Tue, 07 Jul 2020 21:51:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=YM0IzGADgX2tl1Mp5AFtyEMSY+GtGZFBS0TzG37PEVo=; b=WUXj1hnghzt3S3Xl8PkHIhKgc4y1+imaFlRTqYId1bXkQETCFWvksi9OaC5IchDWnN /G3tZ3QPpXYdo0LQXnUBTJmqJT9KSLHL1W0ppqEv0GzEoRLMsgv7oAFu9hXuZV3qNwUU EmbTjiaI3Wsm/bQlCldA6nvGa0OVis92xbh6I= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=YM0IzGADgX2tl1Mp5AFtyEMSY+GtGZFBS0TzG37PEVo=; b=aB9owTrbYkCr6aFXlIpWWotZkvdmMKBGKSMy1pjYexe3J4g+wsZO3el5I2UkwO64S3 wtb4cdQUD641rsPUkLbj1yaY+vLx6cgoRaf8VNHJxzrwzoVYnCZ1ZjD2168O4+yezp2D +YAD7LhR9LkQi6Onk2xcAqwfQyFNqZnlCWlMfHSwDGtOh9eWmrcjJeFKJxreIP28lwYV 9M9vG+IPxnS79jreGVes7RNugHMHZURe7EyAojQKvvafBPmOvaOMHeiK5YhRSBMz7fA2 9qTk+bx2MWqge914CuxsmVJrLeLiTLLBolQ3NuB8Ebq9RW9IfZGRb1/MKYGo40O9Co8N WRIA== X-Gm-Message-State: AOAM530x8TMrQsul22upNAcB5SBYSvOkgIEfc6Gx8U4mbClAq72ylFq7 Y2CaRzQbdsyDrynbOfVaKytbAQ== X-Google-Smtp-Source: ABdhPJxCmxanR1p+Zv9NtrwZXxJyNGR3oD42FStMXE5QtLw0GpBvXi6oEnvGhedpl11EqTWK1HD1Eg== X-Received: by 2002:a1c:ba0b:: with SMTP id k11mr7135332wmf.140.1594183908367; Tue, 07 Jul 2020 21:51:48 -0700 (PDT) Received: from [10.136.13.65] ([192.19.228.250]) by smtp.gmail.com with ESMTPSA id y7sm3843597wrt.11.2020.07.07.21.51.41 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 07 Jul 2020 21:51:47 -0700 (PDT) Subject: Re: [PATCH v10 0/9] firmware: add request_partial_firmware_into_buf To: Florian Fainelli , Luis Chamberlain , Wolfram Sang , Greg Kroah-Hartman , David Brown , Alexander Viro , Shuah Khan , bjorn.andersson@linaro.org, Shuah Khan , Arnd Bergmann Cc: Mimi Zohar , "Rafael J . Wysocki" , linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-fsdevel@vger.kernel.org, BCM Kernel Feedback , Olof Johansson , Andrew Morton , Dan Carpenter , Colin Ian King , Kees Cook , Takashi Iwai , linux-kselftest@vger.kernel.org, Andy Gross , linux-integrity@vger.kernel.org, linux-security-module@vger.kernel.org References: <20200706232309.12010-1-scott.branden@broadcom.com> From: Scott Branden Message-ID: <6c6126cc-6572-b341-7808-5e573d0cfad8@broadcom.com> Date: Tue, 7 Jul 2020 21:51:39 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Florian, On 2020-07-07 9:38 p.m., Florian Fainelli wrote: > > On 7/6/2020 4:23 PM, Scott Branden wrote: >> This patch series adds partial read support via a new call >> request_partial_firmware_into_buf. >> Such support is needed when the whole file is not needed and/or >> only a smaller portion of the file will fit into allocated memory >> at any one time. >> In order to accept the enhanced API it has been requested that kernel >> selftests and upstreamed driver utilize the API enhancement and so >> are included in this patch series. >> >> Also in this patch series is the addition of a new Broadcom VK driver >> utilizing the new request_firmware_into_buf enhanced API. >> >> Further comment followed to add IMA support of the partial reads >> originating from request_firmware_into_buf calls. And another request >> to move existing kernel_read_file* functions to its own include file. > Do you have any way to separate the VK drivers submission from the > request_partial_firmware_into_buf() work that you are doing? It looks > like it is going to require quite a few iterations of this patch set for > the firmware/fs/IMA part to be ironed out, so if you could get your > driver separated out, it might help you achieve partial success here. Originally I did not submit the driver. But Greg K-H rejected the pread support unless there was an actual user in the kernel. Hence the need to submit this all in the patch series.