From: Thorsten Leemhuis <regressions@leemhuis.info>
To: "Peter Rosin" <peda@axentia.se>,
LKML <linux-kernel@vger.kernel.org>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>,
linux-pwm@vger.kernel.org
Cc: Thierry Reding <thierry.reding@gmail.com>,
Conor Dooley <conor.dooley@microchip.com>,
Claudiu Beznea <claudiu.beznea@microchip.com>
Subject: Re: PWM regression causing failures with the pwm-atmel driver
Date: Tue, 20 Jun 2023 16:24:31 +0200 [thread overview]
Message-ID: <6c622fd7-d79b-b7f2-50ee-00a0ec95a11b@leemhuis.info> (raw)
In-Reply-To: <7e2cfb55-e39f-2e5c-7f43-e1d275428bb5@axentia.se>
On 22.05.23 17:19, Peter Rosin wrote:
>
> I have a device with a "sound card" that has an amplifier that needs
> an extra boost when high amplification is requested. This extra
> boost is controlled with a pwm-regulator.
>
> As of commit c73a3107624d ("pwm: Handle .get_state() failures") this
> device no longer works. I have tracked the problem to an unfortunate
> interaction between the underlying PWM driver and the PWM core.
> [...]>
> Approach 1. will maybe clobber the saved pwm->state such that
> it no longer works to get the period/duty_cycle if/when the
> PWM is disabled? Maybe only for some corner case? But that might
> be a significant corner case?
>
> Approach 2. will maybe mess up some unrelated functionality?
>
> Approach 3. is ugly, intrusive and is in all likelihood
> incomplete. It also needs a rebase from the culprit commit.
>
> #regzbot introduced c73a3107624d
What happened to this? There was quite a bit of discussion, but then
nothing happened anymore.
Ciao, Thorsten (wearing his 'the Linux kernel's regression tracker' hat)
--
Everything you wanna know about Linux kernel regression tracking:
https://linux-regtracking.leemhuis.info/about/#tldr
If I did something stupid, please tell me, as explained on that page.
#regzbot poke
next prev parent reply other threads:[~2023-06-20 14:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-22 15:19 PWM regression causing failures with the pwm-atmel driver Peter Rosin
2023-05-22 16:25 ` Thierry Reding
2023-05-22 17:23 ` Uwe Kleine-König
2023-05-22 19:28 ` Peter Rosin
2023-05-22 20:43 ` Uwe Kleine-König
2023-05-22 23:34 ` Peter Rosin
2023-05-23 20:31 ` Thierry Reding
2023-05-24 6:37 ` Uwe Kleine-König
2023-06-20 14:24 ` Thorsten Leemhuis [this message]
2023-06-20 15:43 ` Peter Rosin
2023-06-20 16:30 ` Linux regression tracking #update (Thorsten Leemhuis)
2023-05-23 20:42 Peter Rosin
2023-05-24 6:07 ` Uwe Kleine-König
2023-05-24 7:45 Peter Rosin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6c622fd7-d79b-b7f2-50ee-00a0ec95a11b@leemhuis.info \
--to=regressions@leemhuis.info \
--cc=claudiu.beznea@microchip.com \
--cc=conor.dooley@microchip.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pwm@vger.kernel.org \
--cc=peda@axentia.se \
--cc=thierry.reding@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).