From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: "Amadeusz Sławiński" <amadeuszx.slawinski@linux.intel.com>,
alsa-devel@alsa-project.org
Cc: Cezary Rojewski <cezary.rojewski@intel.com>,
tiwai@suse.de, Jie Yang <yang.jie@linux.intel.com>,
Takashi Iwai <tiwai@suse.com>, Mac Chiang <mac.chiang@intel.com>,
srinivas.kandagatla@linaro.org, jank@cadence.com,
Amery Song <chao.song@intel.com>,
Bard liao <yung-chuan.liao@linux.intel.com>,
Pan Xiuli <xiuli.pan@linux.intel.com>,
Hui Wang <hui.wang@canonical.com>,
Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
Rander Wang <rander.wang@linux.intel.com>,
slawomir.blauciak@intel.com, broonie@kernel.org,
Christophe JAILLET <christophe.jaillet@wanadoo.fr>,
Sathyanarayana Nujella <sathyanarayana.nujella@intel.com>,
Naveen Manohar <naveen.m@intel.com>,
gregkh@linuxfoundation.org, Liam Girdwood <lgirdwood@gmail.com>,
linux-kernel@vger.kernel.org, vkoul@kernel.org,
Sathya Prakash M R <sathya.prakash.m.r@intel.com>
Subject: Re: [PATCH 01/10] ASoC: soc-acpi: expand description of _ADR-based devices
Date: Fri, 13 Mar 2020 11:21:53 -0500 [thread overview]
Message-ID: <6c6585b8-e359-2ca8-69e1-d17cd7dbc646@linux.intel.com> (raw)
In-Reply-To: <6ea77c3e-2333-2876-7fa1-ea8a2a6f35e4@linux.intel.com>
>> static const struct snd_soc_acpi_link_adr icl_3_in_1_default[] = {
>> {
>> .mask = BIT(0),
>> .num_adr = ARRAY_SIZE(rt711_0_adr),
>> - .adr = rt711_0_adr,
>> + .adr_d = rt711_0_adr,
>> },
>> {
>> .mask = BIT(1),
>> - .num_adr = ARRAY_SIZE(rt1308_1_adr),
>> - .adr = rt1308_1_adr,
>> + .num_adr = ARRAY_SIZE(rt1308_1_group1_adr),
>> + .adr_d = rt1308_1_adr,
>
> Is this right, you use different struct in ARRAY_SIZE and assignment?
>
>> },
>> {
>> .mask = BIT(2),
>> - .num_adr = ARRAY_SIZE(rt1308_2_adr),
>> - .adr = rt1308_2_adr,
>> + .num_adr = ARRAY_SIZE(rt1308_2_group1_adr),
>> + .adr_d = rt1308_2_adr,
>
> Same here.
it's of course an editing issue, thanks for spotting this.
it should be the exact same things as the structure used for cml:
static const struct snd_soc_acpi_link_adr cml_3_in_1_default[] = {
{
.mask = BIT(0),
.num_adr = ARRAY_SIZE(rt711_0_adr),
.adr_d = rt711_0_adr,
},
{
.mask = BIT(1),
.num_adr = ARRAY_SIZE(rt1308_1_group1_adr),
.adr_d = rt1308_1_group1_adr,
},
{
.mask = BIT(2),
.num_adr = ARRAY_SIZE(rt1308_2_group1_adr),
.adr_d = rt1308_2_group1_adr,
},
{
.mask = BIT(3),
.num_adr = ARRAY_SIZE(rt715_3_adr),
l .adr_d = rt715_3_adr,
},
{}
};
next prev parent reply other threads:[~2020-03-13 17:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-12 19:33 [PATCH 00/10] ASoC: SOF: Intel: add SoundWire support Pierre-Louis Bossart
2020-03-12 19:33 ` [PATCH 01/10] ASoC: soc-acpi: expand description of _ADR-based devices Pierre-Louis Bossart
2020-03-13 8:09 ` Amadeusz Sławiński
2020-03-13 16:21 ` Pierre-Louis Bossart [this message]
2020-03-12 19:33 ` [PATCH 02/10] ASoC: SOF: Intel: add SoundWire configuration interface Pierre-Louis Bossart
2020-03-12 19:33 ` [PATCH 03/10] ASoC: SOF: IPC: dai-intel: move ALH declarations in header file Pierre-Louis Bossart
2020-03-12 19:33 ` [PATCH 04/10] ASoC: SOF: Intel: hda: add SoundWire stream config/free callbacks Pierre-Louis Bossart
2020-03-12 19:33 ` [PATCH 05/10] ASoC: SOF: Intel: hda: initial SoundWire machine driver autodetect Pierre-Louis Bossart
2020-03-12 19:33 ` [PATCH 06/10] ASoC: SOF: Intel: hda: disable SoundWire interrupts on suspend Pierre-Louis Bossart
2020-03-12 19:33 ` [PATCH 07/10] ASoC: SOF: Intel: hda: merge IPC, stream and SoundWire interrupt handlers Pierre-Louis Bossart
2020-03-12 19:33 ` [PATCH 08/10] ASoC: SOF: Intel: hda: add parameter to control SoundWire clock stop quirks Pierre-Louis Bossart
2020-03-12 19:33 ` [PATCH 09/10] ASoC: SOF: Intel: hda: add WAKEEN interrupt support for SoundWire Pierre-Louis Bossart
2020-03-12 19:33 ` [PATCH 10/10] Asoc: SOF: Intel: hda: check SoundWire wakeen interrupt in irq thread Pierre-Louis Bossart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6c6585b8-e359-2ca8-69e1-d17cd7dbc646@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=amadeuszx.slawinski@linux.intel.com \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=chao.song@intel.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=gregkh@linuxfoundation.org \
--cc=hui.wang@canonical.com \
--cc=jank@cadence.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mac.chiang@intel.com \
--cc=naveen.m@intel.com \
--cc=rander.wang@linux.intel.com \
--cc=ranjani.sridharan@linux.intel.com \
--cc=sathya.prakash.m.r@intel.com \
--cc=sathyanarayana.nujella@intel.com \
--cc=slawomir.blauciak@intel.com \
--cc=srinivas.kandagatla@linaro.org \
--cc=tiwai@suse.com \
--cc=tiwai@suse.de \
--cc=vkoul@kernel.org \
--cc=xiuli.pan@linux.intel.com \
--cc=yang.jie@linux.intel.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).