From: Michael Walle <michael@walle.cc>
To: Steen Hegelund <steen.hegelund@microchip.com>
Cc: "Philipp Zabel" <p.zabel@pengutronix.de>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
"Lars Povlsen" <lars.povlsen@microchip.com>,
"Clément Léger" <clement.leger@bootlin.com>,
"Claudiu Beznea" <claudiu.beznea@microchip.com>,
"Kavyasree Kotagiri" <kavyasree.kotagiri@microchip.com>,
"Horatiu Vultur" <horatiu.vultur@microchip.com>
Subject: Re: [PATCH] Revert "reset: microchip-sparx5: allow building as a module"
Date: Tue, 09 Aug 2022 12:27:27 +0200 [thread overview]
Message-ID: <6c86be0e45807b86aff394026e015253@walle.cc> (raw)
In-Reply-To: <ba44019b3c4ae9052ca6ddfa6673b7f1c71d8891.camel@microchip.com>
Hi Steen,
Am 2022-08-09 12:19, schrieb Steen Hegelund:
> Sorry, but most people have been OOO (including me), so this has
> delayed the response.
>
> The protection bit protects the VCore Shared Bus (SBA) blocks shown on
> Figure 5-1. VCore System
> Block Diagram in the Datasheet. So in this case also the watchdog
> (which is the WDT block).
>
> I hope this clarifies the usage.
Actually, it does not. The watchdog was just an example. I'm
questioning the use of this reset for the switch block. Esp.
as it turns out that not even microchip knows what blocks
are actually reset.
This reset was first introduced for the DSA switch, since then
more and more spurious errors were discovered and it turns out
all of these errors was because the "switch" reset had some
severe side effects, like resetting the GPIO core and thus
turning all the GPIOs to input mode which then took some
peripherals into reset.
-michael
next prev parent reply other threads:[~2022-08-09 10:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-13 8:40 [PATCH] Revert "reset: microchip-sparx5: allow building as a module" Philipp Zabel
2022-07-13 9:03 ` Michael Walle
2022-07-13 9:40 ` Steen Hegelund
2022-07-13 9:52 ` Michael Walle
2022-07-13 12:08 ` Philipp Zabel
2022-08-04 7:53 ` Michael Walle
2022-08-09 10:19 ` Steen Hegelund
2022-08-09 10:27 ` Michael Walle [this message]
2022-08-26 11:37 ` Michael Walle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6c86be0e45807b86aff394026e015253@walle.cc \
--to=michael@walle.cc \
--cc=claudiu.beznea@microchip.com \
--cc=clement.leger@bootlin.com \
--cc=horatiu.vultur@microchip.com \
--cc=kavyasree.kotagiri@microchip.com \
--cc=lars.povlsen@microchip.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=steen.hegelund@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).