From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751551AbeE0Ufd (ORCPT ); Sun, 27 May 2018 16:35:33 -0400 Received: from mail-ot0-f193.google.com ([74.125.82.193]:39149 "EHLO mail-ot0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751317AbeE0Ufb (ORCPT ); Sun, 27 May 2018 16:35:31 -0400 X-Google-Smtp-Source: ADUXVKLBXRf0Ns/jFromrwcZISf7Y5pUY40KZvv2/LQj3ngYKHtrCTqJJ8gkApj31bNg+smMFcn8+Q== To: Gerhard Wiesinger , Andrew Lunn , initramfs@vger.kernel.org Cc: linux-kernel@vger.kernel.org References: <3bdb712d-38bd-e2ca-63cf-8406a7b5689d@wiesinger.com> <20180522201632.GB4396@lunn.ch> <59d6b55f-d50a-063c-90a9-31a758e01383@gmail.com> <76c3f5ec-0ab2-c06d-98e8-277284bb1a8e@gmail.com> <779f2be3-3e74-e650-5240-efaf1003d77c@wiesinger.com> <4f7c5173-019d-ba0e-70b3-addf64a6a9fa@gmail.com> <53c9272a-0e1a-e8fb-a3e4-b4e23e77be10@gmail.com> <18ca17a1-4673-2ace-7142-d4aef6854bc4@wiesinger.com> <219eaac0-3d76-005a-f8d6-c54ea21f205e@wiesinger.com> <485b3a0e-23d6-c90c-6f41-8d9f33b1ad1f@wiesinger.com> From: Florian Fainelli Openpgp: preference=signencrypt Autocrypt: addr=f.fainelli@gmail.com; prefer-encrypt=mutual; keydata= xsDiBEjPuBIRBACW9MxSJU9fvEOCTnRNqG/13rAGsj+vJqontvoDSNxRgmafP8d3nesnqPyR xGlkaOSDuu09rxuW+69Y2f1TzjFuGpBk4ysWOR85O2Nx8AJ6fYGCoeTbovrNlGT1M9obSFGQ X3IzRnWoqlfudjTO5TKoqkbOgpYqIo5n1QbEjCCwCwCg3DOH/4ug2AUUlcIT9/l3pGvoRJ0E AICDzi3l7pmC5IWn2n1mvP5247urtHFs/uusE827DDj3K8Upn2vYiOFMBhGsxAk6YKV6IP0d ZdWX6fqkJJlu9cSDvWtO1hXeHIfQIE/xcqvlRH783KrihLcsmnBqOiS6rJDO2x1eAgC8meAX SAgsrBhcgGl2Rl5gh/jkeA5ykwbxA/9u1eEuL70Qzt5APJmqVXR+kWvrqdBVPoUNy/tQ8mYc nzJJ63ng3tHhnwHXZOu8hL4nqwlYHRa9eeglXYhBqja4ZvIvCEqSmEukfivk+DlIgVoOAJbh qIWgvr3SIEuR6ayY3f5j0f2ejUMYlYYnKdiHXFlF9uXm1ELrb0YX4GMHz80nRmxvcmlhbiBG YWluZWxsaSA8Zi5mYWluZWxsaUBnbWFpbC5jb20+wmYEExECACYCGyMGCwkIBwMCBBUCCAME FgIDAQIeAQIXgAUCVF/S8QUJHlwd3wAKCRBhV5kVtWN2DvCVAJ4u4/bPF4P3jxb4qEY8I2gS 6hG0gACffNWlqJ2T4wSSn+3o7CCZNd7SLSDOw00ESM+4EhAQAL/o09boR9D3Vk1Tt7+gpYr3 WQ6hgYVON905q2ndEoA2J0dQxJNRw3snabHDDzQBAcqOvdi7YidfBVdKi0wxHhSuRBfuOppu pdXkb7zxuPQuSveCLqqZWRQ+Cc2QgF7SBqgznbe6Ngout5qXY5Dcagk9LqFNGhJQzUGHAsIs hap1f0B1PoUyUNeEInV98D8Xd/edM3mhO9nRpUXRK9Bvt4iEZUXGuVtZLT52nK6Wv2EZ1TiT OiqZlf1P+vxYLBx9eKmabPdm3yjalhY8yr1S1vL0gSA/C6W1o/TowdieF1rWN/MYHlkpyj9c Rpc281gAO0AP3V1G00YzBEdYyi0gaJbCEQnq8Vz1vDXFxHzyhgGz7umBsVKmYwZgA8DrrB0M oaP35wuGR3RJcaG30AnJpEDkBYHznI2apxdcuTPOHZyEilIRrBGzDwGtAhldzlBoBwE3Z3MY 31TOpACu1ZpNOMysZ6xiE35pWkwc0KYm4hJA5GFfmWSN6DniimW3pmdDIiw4Ifcx8b3mFrRO BbDIW13E51j9RjbO/nAaK9ndZ5LRO1B/8Fwat7bLzmsCiEXOJY7NNpIEpkoNoEUfCcZwmLrU +eOTPzaF6drw6ayewEi5yzPg3TAT6FV3oBsNg3xlwU0gPK3v6gYPX5w9+ovPZ1/qqNfOrbsE FRuiSVsZQ5s3AAMFD/9XjlnnVDh9GX/r/6hjmr4U9tEsM+VQXaVXqZuHKaSmojOLUCP/YVQo 7IiYaNssCS4FCPe4yrL4FJJfJAsbeyDykMN7wAnBcOkbZ9BPJPNCbqU6dowLOiy8AuTYQ48m vIyQ4Ijnb6GTrtxIUDQeOBNuQC/gyyx3nbL/lVlHbxr4tb6YkhkO6shjXhQh7nQb33FjGO4P WU11Nr9i/qoV8QCo12MQEo244RRA6VMud06y/E449rWZFSTwGqb0FS0seTcYNvxt8PB2izX+ HZA8SL54j479ubxhfuoTu5nXdtFYFj5Lj5x34LKPx7MpgAmj0H7SDhpFWF2FzcC1bjiW9mjW HaKaX23Awt97AqQZXegbfkJwX2Y53ufq8Np3e1542lh3/mpiGSilCsaTahEGrHK+lIusl6mz Joil+u3k01ofvJMK0ZdzGUZ/aPMZ16LofjFA+MNxWrZFrkYmiGdv+LG45zSlZyIvzSiG2lKy kuVag+IijCIom78P9jRtB1q1Q5lwZp2TLAJlz92DmFwBg1hyFzwDADjZ2nrDxKUiybXIgZp9 aU2d++ptEGCVJOfEW4qpWCCLPbOT7XBr+g/4H3qWbs3j/cDDq7LuVYIe+wchy/iXEJaQVeTC y5arMQorqTFWlEOgRA8OP47L9knl9i4xuR0euV6DChDrguup2aJVU8JPBBgRAgAPAhsMBQJU X9LxBQkeXB3fAAoJEGFXmRW1Y3YOj4UAn3nrFLPZekMeqX5aD/aq/dsbXSfyAKC45Go0YyxV HGuUuzv+GKZ6nsysJw== Subject: Re: B53 DSA switch problem on Banana Pi-R1 on Fedora 26 - systemd-networkd problem Message-ID: <6c93d27e-66dc-02a9-f8f9-f349f27dfec6@gmail.com> Date: Sun, 27 May 2018 13:35:27 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <485b3a0e-23d6-c90c-6f41-8d9f33b1ad1f@wiesinger.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 05/27/18 à 12:18, Gerhard Wiesinger a écrit : > On 27.05.2018 21:01, Gerhard Wiesinger wrote: >> On 24.05.2018 08:22, Gerhard Wiesinger wrote: >>> On 24.05.2018 07:29, Gerhard Wiesinger wrote: >>>> After some analysis with Florian (thnx) we found out that the >>>> current implementation is broken: >>>> >>>> https://patchwork.ozlabs.org/patch/836538/ >>>> https://github.com/torvalds/linux/commit/c499696e7901bda18385ac723b7bd27c3a4af624#diff-a2b6f8d89e18de600e873ac3ac43fa1d >>>> >>>> >>>> Florians comment: >>>> >>>> c499696e7901bda18385ac723b7bd27c3a4af624 ("net: dsa: b53: Stop using >>>> dev->cpu_port incorrectly") since it would result in no longer setting >>>> the CPU port as tagged for a specific VLAN. Easiest way for you right >>>> now is to just revert it, but this needs some more thoughts for a >>>> proper >>>> upstream change. I will think about it some more. >>> >>> Can confirm 4.14.18-200.fc26.armv7hl works, 4.15.x should be broken. >>> >>> # Kernel 4.14.x ok >>> https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git/log/drivers/net/dsa/b53?h=v4.14.43 >>> >>> # Kernel 4.15.x should be NOT ok >>> https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux-stable.git/log/drivers/net/dsa/b53?h=v4.15.18 >>> >> >> > > Forgot to mention: What's also strange is that the VLAN ID is very high: > > # 4.14.18-300.fc27.armv7hl, iproute-4.15.0-1.fc28.armv7hl > ip -d link show eth0.101 | grep "vlan protocol" >     vlan protocol 802.1Q id 3069279796 > ip -d link show eth0.102 | grep "vlan protocol" >     vlan protocol 802.1Q id 3068673588 > > On older kernels this looks ok: 4.12.8-200.fc25.armv7hl, > iproute-4.11.0-1.fc25.armv7hl: >  ip -d link show eth0.101 | grep "vlan protocol" >     vlan protocol 802.1Q id 101 > ip -d link show eth0.102 | grep "vlan protocol" >     vlan protocol 802.1Q id 102 > > Ideas? That is quite likely a kernel/iproute2 issue, if you configured the switch through bridge vlan to have the ports in VLAN 101 and VLAN 102 and you do indeed see frames entering eth0 with these VLAN IDs, then clearly the bridge -> switchdev -> dsa -> b53 part is working just fine and what you are seeing is some for of kernel header/netlink incompatibility. -- Florian