From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 759C9C54EAA for ; Mon, 30 Jan 2023 10:59:06 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236206AbjA3K7F (ORCPT ); Mon, 30 Jan 2023 05:59:05 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46364 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235466AbjA3K7B (ORCPT ); Mon, 30 Jan 2023 05:59:01 -0500 Received: from mail-wm1-x331.google.com (mail-wm1-x331.google.com [IPv6:2a00:1450:4864:20::331]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CC000C665 for ; Mon, 30 Jan 2023 02:58:59 -0800 (PST) Received: by mail-wm1-x331.google.com with SMTP id q10-20020a1cf30a000000b003db0edfdb74so8389249wmq.1 for ; Mon, 30 Jan 2023 02:58:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:from:to:cc:subject:date:message-id:reply-to; bh=crdBLJjZ8xjVRAu8KJba7OYDgK3CPZF1IA5JdFdJbwU=; b=g2Q0Ff4zAeNuvtFeFpbpYdAQd9H0Mxx3aXygc7KzaUDNoB4tQ172cm6fGO0Tqt1/X6 sy+eKO/mN68xD640n0qiJOcnuXssb7xiFcuR7NDaCpKD17SG7KmkB1svAgtlMMztdJaX qlM3WANBedE4GZDUfQQlz3tMFDMsBAdyb17CtOLwQ/I+VRlaWPcg9f3j+D5W62+7MoAz LEdnoLyZ3OZlWG/7IKjwnarJQV5MeCxxyIUDhHLOfwCmAPHns/t2K8xo/5XiveorLaY6 G5er5ZPvwmuka6MUoNMY/6+Xg6p8UDU84J3odI60gsyQ9b3n+k7YcKVJX/XV1HcaPfH9 0fqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:organization:references:cc:to :content-language:subject:reply-to:from:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=crdBLJjZ8xjVRAu8KJba7OYDgK3CPZF1IA5JdFdJbwU=; b=rNTrdN1CZ3pmgoc+ufzpDS/LW7zsRGypsIcJZLe+J25qM2mQ2EeEvRt766khVw81Ca BEuWjxlYkJBakZ2KsPkoV6IBdoaHZhT1UCkSRu9fa93vDMmK4KD+JlIixdYumIdi/Ypa 3s+2oUiQ0LP5oTq/nIb8M/3cUlZ3SCom4YAjrEgcG6icz9t9tQM2T7IPWx3FHgGhOT6b 04wjVTQQpE4fMYJieI7xQKlec1C9ZJCM9pDIAfocnc3vpgqIuyjtaGaunGDsttchPrJY rFgJpV2/imClIUR9h7ANfm8adc/QK3bjoQOPVhX+dacKPX15MEEVeSA82YW2EWLhDVLE Abew== X-Gm-Message-State: AO0yUKWzWJOF8UaQC+7bCPTU2a9SMUIFSCUxqzgLa2LDCG0bQddLYxkL 3UujGc8+9FVpFIa3ArW1WQbWyw== X-Google-Smtp-Source: AK7set+TP4uDjfgYi/r+gKabtLWtFYwZugrC1KUC0d8m1femfHdRjJcqAi/edEDKkxvgOQFk10c9qQ== X-Received: by 2002:a7b:c4d6:0:b0:3dc:5674:66e6 with SMTP id g22-20020a7bc4d6000000b003dc567466e6mr4107666wmk.25.1675076338341; Mon, 30 Jan 2023 02:58:58 -0800 (PST) Received: from [192.168.7.111] (679773502.box.freepro.com. [212.114.21.58]) by smtp.gmail.com with ESMTPSA id a19-20020a05600c349300b003cfa622a18asm16544888wmq.3.2023.01.30.02.58.57 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 30 Jan 2023 02:58:57 -0800 (PST) Message-ID: <6cde6bce-ce28-2dd0-1f16-4868ae93fb3f@linaro.org> Date: Mon, 30 Jan 2023 11:58:56 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 From: Neil Armstrong Reply-To: neil.armstrong@linaro.org Subject: Re: [PATCH 5/7] arm64: dts: qcom: sm8450-hdk: add pmic glink node Content-Language: en-US To: Konrad Dybcio , Heikki Krogerus , Greg Kroah-Hartman , Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski , Catalin Marinas , Will Deacon Cc: linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20230130-topic-sm8450-upstream-pmic-glink-v1-0-0b0acfad301e@linaro.org> <20230130-topic-sm8450-upstream-pmic-glink-v1-5-0b0acfad301e@linaro.org> <1c3fa66b-651f-c3c1-1751-af3f43c86c49@linaro.org> Organization: Linaro Developer Services In-Reply-To: <1c3fa66b-651f-c3c1-1751-af3f43c86c49@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 30/01/2023 11:40, Konrad Dybcio wrote: > > > On 30.01.2023 10:54, Neil Armstrong wrote: >> Add the pmic glink node linked with the DWC3 USB controller >> switched to OTG mode and tagged with usb-role-switch. >> >> Signed-off-by: Neil Armstrong > Missing commit message ?? > >> --- >> arch/arm64/boot/dts/qcom/sm8450-hdk.dts | 34 ++++++++++++++++++++++++++++++++- >> 1 file changed, 33 insertions(+), 1 deletion(-) >> >> diff --git a/arch/arm64/boot/dts/qcom/sm8450-hdk.dts b/arch/arm64/boot/dts/qcom/sm8450-hdk.dts >> index 5bdc2c1159ae..5ab12c911bfe 100644 >> --- a/arch/arm64/boot/dts/qcom/sm8450-hdk.dts >> +++ b/arch/arm64/boot/dts/qcom/sm8450-hdk.dts >> @@ -87,6 +87,31 @@ lt9611_3v3: lt9611-3v3-regulator { >> enable-active-high; >> }; >> >> + pmic-glink { >> + compatible = "qcom,sm8450-pmic-glink", "qcom,pmic-glink"; >> + > You could remove this newline >> + #address-cells = <1>; >> + #size-cells = <0>; >> + >> + connector@0 { >> + compatible = "usb-c-connector"; >> + reg = <0>; >> + power-role = "dual"; >> + data-role = "dual"; >> + >> + ports { >> + #address-cells = <1>; >> + #size-cells = <0>; > And add one here > >> + port@0 { >> + reg = <0>; > And here > Ack >> + pmic_glink_dwc3_in: endpoint { >> + remote-endpoint = <&usb_1_dwc3_out>; >> + }; >> + }; >> + }; >> + }; >> + }; >> + >> vph_pwr: vph-pwr-regulator { >> compatible = "regulator-fixed"; >> regulator-name = "vph_pwr"; >> @@ -724,7 +749,14 @@ &usb_1 { >> }; >> >> &usb_1_dwc3 { >> - dr_mode = "peripheral"; >> + dr_mode = "otg"; >> + usb-role-switch; >> + >> + port { > Hm, maybe this could be moved to 8450 dtsi? Nop because it depends on the board layout, I think dr_mode and eventual connector description should really stay in the board dts. Thanks, Neil > > Konrad >> + usb_1_dwc3_out: endpoint { >> + remote-endpoint = <&pmic_glink_dwc3_in>; >> + }; >> + }; >> }; >> >> &usb_1_hsphy { >>