From: Chao Yu <yuchao0@huawei.com>
To: Sayali Lokhande <sayalil@codeaurora.org>, <jaegeuk@kernel.org>,
<linux-f2fs-devel@lists.sourceforge.net>
Cc: <stummala@codeaurora.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V2] f2fs: Avoid double lock for cp_rwsem during checkpoint
Date: Mon, 27 Apr 2020 14:08:39 +0800 [thread overview]
Message-ID: <6cfb8f00-a36c-03b9-ffa7-12fe37a19317@huawei.com> (raw)
In-Reply-To: <1587967204-24824-1-git-send-email-sayalil@codeaurora.org>
On 2020/4/27 14:00, Sayali Lokhande wrote:
> There could be a scenario where f2fs_sync_node_pages gets
> called during checkpoint, which in turn tries to flush
> inline data and calls iput(). This results in deadlock as
> iput() tries to hold cp_rwsem, which is already held at the
> beginning by checkpoint->block_operations().
>
> Call stack :
>
> Thread A Thread B
> f2fs_write_checkpoint()
> - block_operations(sbi)
> - f2fs_lock_all(sbi);
> - down_write(&sbi->cp_rwsem);
>
> - open()
> - igrab()
> - write() write inline data
> - unlink()
> - f2fs_sync_node_pages()
> - if (is_inline_node(page))
> - flush_inline_data()
> - ilookup()
> page = f2fs_pagecache_get_page()
> if (!page)
> goto iput_out;
> iput_out:
>
> - iput()
^^^^
- close()
- iput()
> iput(inode);
> - f2fs_evict_inode()
> - f2fs_truncate_blocks()
> - f2fs_lock_op()
> - down_read(&sbi->cp_rwsem);
>
> Signed-off-by: Sayali Lokhande <sayalil@codeaurora.org>
Reviewed-by: Chao Yu <yuchao0@huawei.com>
Thanks,
prev parent reply other threads:[~2020-04-27 6:08 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-27 6:00 [PATCH V2] f2fs: Avoid double lock for cp_rwsem during checkpoint Sayali Lokhande
2020-04-27 6:08 ` Chao Yu [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6cfb8f00-a36c-03b9-ffa7-12fe37a19317@huawei.com \
--to=yuchao0@huawei.com \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=sayalil@codeaurora.org \
--cc=stummala@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).