From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68F53EB64DB for ; Wed, 14 Jun 2023 20:44:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231890AbjFNUoE (ORCPT ); Wed, 14 Jun 2023 16:44:04 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:60326 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234728AbjFNUny (ORCPT ); Wed, 14 Jun 2023 16:43:54 -0400 Received: from mail-lj1-x22f.google.com (mail-lj1-x22f.google.com [IPv6:2a00:1450:4864:20::22f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A2BFC26AE for ; Wed, 14 Jun 2023 13:43:48 -0700 (PDT) Received: by mail-lj1-x22f.google.com with SMTP id 38308e7fff4ca-2b4146fbadeso3899011fa.0 for ; Wed, 14 Jun 2023 13:43:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1686775427; x=1689367427; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=gnrG9KChTMPpV2GR073pHnVbkT85PvROO9LvdxI9ZkQ=; b=mTmD8axPvJ7WvNXHDx/JtOirWKs2GgaDe6vCpXQUHUKQbrcDsZsUiy3RV0kkPtB1tM 8uw15CKRZUeRKxbu8KMkePjl7W/OuUR33fChoJ5xIjVcpOhJAh1dDhZNkZf9OrCHggZ/ LmFhOg6t0ih9/yOJjgKUHEDJkSh3V70e7q2lPGJMC1K7aYxBcDoJ5C6wXi/Z+FtqNRmU 4HRXPqtfHLZhw8pD10YEAl8Cu0OkIBTy8Oy26dTNSeFPKhtW4jU2rkWvgTPdKFO4znao E4Fx/BOrkFPlA3cYXVVZRDrmh209A93olwjRIWHMDdvqgB8/vTFUv1R+efc2jhikUrKm Dc1Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686775427; x=1689367427; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=gnrG9KChTMPpV2GR073pHnVbkT85PvROO9LvdxI9ZkQ=; b=kdFK2RZuBYtZzWcWGU/9lyUQIZoxRvLqGU4+4HET2remPuTConywZkTzA1Xf0QIHzJ +l2XeN/Z2dlYzNkDQaEDs8YD364w0Gq6tYixP8WyibadG475J7lPtX6T+ARn6ve0kQb/ eqzDNyF1tiC/RMj89jw3A0EGqWEnRWcDUApWad+y/Y79caLLOZYuw6qCOfCkbe/EsFsE Wsq7VUfflEsUtOgdJjalDZzLzEtHkt9nUsHquLK+6n2vEK1oPh3CmOr/EfA8nxWhyLQl VwpxQa54qYESCP1DFosbjiqVqkWkS1CYR5Qe4aKiM0sOFJZND1Dgm2vrbSpiRAekKgVK 7Y3g== X-Gm-Message-State: AC+VfDw0E597fEb7mZAwCQmNBwrhLQJvNgRUxrCcj18kYTkyXd4QthaW 0GThVvh19s0uzWYvd1g2FNsdAw== X-Google-Smtp-Source: ACHHUZ4fOHLIOo1tCMymf158dIbyoooCjk/fibobBvxxerAC6a+4vEgse11pXH7r/N0IVjx1KkX35g== X-Received: by 2002:a2e:9f14:0:b0:2af:1dce:8efd with SMTP id u20-20020a2e9f14000000b002af1dce8efdmr6702594ljk.36.1686775426830; Wed, 14 Jun 2023 13:43:46 -0700 (PDT) Received: from ?IPV6:2001:14ba:a0db:1f00::8a5? (dzdqv0yyyyyyyyyyybcwt-3.rev.dnainternet.fi. [2001:14ba:a0db:1f00::8a5]) by smtp.gmail.com with ESMTPSA id b10-20020a2e988a000000b002ac7a25c001sm2727819ljj.24.2023.06.14.13.43.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 14 Jun 2023 13:43:46 -0700 (PDT) Message-ID: <6d11e420-1b95-0029-ec7a-17fbc8acb5ca@linaro.org> Date: Wed, 14 Jun 2023 23:43:45 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [Freedreno] [PATCH 1/3] drm/msm/dpu: Add DPU_INTF_DATABUS_WIDEN feature flag for DPU >= 5.0 Content-Language: en-GB To: Abhinav Kumar , Marijn Suijten Cc: freedreno@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Jessica Zhang , Sean Paul References: <20230525-add-widebus-support-v1-0-c7069f2efca1@quicinc.com> <20230525-add-widebus-support-v1-1-c7069f2efca1@quicinc.com> <08b6aaf4-6edd-4f41-5d98-11ffc27e766e@quicinc.com> From: Dmitry Baryshkov In-Reply-To: <08b6aaf4-6edd-4f41-5d98-11ffc27e766e@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 14/06/2023 23:39, Abhinav Kumar wrote: > > > On 6/14/2023 12:54 PM, Abhinav Kumar wrote: >> >> >> On 6/14/2023 12:35 PM, Abhinav Kumar wrote: >>> >>> >>> On 6/14/2023 5:23 AM, Marijn Suijten wrote: >>>> On 2023-06-14 15:01:59, Dmitry Baryshkov wrote: >>>>> On 14/06/2023 14:42, Marijn Suijten wrote: >>>>>> On 2023-06-13 18:57:11, Jessica Zhang wrote: >>>>>>> DPU 5.x+ supports a databus widen mode that allows more data to >>>>>>> be sent >>>>>>> per pclk. Enable this feature flag on all relevant chipsets. >>>>>>> >>>>>>> Signed-off-by: Jessica Zhang >>>>>>> --- >>>>>>>    drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c | 3 ++- >>>>>>>    drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.h | 2 ++ >>>>>>>    2 files changed, 4 insertions(+), 1 deletion(-) >>>>>>> >>>>>>> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c >>>>>>> b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c >>>>>>> index 36ba3f58dcdf..0be7bf0bfc41 100644 >>>>>>> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c >>>>>>> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_hw_catalog.c >>>>>>> @@ -103,7 +103,8 @@ >>>>>>>        (BIT(DPU_INTF_INPUT_CTRL) | \ >>>>>>>         BIT(DPU_INTF_TE) | \ >>>>>>>         BIT(DPU_INTF_STATUS_SUPPORTED) | \ >>>>>>> -     BIT(DPU_DATA_HCTL_EN)) >>>>>>> +     BIT(DPU_DATA_HCTL_EN) | \ >>>>>>> +     BIT(DPU_INTF_DATABUS_WIDEN)) >>>>>> >>>>>> This doesn't work.  DPU 5.0.0 is SM8150, which has DSI 6G 2.3.  In >>>>>> the >>>>>> last patch for DSI you state and enable widebus for DSI 6G 2.5+ only, >>>>>> meaning DPU and DSI are now desynced, and the output is completely >>>>>> corrupted. >>>> > > I looked at the internal docs and also this change. This change is > incorrect because this will try to enable widebus for DPU >= 5.0 and DSI > >= 2.5 > > That was not the intended right condition as thats not what the docs say. > > We should enable for DPU >= 7.0 and DSI >= 2.5 > > Is there any combination where this compatibility is broken? That would > be the strange thing for me ( not DPU 5.0 and DSI 2.5 as that was > incorrect) > > Part of this confusion is because of catalog macro re-use again. > > This series is a good candidate and infact I think we should only do > core_revision based check on DPU and DSI to avoid bringing the catalog > mess into this. I have just a single request here: can we please have the same approach for both DSI and DP? I don't mind changing DP code if it makes it better. If you don't have better reasons, I like the idea of DSI/DP dictating whether wide bus should be used on the particular interface. It allows us to handle possible errata or corner cases there. Another option would be to make DPU tell DSI / DP whether the wide bus is enabled or not, but I'd say, this is slightly worse solution. > >>>> Tested this on SM8350 which actually has DSI 2.5, and it is also >>>> corrupted with this series so something else on this series might be >>>> broken. >>>> >> >> Missed this response. That seems strange. >> >> This series was tested on SM8350 HDK with a command mode panel. >> >> We will fix the DPU-DSI handshake and post a v2 but your issue needs >> investigation in parallel. >> >> So another bug to track that would be great. >> >>>>>> Is the bound in dsi_host wrong, or do DPU and DSI need to communicate >>>>>> when widebus will be enabled, based on DPU && DSI supporting it? >>>>> >>>>> I'd prefer to follow the second approach, as we did for DP. DPU >>>>> asks the >>>>> actual video output driver if widebus is to be enabled. >>>> >>> >>> I was afraid of this. This series was made on an assumption that the >>> DPU version of widebus and DSI version of widebus would be compatible >>> but looks like already SM8150 is an outlier. >>> >>> Yes, I think we have to go with second approach. >>> >>> DPU queries DSI if it supports widebus and enables it. >>> >>> Thanks for your responses. We will post a v2. >>> >>>> Doesn't it seem very strange that DPU 5.x+ comes with a widebus >>>> feature, >>>> but the DSI does not until two revisions later?  Or is this >>>> available on >>>> every interface, but only for a different (probably DP) encoder block? >>>> >>> >>> Yes its strange. >>> > > I have clarified this above. Its not strange but appeared strange > because we were checking wrong conditions. > > >>>> - Marijn -- With best wishes Dmitry