From: Keerthy <j-keerthy@ti.com>
To: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: Vignesh R <vigneshr@ti.com>, Bjorn Helgaas <bhelgaas@google.com>,
Kishon Vijay Abraham I <kishon@ti.com>,
<linux-omap@vger.kernel.org>, <linux-pci@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] pci: dwc: pci-dra7xx: Make shutdown handler static
Date: Wed, 20 Dec 2017 17:29:44 +0530 [thread overview]
Message-ID: <6d133940-26fd-6e62-77ed-d15c9b437aaa@ti.com> (raw)
In-Reply-To: <20171220102955.GA941@red-moon>
On Wednesday 20 December 2017 03:59 PM, Lorenzo Pieralisi wrote:
> On Fri, Dec 01, 2017 at 04:53:14PM +0000, Lorenzo Pieralisi wrote:
>> On Fri, Dec 01, 2017 at 10:43:53AM +0530, Keerthy wrote:
>>>
>>>
>>> On Friday 01 December 2017 10:36 AM, Vignesh R wrote:
>>>> Declare dra7xx_pcie_shutdown() as a static function as its not used
>>>> elsewhere.
>>>
>>> Seems like the below version that had static version was not taken:
>>>
>>> https://patchwork.kernel.org/patch/10052579/
>>
>> It looks like I can drop the patch above then - let me know if
>> that's ok.
>
> I would appreciate some feedback; I assume that dropping the patch above
> and applying the patch in $SUBJECT is what you expect, if there is a
> problem with that please manifest yourselves.
Applying this patch is fine. Thanks.
>
> Lorenzo
>
>> Thanks,
>> Lorenzo
>>
>>> So for this patch:
>>>
>>> Reviewed-by: Keerthy <j-keerthy@ti.com>
>>>
>>>>
>>>> Signed-off-by: Vignesh R <vigneshr@ti.com>
>>>> ---
>>>> drivers/pci/dwc/pci-dra7xx.c | 2 +-
>>>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>>>
>>>> diff --git a/drivers/pci/dwc/pci-dra7xx.c b/drivers/pci/dwc/pci-dra7xx.c
>>>> index 59e8de34cec6..b9db442af793 100644
>>>> --- a/drivers/pci/dwc/pci-dra7xx.c
>>>> +++ b/drivers/pci/dwc/pci-dra7xx.c
>>>> @@ -815,7 +815,7 @@ static int dra7xx_pcie_resume_noirq(struct device *dev)
>>>> }
>>>> #endif
>>>>
>>>> -void dra7xx_pcie_shutdown(struct platform_device *pdev)
>>>> +static void dra7xx_pcie_shutdown(struct platform_device *pdev)
>>>> {
>>>> struct device *dev = &pdev->dev;
>>>> struct dra7xx_pcie *dra7xx = dev_get_drvdata(dev);
>>>>
next prev parent reply other threads:[~2017-12-20 11:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-01 5:06 [PATCH] pci: dwc: pci-dra7xx: Make shutdown handler static Vignesh R
2017-12-01 5:13 ` Keerthy
2017-12-01 16:53 ` Lorenzo Pieralisi
2017-12-20 10:29 ` Lorenzo Pieralisi
2017-12-20 11:59 ` Keerthy [this message]
2017-12-20 11:11 ` Lorenzo Pieralisi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d133940-26fd-6e62-77ed-d15c9b437aaa@ti.com \
--to=j-keerthy@ti.com \
--cc=bhelgaas@google.com \
--cc=kishon@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).