From: "Jan Lübbe" <jlu@pengutronix.de>
To: Joakim Zhang <qiangqing.zhang@nxp.com>,
"srinivas.kandagatla@linaro.org" <srinivas.kandagatla@linaro.org>,
"robh+dt@kernel.org" <robh+dt@kernel.org>,
"shawnguo@kernel.org" <shawnguo@kernel.org>
Cc: "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
dl-linux-imx <linux-imx@nxp.com>,
"kernel@pengutronix.de" <kernel@pengutronix.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V1 1/4] bindings: nvmem: introduce "reverse-data" property
Date: Wed, 11 Aug 2021 11:05:38 +0200 [thread overview]
Message-ID: <6d396b18455a228719ac4ffeeddcca20b0aa0184.camel@pengutronix.de> (raw)
In-Reply-To: <VI1PR04MB6800D794307B1BDF7100E773E6F89@VI1PR04MB6800.eurprd04.prod.outlook.com>
On Wed, 2021-08-11 at 08:06 +0000, Joakim Zhang wrote:
>
> > -----Original Message-----
> > From: Joakim Zhang <qiangqing.zhang@nxp.com>
> > Sent: 2021年8月11日 16:05
> > To: Jan Lübbe <jlu@pengutronix.de>; srinivas.kandagatla@linaro.org;
> > robh+dt@kernel.org; shawnguo@kernel.org
> > Cc: devicetree@vger.kernel.org; dl-linux-imx <linux-imx@nxp.com>;
> > kernel@pengutronix.de; linux-kernel@vger.kernel.org
> > Subject: RE: [PATCH V1 1/4] bindings: nvmem: introduce "reverse-data"
> > property
> >
> >
> > > -----Original Message-----
> > > From: Jan Lübbe <jlu@pengutronix.de>
> > > Sent: 2021年8月10日 23:14
> > > To: Joakim Zhang <qiangqing.zhang@nxp.com>;
> > > srinivas.kandagatla@linaro.org; robh+dt@kernel.org;
> > > shawnguo@kernel.org
> > > Cc: devicetree@vger.kernel.org; dl-linux-imx <linux-imx@nxp.com>;
> > > kernel@pengutronix.de; linux-kernel@vger.kernel.org
> > > Subject: Re: [PATCH V1 1/4] bindings: nvmem: introduce "reverse-data"
> > > property
> > >
> > > On Tue, 2021-08-10 at 15:35 +0800, Joakim Zhang wrote:
> > > > Introduce "reverse-data" property for nvmem provider to reverse buffer.
> > > >
> > > > Signed-off-by: Joakim Zhang <qiangqing.zhang@nxp.com>
> > > > ---
> > > > Documentation/devicetree/bindings/nvmem/nvmem.yaml | 5 +++++
> > > > 1 file changed, 5 insertions(+)
> > > >
> > > > diff --git a/Documentation/devicetree/bindings/nvmem/nvmem.yaml
> > > > b/Documentation/devicetree/bindings/nvmem/nvmem.yaml
> > > > index b8dc3d2b6e92..bc745083fc64 100644
> > > > --- a/Documentation/devicetree/bindings/nvmem/nvmem.yaml
> > > > +++ b/Documentation/devicetree/bindings/nvmem/nvmem.yaml
> > > > @@ -61,6 +61,11 @@ patternProperties:
> > > > description:
> > > > Size in bit within the address range specified by reg.
> > > >
> > > > + reverse-data:
> > > > + $ref: /schemas/types.yaml#/definitions/flag
> > > > + description:
> > > > + Reverse the data that read from the storage device.
> > >
> > > I'd prefer if it was more explicit that the *bytes* will be reversed.
> > > Otherwise a reader might think that this is reversing on the *bit* level.
> >
> > Make sense, how about 'reverse-byte-order'?
>
> Sorry, 'reverse-bytes-order'.
'reverse-byte-order' sounds better to me, but I'm not a native English speaker.
I'd be fine with either, though.
Thanks
Jan
next prev parent reply other threads:[~2021-08-11 9:05 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-10 7:35 [PATCH V1 0/4] nvmem: introduce "reverse-data" property Joakim Zhang
2021-08-10 7:35 ` [PATCH V1 1/4] bindings: " Joakim Zhang
2021-08-10 15:14 ` Jan Lübbe
2021-08-11 8:05 ` Joakim Zhang
2021-08-11 8:06 ` Joakim Zhang
2021-08-11 9:05 ` Jan Lübbe [this message]
2021-08-11 10:16 ` Srinivas Kandagatla
2021-08-17 19:58 ` Rob Herring
2021-08-18 7:54 ` Joakim Zhang
2021-08-24 6:31 ` Joakim Zhang
2021-09-03 12:37 ` Srinivas Kandagatla
2021-09-06 8:58 ` Joakim Zhang
2021-09-07 10:11 ` Srinivas Kandagatla
2021-09-08 7:14 ` Joakim Zhang
2021-09-08 8:48 ` Srinivas Kandagatla
2021-09-08 8:57 ` Joakim Zhang
2021-09-08 9:21 ` Srinivas Kandagatla
2021-08-10 7:35 ` [PATCH V1 2/4] nvmem: core: introduce "reverse-data" property to reverse buffer Joakim Zhang
2021-08-11 9:52 ` Srinivas Kandagatla
2021-08-11 10:16 ` Joakim Zhang
2021-08-10 7:35 ` [PATCH V1 3/4] arm64: dts: imx8m: add "reverse-data" property for MAC ocopt Joakim Zhang
2021-08-10 7:35 ` [PATCH V1 4/4] arm64: dts: imx8m: remove unused "nvmem_macaddr_swap" property for FEC Joakim Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d396b18455a228719ac4ffeeddcca20b0aa0184.camel@pengutronix.de \
--to=jlu@pengutronix.de \
--cc=devicetree@vger.kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-imx@nxp.com \
--cc=linux-kernel@vger.kernel.org \
--cc=qiangqing.zhang@nxp.com \
--cc=robh+dt@kernel.org \
--cc=shawnguo@kernel.org \
--cc=srinivas.kandagatla@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).