From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Konrad Dybcio <konrad.dybcio@linaro.org>,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
andersson@kernel.org, agross@kernel.org, mturquette@baylibre.com,
sboyd@kernel.org, dmitry.baryshkov@linaro.org,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, jonathan@marek.ca, quic_tdas@quicinc.com,
vladimir.zapolskiy@linaro.org
Cc: linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCH v4 3/4] clk: qcom: camcc-sc8280xp: Add sc8280xp CAMCC
Date: Thu, 26 Oct 2023 12:34:27 +0100 [thread overview]
Message-ID: <6d44b972-9337-472a-9010-71ebaa0d45cf@linaro.org> (raw)
In-Reply-To: <20e2801d-df4f-436e-a677-2c81d43e3273@linaro.org>
On 26/10/2023 12:21, Konrad Dybcio wrote:
>> + .flags = HW_CTRL | RETAIN_FF_ENABLE,
> This should really be HW_CTRL_TRIGGER from [1]
>
> and then downstream uses cam_bps_transfer_gdsc_control and
> cam_bps_get_gdsc_control to control hw (fast) or sw (normal) mode
>
> similarly in drivers/cam_icp/icp_hw/ipe_hw/ipe_soc.c for IPE
I'm happy to do such a conversion if said patch hits -next, qcom-next or
clk-next before this patch, otherwise I'd rather not gate this driver on
stuff that's not queued anywhere.
There's alot of CAMSS stuff driver/compat/dtsi that is gated on having
the CAMCC upstream, effectively all of the CAMSS stuff for sc8280xp.
Fair ?
---
bod
next prev parent reply other threads:[~2023-10-26 11:34 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-26 10:53 [RESEND PATCH v4 0/4] Add sc8280xp CAMCC bindings and driver Bryan O'Donoghue
2023-10-26 10:53 ` [RESEND PATCH v4 1/4] dt-bindings: clock: Use gcc.yaml for common clock properties Bryan O'Donoghue
2023-10-26 10:53 ` [RESEND PATCH v4 2/4] dt-bindings: clock: Add SC8280XP CAMCC Bryan O'Donoghue
2023-10-26 10:53 ` [RESEND PATCH v4 3/4] clk: qcom: camcc-sc8280xp: Add sc8280xp CAMCC Bryan O'Donoghue
2023-10-26 11:21 ` Konrad Dybcio
2023-10-26 11:34 ` Bryan O'Donoghue [this message]
2023-10-26 18:39 ` Konrad Dybcio
2023-10-26 10:53 ` [RESEND PATCH v4 4/4] arm64: dts: qcom: sc8280xp: Add in CAMCC for sc8280xp Bryan O'Donoghue
2023-10-26 11:21 ` Konrad Dybcio
2023-11-16 12:16 ` [RESEND PATCH v4 0/4] Add sc8280xp CAMCC bindings and driver Bryan O'Donoghue
2023-12-08 2:57 ` (subset) " Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6d44b972-9337-472a-9010-71ebaa0d45cf@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=agross@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=jonathan@marek.ca \
--cc=konrad.dybcio@linaro.org \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=quic_tdas@quicinc.com \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).